Re: [Buildroot] [PATCH 4/5] package/dpdk: make libraries selectable

From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Maxime Leroy <maxime@leroys.fr>
Cc: buildroot@buildroot.org, Vincent Jardin <vjardin@free.fr>
Subject: Re: [Buildroot] [PATCH 4/5] package/dpdk: make libraries selectable
Date: Sun, 30 Nov 2025 15:41:47 +0100	[thread overview]
Message-ID: <bb3fe35a7bb2ef59404c26bc63b4a178@free.fr> (raw)
In-Reply-To: <20251021120342.483933-5-maxime@leroys.fr>

Hi Maxime,

I have mostly the same comments as for the dpdk driver
list patch [1].

On 21/10/2025 14:03, Maxime Leroy wrote:
> Add BR2_PACKAGE_DPDK_LIBS_LIST to control which DPDK libraries are
> built:
>   - empty : use DPDK defaults
>   - none  : disable all libs (-Ddisable_libs='*')
>   - list  : pass to -Denable_libs= (comma-separated)
> 
> Signed-off-by: Maxime Leroy <maxime@leroys.fr>
> ---
>  package/dpdk/Config.in | 14 ++++++++++++++
>  package/dpdk/dpdk.mk   |  9 +++++++++
>  2 files changed, 23 insertions(+)
> 
> diff --git a/package/dpdk/Config.in b/package/dpdk/Config.in
> index 5de1c63937..e311611548 100644
> --- a/package/dpdk/Config.in
> +++ b/package/dpdk/Config.in
> @@ -64,6 +64,20 @@ config BR2_PACKAGE_DPDK_DRIVERS_LIST
>  	    find drivers -mindepth 2 -maxdepth 2 -type d \
>  	    ! -printf '%P\n' | sort
> 
> +config BR2_PACKAGE_DPDK_LIBS_LIST
> +	string "Comma-separated libraries (e.g. graph,hash,fib)"

Could you make the prompt a bit shorter by moving the example
in the help section. For example:
	string "List of enabled libraries"

> +	help
> +	  Controls which DPDK libraries are built.
> +
> +	  Values:
> +	    (empty): use DPDK defaults
> +	    none   : build no libraries
> +	    list   : e.g. "graph,hash,fib"

Could you provide a simple working example, please?

Testing the provided example with the commands:

cat >.config <<EOF
BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_PACKAGE_DPDK=y
BR2_PACKAGE_DPDK_LIBS_LIST="graph,hash,fib"
EOF
make olddefconfig
make dpdk

Fails with error:

ERROR: Problem encountered: Cannot build explicitly requested lib "fib".
	Please add missing dependency "rib" to "enable_libs" option

> +
> +	  To list all libraries found in the DPDK source tree:
> +	    find lib -mindepth 2 -maxdepth 2 -type f -name meson.build \
> +	      -printf '%h\n' | xargs -n1 basename | sort -u

Could you add a comment in the help section about the
dependencies?

> +
>  endif
> 
>  comment "dpdk needs a glibc toolchain w/ threads, gcc >= 4.9, headers 
> >= 4.19"
> diff --git a/package/dpdk/dpdk.mk b/package/dpdk/dpdk.mk
> index 9333a67c31..e54668ca2d 100644
> --- a/package/dpdk/dpdk.mk
> +++ b/package/dpdk/dpdk.mk
> @@ -56,6 +56,15 @@ ifneq ($(DPDK_DRIVERS),)
>    endif
>  endif
> 
> +DPDK_LIBS := $(call qstrip,$(BR2_PACKAGE_DPDK_LIBS_LIST))
> +ifneq ($(DPDK_LIBS),)
> +  ifeq ($(DPDK_LIBS),none)
> +    DPDK_CONF_OPTS += -Ddisable_libs='*'
> +  else
> +    DPDK_CONF_OPTS += -Denable_libs='$(DPDK_LIBS)'
> +  endif
> +endif
> +
>  ifeq ($(BR2_PACKAGE_DPDK_TESTS),y)
>  DPDK_CONF_OPTS += -Dtests=true
>  else
> --
> 2.43.0

Could you send an updated patch to address those issues,
please?

Best regards,

Julien.

[1] 
https://lore.kernel.org/buildroot/019c90d7929f98d2f7da75410b941388@free.fr/T/#u
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot