From: Joshua Henderson <joshua.henderson@microchip.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] qt5: remove Qt Quick dependency on opengl
Date: Thu, 2 Nov 2017 16:06:12 -0700 [thread overview]
Message-ID: <bd5262d5-19d7-fdcd-dd0d-5fd6b00bffaa@microchip.com> (raw)
In-Reply-To: <20171102230302.26744909@windsurf>
Thomas,
On 11/02/2017 03:03 PM, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 2 Nov 2017 14:41:16 -0700, Joshua Henderson wrote:
>
>> diff --git a/package/qt5/qt5declarative/5.9.2/0001-Fix-no-opengl-builds.patch b/package/qt5/qt5declarative/5.9.2/0001-Fix-no-opengl-builds.patch
>> new file mode 100644
>> index 0000000..aca93be
>> --- /dev/null
>> +++ b/package/qt5/qt5declarative/5.9.2/0001-Fix-no-opengl-builds.patch
>> @@ -0,0 +1,29 @@
>> +From fa52bb665d6beb77a951c14c8edcba3541850afc Mon Sep 17 00:00:00 2001
>> +From: Allan Sandfeld Jensen <allan.jensen@qt.io>
>> +Date: Mon, 25 Sep 2017 16:53:24 +0200
>> +Subject: [PATCH] Fix no-opengl builds
>> +
>> +The qquickwidgets examples uses OpenGL directly
>> +
>> +Change-Id: I1cc8cfbcf249abc98473287a9d499032232828c7
>> +Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
>
> Who did the backport of this patch in Buildroot? It should carry the
> Signed-off-by from the person who did this backport. I don't know if
> it's you or S?bastien Szymanski.
I am the one guilty. Sigh.
>
> Also, another question: I assume that if OpenGL is available, Qt Quick
> will use it. How does it detect that OpenGL is available?
>
qt5declarative depends on qt5base. If mesa3d is configured, qt5base depends
on mesa3d and is told to build with opengl. Then, we leave buildroot. qt5base
build will try to find various incarnations of opengl through its own build
tests. qt5base and qt5declarative use the result of those config tests
through qtConfig() to see if opengl is available. If you build qt5base you
can see config.log and the actual tests under config.tests/ in the build_dir.
Now, you can still build QT with opengl support, and still opt to not use it
and instead use the software renderer at runtime with the environment variable
QMLSCENE_DEVICE=softwarecontext. This patch is all about not making opengl a
requirement, where it is not.
Josh
next prev parent reply other threads:[~2017-11-02 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 21:41 [Buildroot] [PATCH v4] qt5: remove Qt Quick dependency on opengl Joshua Henderson
2017-11-02 22:03 ` Thomas Petazzoni
2017-11-02 23:06 ` Joshua Henderson [this message]
2017-11-03 8:03 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd5262d5-19d7-fdcd-dd0d-5fd6b00bffaa@microchip.com \
--to=joshua.henderson@microchip.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox