Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/lmv2: add missing host-pkgconf dependency
Date: Sun, 24 Sep 2017 17:23:11 +0200	[thread overview]
Message-ID: <bfe5b9bb-1086-551c-a8db-d01806c2eefe@gmail.com> (raw)
In-Reply-To: <e15c1f03-3cc0-2475-c141-f2361c72cde5@mind.be>

Hi Arnout,

Le 24/09/2017 ? 15:01, Arnout Vandecappelle a ?crit?:
> 
> 
> On 13-09-17 22:30, Arnout Vandecappelle wrote:
>>
>>
>> On 13-09-17 22:17, Romain Naour wrote:
>>> configure.ac use PKG_CHECK_MODULES macro to find some libraries dependencies.
>>> So add host-pkgconf in LVM2_DEPENDENCIES.
>>>
>>> Fixes:
>>> checking pkg-config is at least version 0.9.0... ./configure: line 9875: [...]/host/bin/pkg-config: No such file or directory
>>
>>  Any idea why the autobuilders didn't hit this failure?
> 
>  Even though you didn't answer :-) I applied to master after all, since
> configure clearly really wants pkg-config. Thanks!

Sorry, I missed your reply :(

The autobuilders didn't hit this issue because when pkg-config is missing the
build doesn't stop.
I noticed it by chance while looking at a build log file.

Best regards,
Romain

> 
>  Regards,
>  Arnout
> 
>>>
>>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>>> ---
>>>  package/lvm2/lvm2.mk | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
>>> index 63ac109..f7f7069 100644
>>> --- a/package/lvm2/lvm2.mk
>>> +++ b/package/lvm2/lvm2.mk
>>> @@ -21,6 +21,8 @@ LVM2_CONF_OPTS += \
>>>  	--enable-dmeventd \
>>>  	--disable-nls
>>>  
>>> +LVM2_DEPENDENCIES += host-pkgconf
>>> +
>>>  # LVM2 uses autoconf, but not automake, and the build system does not
>>>  # take into account the toolchain passed at configure time.
>>>  LVM2_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
>>>
>>
> 

      reply	other threads:[~2017-09-24 15:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 20:17 [Buildroot] [PATCH] package/lmv2: add missing host-pkgconf dependency Romain Naour
2017-09-13 20:30 ` Arnout Vandecappelle
2017-09-24 13:01   ` Arnout Vandecappelle
2017-09-24 15:23     ` Romain Naour [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfe5b9bb-1086-551c-a8db-d01806c2eefe@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox