[Buildroot] [Bug 15541] New: support/downloads/git generates deceptive archive of Linux repo

[bugzilla@busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=15541

            Bug ID: 15541
           Summary: support/downloads/git generates deceptive archive of
                    Linux repo
           Product: buildroot
           Version: 2020.02
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: unassigned@buildroot.uclibc.org
          Reporter: lgadallah@impinj.com
                CC: buildroot@uclibc.org
  Target Milestone: ---

Given:
- Select a local commit ID/tag for the Linux kernel that does not exist in the
local Linux kernel repo by setting BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION in the
defconfig file
- Run a build

Expected behavior:
- Build should fail when expected commit ID/tag of the Linux kernel repo cannot
be checked out

Observed behavior:
- Build does not fail when expected commit ID/tag of the Linux kernel repo
cannot be checked out
- Build creates archive of Linux kernel repo in linux/linux-<commit
ID>-br1.tar.gz
- Adding some instrumentation to the support/downloads/git script shows that
the actual commit ID in the linux/linux-<commit ID>-br1.tar.gz file is the HEAD
of the local Linux repo, not the (non-existent) commit ID requested
- Build proceeds and succeeds with the linux/linux-<commit ID>-br1.tar.gz file,
with only a warning like this showing in the build log:

2023-03-15T11:45:24.9572834Z [7m>>> linux
0af534041cba4c33e540f6b31b73ce78f8326757 Downloading[27m
2023-03-15T11:45:25.0699794Z Reinitialized existing Git repository in
/mnt/home/dl/linux/git/.git/
2023-03-15T11:45:25.1164499Z Fetching all references
2023-03-15T11:45:26.0788251Z Warning: Permanently added
'github.com,192.30.255.112' (ECDSA) to the list of known hosts.
2023-03-15T11:45:26.0788565Z 
2023-03-15T11:46:06.2456837Z warning: refname
'0af534041cba4c33e540f6b31b73ce78f8326757' is ambiguous.
2023-03-15T11:46:06.2457533Z Git normally never creates a ref that ends with 40
hex characters
2023-03-15T11:46:06.2458253Z because it will be ignored when you just specify
40-hex. These refs
2023-03-15T11:46:06.2458834Z may be created by mistake. For example,
2023-03-15T11:46:06.2459109Z 
2023-03-15T11:46:06.2459403Z   git switch -c $br $(git rev-parse ...)
2023-03-15T11:46:06.2459683Z 
2023-03-15T11:46:06.2460022Z where "$br" is somehow empty and a 40-hex ref is
created. Please
2023-03-15T11:46:06.2461804Z examine these refs and maybe delete them. Turn
this message off by
2023-03-15T11:46:06.2462318Z running "git config advice.objectNameWarning
false"
2023-03-15T11:47:54.3146989Z [7m>>> linux
0af534041cba4c33e540f6b31b73ce78f8326757 Extracting[27m

2023-03-15T11:47:54.3157663Z gzip -d -c
/mnt/home/dl/linux/linux-0af534041cba4c33e540f6b31b73ce78f8326757-br1.tar.gz |
tar --strip-components=1 -C
/mnt/work/output/r515_octane/build/linux-0af534041cba4c33e540f6b31b73ce78f8326757
  -xf -

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot