Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla@busybox.net
To: buildroot@uclibc.org
Subject: [Buildroot] [Bug 16111] New: QuickJS binaries in `/usr/local/bin` (instead of `/usr/bin`)
Date: Mon, 17 Jun 2024 14:52:27 +0000	[thread overview]
Message-ID: <bug-16111-163@https.bugs.busybox.net/> (raw)

https://bugs.busybox.net/show_bug.cgi?id=16111

            Bug ID: 16111
           Summary: QuickJS binaries in `/usr/local/bin` (instead of
                    `/usr/bin`)
           Product: buildroot
           Version: 2024.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: unassigned@buildroot.uclibc.org
          Reporter: ciprian.craciun@gmail.com
                CC: buildroot@uclibc.org
  Target Milestone: ---

After BuildRoot has updated QuickJS to version 2024-01-13, now QuickJS installs
it's binaries under `/usr/local/bin` as opposed to `/usr/bin` (as it was before
the update of QuickJS release).

Apparently the BuildRoot `quickjs.mk` script uses `prefix=/usr`, but the latest
QuickJS makefile seems to expect `PREFIX=/usr`.

The following minor patch solves the issue:
~~~~
diff --git i/package/quickjs/quickjs.mk w/package/quickjs/quickjs.mk
--- i/package/quickjs/quickjs.mk
+++ w/package/quickjs/quickjs.mk
@@ -22,25 +22,25 @@ define QUICKJS_BUILD_CMDS
        EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
        all
 endef

 define QUICKJS_INSTALL_STAGING_CMDS
    $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
        CROSS_PREFIX="$(TARGET_CROSS)" \
        EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
        DESTDIR=$(STAGING_DIR) \
        STRIP=/bin/true \
-       prefix=/usr \
+       PREFIX=/usr \
        install
 endef

 define QUICKJS_INSTALL_TARGET_CMDS
    $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
        CROSS_PREFIX="$(TARGET_CROSS)" \
        EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
        DESTDIR=$(TARGET_DIR) \
        STRIP=/bin/true \
-       prefix=/usr \
+       PREFIX=/usr \
        install
 endef

 $(eval $(generic-package))
~~~~

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2024-06-17 14:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17 14:52 bugzilla [this message]
2024-06-17 15:09 ` [Buildroot] [Bug 16111] QuickJS binaries in `/usr/local/bin` (instead of `/usr/bin`) bugzilla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-16111-163@https.bugs.busybox.net/ \
    --to=bugzilla@busybox.net \
    --cc=buildroot@uclibc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox