public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Javad Rahimipetroudi <javad.rahimipetroudi@essensium.com>
Cc: buildroot@buildroot.org,
	Javad Rahimipetroudi <javad.rahimipetroudi@mind.be>,
	Javad Rahimi <javad321javad@gmail.com>
Subject: Re: [Buildroot] [PATCH] boot/uboot: bump version to 2026.04
Date: Sun, 12 Apr 2026 13:41:09 +0200	[thread overview]
Message-ID: <c30f4b7de05e6a1acbda5ff73fd997aa@free.fr> (raw)
In-Reply-To: <20260412081915.1335127-1-javad.rahimipetroudi@mind.be>

Hi Javad,

Thanks for the patch. I have few comments.

Since you are updating uboot only of a defconfig, the commit title 
should
rather be:

configs/orangepi_pc2: bump uboot to 2026.04

On 12/04/2026 10:19, Javad Rahimipetroudi via buildroot wrote:
> This patch fix the autobuild error for OrangePi PC2:
> Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/13858950361
> 
> Signed-off-by: Javad Rahimipetroudi <javad.rahimipetroudi@mind.be>
> ---
>  configs/orangepi_pc2_defconfig | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/configs/orangepi_pc2_defconfig 
> b/configs/orangepi_pc2_defconfig
> index 46d04b34c8..115fcc93fe 100644
> --- a/configs/orangepi_pc2_defconfig
> +++ b/configs/orangepi_pc2_defconfig
> @@ -23,9 +23,6 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.9"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50i_a64"
>  BR2_TARGET_UBOOT=y
> -BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> -BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2023.04"

If you remove those config lines, this defconfig will use the "latest"
default version set in "boot/uboot", which will changed in the future.
In Buildroot, we prefer having defconfigs using a fixed version (to make
sure it is more stable to what defconfigs maintainers are testing). So 
you
should instead only change the custom uboot version:

BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2026.04"

>  BR2_TARGET_UBOOT_BOARD_DEFCONFIG="orangepi_pc2"
>  BR2_TARGET_UBOOT_NEEDS_DTC=y
>  BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> --
> 2.53.0

Could you send an updated patch please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-04-12 11:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-12  8:19 [Buildroot] [PATCH] boot/uboot: bump version to 2026.04 Javad Rahimipetroudi via buildroot
2026-04-12 11:41 ` Julien Olivain via buildroot [this message]
2026-04-12 12:16 ` [Buildroot] [PATCH] configs/orangepi_pc2: bump uboot " Javad Rahimipetroudi via buildroot
2026-04-12 14:43   ` Julien Olivain via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c30f4b7de05e6a1acbda5ff73fd997aa@free.fr \
    --to=buildroot@buildroot.org \
    --cc=javad.rahimipetroudi@essensium.com \
    --cc=javad.rahimipetroudi@mind.be \
    --cc=javad321javad@gmail.com \
    --cc=ju.o@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox