From: Michael Walle <michael@walle.cc>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: "Jagan Teki" <jagan@amarulasolutions.com>,
"Michał Łyszczek" <michal.lyszczek@bofc.pl>,
buildroot@buildroot.org, "Luca Ceresoli" <luca@lucaceresoli.net>,
"Heiko Thiery" <heiko.thiery@gmail.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH 7/7] board/kontron/smarc-sal28/genimage.cfg: fix option suffix
Date: Tue, 09 Nov 2021 09:50:14 +0100 [thread overview]
Message-ID: <c474197dec6f55dbf2c286c20feeed61@walle.cc> (raw)
In-Reply-To: <B4721363-6522-40D2-AA25-B015E2BD5C43@benettiengineering.com>
Am 2021-11-09 09:38, schrieb Giulio Benetti:
> Hi Michael, All,
>
>> Il giorno 9 nov 2021, alle ore 09:05, Michael Walle
>> <michael@walle.cc> ha scritto:
>
>> Am 2021-11-09 00:05, schrieb Giulio Benetti:
>>
>>> Option 'offset = 4k' must be 'option = 4K'.
>>
>> Why is this is a 'must'? Apparently it works, no?
>
> This is a standard I’ve proposed and it’s been accepted by
> committing all the 102 patches.
> There is not an existing standard and I’ve created one, that’s
> all.
>
>> So if anything
>> it is for unifying; but even then it's moving in the wrong
>> direction. There is no "K" prefix in si units. Stictly speaking
>> there is no "KB"; there is a "kB" or a "KiB".
>
> Here we had 2 choices using genimage “K” or “k”. I went for
> “K” since the most of the files had “K”.
> And anyway both “K” and “k” are not that good, but it’s not
> our fault, it depends on genimage input format.
>
> Yann already explained the differences between notations here:
> https://lists.buildroot.org/pipermail/buildroot/2021-November/627885.html
>
> You can follow-up the thread and the motivations on such thing.
Thanks for the pointer, but I won't make a fuzz. I'm fine with
the change.
-michael
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-09 8:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 23:05 [Buildroot] [PATCH 0/7] Post genimage.cfg beautify Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 1/7] board/olimex/a20_olinuxino/genimage.cfg: fix build failure due to wrong offset value suffix Giulio Benetti
2021-11-09 9:01 ` Luca Ceresoli
2021-11-09 9:16 ` Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 2/7] board/altera/socrates_cyclone5/genimage.cfg: fix offset suffix Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 3/7] board/friendlyarm/nanopi-neo2/genimage.cfg: fix comment Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 4/7] board/orangepi/orangepi-pc2/genimage.cfg: " Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 5/7] board/minnowboard/genimage.cfg: fix option assignment spaces Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 6/7] board/kontron/pitx-imx8m/genimage.cfg: fix option suffix Giulio Benetti
2021-11-09 7:37 ` Heiko Thiery
2021-11-09 7:49 ` Giulio Benetti
2021-11-08 23:05 ` [Buildroot] [PATCH 7/7] board/kontron/smarc-sal28/genimage.cfg: " Giulio Benetti
2021-11-09 8:04 ` Michael Walle
2021-11-09 8:26 ` Edgar Bonet
2021-11-09 8:49 ` Giulio Benetti
2021-11-09 8:38 ` Giulio Benetti
2021-11-09 8:50 ` Michael Walle [this message]
2021-11-09 8:50 ` Yann E. MORIN
2021-11-09 9:23 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c474197dec6f55dbf2c286c20feeed61@walle.cc \
--to=michael@walle.cc \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=heiko.thiery@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=luca@lucaceresoli.net \
--cc=michal.lyszczek@bofc.pl \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox