Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Ziegler <br025@umbiko.net>
To: Fiona Klute <fiona.klute@gmx.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 0/4] fix shellcheck 0.10 & 0.11 warnings
Date: Sun, 07 Jun 2026 06:26:23 +0000	[thread overview]
Message-ID: <cbb32ba62892442e1cbbf79c0559393f@umbiko.net> (raw)
In-Reply-To: <20260606182032.3803327-1-fiona.klute@gmx.de>

Hi Fiona, Everyone,

On 2026-06-06 18:20, Fiona Klute wrote:
> Hi everyone,
> 
> this series fixes shellcheck warnings that appear with shellcheck 0.10
> (as present in Debian Trixie) and 0.11 (Sid) to prepare for updating
> the CI container image to Trixie. With the current image "make
> check-package" still passes with the patches applied, so they can be
> applied at any point before updating the container image.
> 
> Most changes are pretty trivial (the mdnsd init script a little less),
> but only OpenRC has runtime tests, so tests from people actually using
> the packages would be appreciated.

The changes to the mpd init script (1, 2) work as intended:
Tested-by: Andreas Ziegler <br025@umbiko.net>

> Best regards,
> Fiona
> 
> Fiona Klute (4):
>   package/mpd/S95mpd: avoid unnecessary exit
>   package/mpd/S95mpd: do not wait for exit if sending stop failed
>   package/mdnsd/S50mdnsd: rewrite to match current guidelines
>   package/openrc/sysv-rcs: fix shellcheck 0.10 warnings

<...>

Kind regards,
Andreas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2026-06-07  6:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-06 18:20 [Buildroot] [PATCH 0/4] fix shellcheck 0.10 & 0.11 warnings Fiona Klute via buildroot
2026-06-06 18:20 ` [Buildroot] [PATCH 1/4] package/mpd/S95mpd: avoid unnecessary exit Fiona Klute via buildroot
2026-06-06 18:20 ` [Buildroot] [PATCH 2/4] package/mpd/S95mpd: do not wait for exit if sending stop failed Fiona Klute via buildroot
2026-06-06 18:20 ` [Buildroot] [PATCH 3/4] package/mdnsd/S50mdnsd: rewrite to match current guidelines Fiona Klute via buildroot
2026-06-06 18:20 ` [Buildroot] [PATCH 4/4] package/openrc/sysv-rcs: fix shellcheck 0.10 warnings Fiona Klute via buildroot
2026-06-07  6:26 ` Andreas Ziegler [this message]
2026-06-17 12:28 ` [Buildroot] [PATCH 0/4] fix shellcheck 0.10 & 0.11 warnings Marcus Hoffmann via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbb32ba62892442e1cbbf79c0559393f@umbiko.net \
    --to=br025@umbiko.net \
    --cc=buildroot@buildroot.org \
    --cc=fiona.klute@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox