From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernd Kuhls Date: Mon, 28 Mar 2016 16:40:44 +0200 Subject: [Buildroot] [PATCH v2 06/18] package/opencv3: bump version to 3.1.0 References: <1459070223-5901-1-git-send-email-bernd.kuhls@t-online.de> <1459070223-5901-7-git-send-email-bernd.kuhls@t-online.de> <69clscxmj.ln2@ID-313208.user.individual.net> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Am Sun, 27 Mar 2016 19:01:12 +0200 schrieb Samuel Martin: > On Sun, Mar 27, 2016 at 5:53 PM, Bernd Kuhls > wrote: >> Hi Samuel, >> >> Am Sun, 27 Mar 2016 15:05:42 +0200 schrieb Samuel Martin: >> >>>> - -DWITH_OPENGL=OFF \ >>>> - -DWITH_OPENMP=OFF \ >>> AFAICS, these 2 options still exist (see [2,3]). >> >> Yes, and they are used later on in opencv3.mk: >> >> ifeq ($(BR2_PACKAGE_OPENCV3_WITH_OPENGL),y) >> OPENCV3_CONF_OPTS += -DWITH_OPENGL=ON OPENCV3_DEPENDENCIES += libgl >> else OPENCV3_CONF_OPTS += -DWITH_OPENGL=OFF endif >> >> OPENCV3_CONF_OPTS += -DWITH_OPENMP=$(if >> $(BR2_GCC_ENABLE_OPENMP),ON,OFF) >> >> Is there a reason why they are disabled in the first place? > Yes, there is reason ;-) > > Opencv3 has been done correctly when upgrading from opencv2 [1] (as a > replacement), then opencv has been renamed opencv3 [2] and opencv > reverted back [3]... hence the desync. between these 2 packages... > And since this, I have not taken the time to sync. opencv and opencv3 > packages... :-/ Hi Samuel, even after your last explanation I do not understand why -DWITH_OPENGL and -DWITH_OPENMP are present twice in opencv3.mk so I am going to repeat my question based on current buildroot git master: In line 207 opengl support is disabled: https://git.busybox.net/buildroot/tree/package/opencv3/opencv3.mk#n207 > -DWITH_OPENGL=OFF \ In line 271 this command is repeated https://git.busybox.net/buildroot/tree/package/opencv3/opencv3.mk#n271 >OPENCV3_CONF_OPTS += -DWITH_OPENGL=OFF