From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugs at busybox.net Date: Sat, 20 Oct 2007 21:27:42 -0700 Subject: [Buildroot] [buildroot 0001545]: lsof package configures using host instead of target includes Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net The following issue has been SUBMITTED. ====================================================================== http://busybox.net/bugs/view.php?id=1545 ====================================================================== Reported By: marcg Assigned To: buildroot ====================================================================== Project: buildroot Issue ID: 1545 Category: Other Reproducibility: always Severity: minor Priority: normal Status: assigned ====================================================================== Date Submitted: 10-20-2007 21:27 PDT Last Modified: 10-20-2007 21:27 PDT ====================================================================== Summary: lsof package configures using host instead of target includes Description: The lsof package uses its own Configure system, which requires LSOF_INCLUDE to point to the target's include directory. Without this it defaults to looking at /usr/include to decide on configuration parameters. Encountered this where the target didn't have selinux/selinux.h in its headers, yet lsof's Configure enabled selinux anyway when it found /usr/include/selinux/selinux.h on the host. Here's a generic patch that fixes this. Index: package/lsof/lsof.mk =================================================================== --- package/lsof/lsof.mk (revision 8) +++ package/lsof/lsof.mk (working copy) @@ -10,6 +10,7 @@ LSOF_DIR:=$(BUILD_DIR)/lsof_$(LSOF_VERSION) LSOF_BINARY:=lsof LSOF_TARGET_BINARY:=bin/lsof +LSOF_INCLUDE:=$(STAGING_DIR)/usr/include BR2_LSOF_CFLAGS:= ifeq ($(BR2_LARGEFILE),) @@ -33,7 +34,7 @@ touch $(LSOF_DIR)/.unpacked $(LSOF_DIR)/.configured: $(LSOF_DIR)/.unpacked - (cd $(LSOF_DIR)/lsof_$(LSOF_VERSION)_src; echo n | $(TARGET_CONFIGURE_OPTS) DEBUG="$(TARGET_CFLAGS) $(BR2_LSOF_CFLAGS)" ./Configure linux) + (cd $(LSOF_DIR)/lsof_$(LSOF_VERSION)_src; echo n | $(TARGET_CONFIGURE_OPTS) DEBUG="$(TARGET_CFLAGS) $(BR2_LSOF_CFLAGS)" LSOF_INCLUDE="$(LSOF_INCLUDE)" ./Configure linux) touch $(LSOF_DIR)/.configured $(LSOF_DIR)/lsof_$(LSOF_VERSION)_src/$(LSOF_BINARY): $(LSOF_DIR)/.configured ====================================================================== Issue History Date Modified Username Field Change ====================================================================== 10-20-07 21:27 marcg New Issue 10-20-07 21:27 marcg Status new => assigned 10-20-07 21:27 marcg Assigned To => buildroot ======================================================================