From: Joris Offouga <offougajoris@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] boards/freescale/common: Introduce template_no_boot_part
Date: Mon, 10 Jun 2019 21:12:47 +0200 [thread overview]
Message-ID: <ced8f263-e3ab-4d1e-3f8b-ae4ca85665bc@gmail.com> (raw)
In-Reply-To: <ad33ba2d-ea04-9fce-6bd0-7112bdce7ca5@mind.be>
Le 10/06/2019 ? 21:00, Arnout Vandecappelle a ?crit?:
>
> On 10/06/2019 20:43, Joris Offouga wrote:
>> Hi Arnoud,
>>
>> Le 10/06/2019 ? 00:17, Arnout Vandecappelle a ?crit?:
>>> On 09/06/2019 16:57, Joris Offouga wrote:
> [snip]
>>>> diff --git a/board/freescale/common/imx/genimage.cfg.template_no_boot_part b/board/freescale/common/imx/genimage.cfg.template_no_boot_part
>>>> new file mode 100644
>>>> index 0000000000..9e19b4ee3e
>>>> --- /dev/null
>>>> +++ b/board/freescale/common/imx/genimage.cfg.template_no_boot_part
>>>> @@ -0,0 +1,23 @@
>>>> +# Minimal SD card image for the Freescale boards Template
>>>> +#
>>>> +# We mimic the .sdcard Freescale's image format:
>>>> +# * the SD card must have 1 kB free space at the beginning,
>>> Is this one going to be used by anything in practice? I expect that anything
>>> that uses this kind of layout is *not* going to use the .imx format, since
>>> that's considered kind of deprecated...
>> It depends on the targets, imx7dpico has migrated to the SPL and so its u-boot
>> has gone from .imx to .img,
>>
>> Example of the warp7 on 2019.01 it's still .imx.
> OK, let me rephrase it then: does U-Boot 2019.01 have any configuration without
> boot FAT partition, but which uses the .imx format instead of SPL?
>
> In any case, I think this enimage.cfg.template_no_boot_part should only be
> introduced when there is something that actually uses it. Now it is just dead code.
I see you are right if a target will need it it will introduce the
variable I drop this file,
thanks for review
Best regards,
Joris
>
> Regards,
> Arnout
>
> [snip]
>
next prev parent reply other threads:[~2019-06-10 19:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 14:57 [Buildroot] [PATCH 1/3] configs/imx7dpico: Bump Linux and U-Boot Joris Offouga
2019-06-09 14:57 ` [Buildroot] [PATCH 2/3] boards/freescale/common: Introduce template_no_boot_part Joris Offouga
2019-06-09 22:17 ` Arnout Vandecappelle
2019-06-10 18:43 ` Joris Offouga
2019-06-10 18:43 ` Joris Offouga
2019-06-10 19:00 ` Arnout Vandecappelle
2019-06-10 19:12 ` Joris Offouga [this message]
2019-06-09 14:57 ` [Buildroot] [PATCH 3/3] configs/imx7dpico: Add Wifi support Joris Offouga
2019-06-09 22:27 ` Arnout Vandecappelle
2019-06-09 16:44 ` [Buildroot] [PATCH 1/3] configs/imx7dpico: Bump Linux and U-Boot Pierre-Jean Texier
2019-06-09 22:08 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ced8f263-e3ab-4d1e-3f8b-ae4ca85665bc@gmail.com \
--to=offougajoris@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox