public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/freeradius-server: remove redundant pcre dependency
@ 2026-04-05  7:30 Bernd Kuhls
  2026-04-06  8:36 ` Julien Olivain via buildroot
  2026-04-14 15:46 ` Thomas Perale via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2026-04-05  7:30 UTC (permalink / raw)
  To: buildroot; +Cc: David GOUARIN

Buildroot commit 736c4c1655d93652a9a7e79235bbe726b3d46176 added the
package with two identical code blocks dealing with the dependency to
pcre:

https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/freeradius-server/freeradius-server.mk#L161
https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/freeradius-server/freeradius-server.mk#L218

Remove one of these code blocks.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/freeradius-server/freeradius-server.mk | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/package/freeradius-server/freeradius-server.mk b/package/freeradius-server/freeradius-server.mk
index 946750f1a5..9b5b3d13ea 100644
--- a/package/freeradius-server/freeradius-server.mk
+++ b/package/freeradius-server/freeradius-server.mk
@@ -215,13 +215,6 @@ FREERADIUS_SERVER_CONF_OPTS += \
 	--without-rlm_eap_pwd
 endif
 
-ifeq ($(BR2_PACKAGE_PCRE),y)
-FREERADIUS_SERVER_CONF_OPTS += --with-pcre
-FREERADIUS_SERVER_DEPENDENCIES += pcre
-else
-FREERADIUS_SERVER_CONF_OPTS += --without-pcre
-endif
-
 ifeq ($(BR2_PACKAGE_RUBY),y)
 FREERADIUS_SERVER_CONF_OPTS += --with-rlm_ruby
 FREERADIUS_SERVER_DEPENDENCIES += ruby
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/freeradius-server: remove redundant pcre dependency
  2026-04-05  7:30 [Buildroot] [PATCH 1/1] package/freeradius-server: remove redundant pcre dependency Bernd Kuhls
@ 2026-04-06  8:36 ` Julien Olivain via buildroot
  2026-04-14 15:46 ` Thomas Perale via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Julien Olivain via buildroot @ 2026-04-06  8:36 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot, David GOUARIN

On 05/04/2026 09:30, Bernd Kuhls wrote:
> Buildroot commit 736c4c1655d93652a9a7e79235bbe726b3d46176 added the
> package with two identical code blocks dealing with the dependency to
> pcre:
> 
> https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/freeradius-server/freeradius-server.mk#L161
> https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/freeradius-server/freeradius-server.mk#L218
> 
> Remove one of these code blocks.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/freeradius-server: remove redundant pcre dependency
  2026-04-05  7:30 [Buildroot] [PATCH 1/1] package/freeradius-server: remove redundant pcre dependency Bernd Kuhls
  2026-04-06  8:36 ` Julien Olivain via buildroot
@ 2026-04-14 15:46 ` Thomas Perale via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Perale via buildroot @ 2026-04-14 15:46 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: Thomas Perale, buildroot

In reply of:
> Buildroot commit 736c4c1655d93652a9a7e79235bbe726b3d46176 added the
> package with two identical code blocks dealing with the dependency to
> pcre:
> 
> https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/freeradius-server/freeradius-server.mk#L161
> https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/freeradius-server/freeradius-server.mk#L218
> 
> Remove one of these code blocks.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to 2025.02.x & 2026.02.x. Thanks

> ---
>  package/freeradius-server/freeradius-server.mk | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/package/freeradius-server/freeradius-server.mk b/package/freeradius-server/freeradius-server.mk
> index 946750f1a5..9b5b3d13ea 100644
> --- a/package/freeradius-server/freeradius-server.mk
> +++ b/package/freeradius-server/freeradius-server.mk
> @@ -215,13 +215,6 @@ FREERADIUS_SERVER_CONF_OPTS += \
>  	--without-rlm_eap_pwd
>  endif
>  
> -ifeq ($(BR2_PACKAGE_PCRE),y)
> -FREERADIUS_SERVER_CONF_OPTS += --with-pcre
> -FREERADIUS_SERVER_DEPENDENCIES += pcre
> -else
> -FREERADIUS_SERVER_CONF_OPTS += --without-pcre
> -endif
> -
>  ifeq ($(BR2_PACKAGE_RUBY),y)
>  FREERADIUS_SERVER_CONF_OPTS += --with-rlm_ruby
>  FREERADIUS_SERVER_DEPENDENCIES += ruby
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-14 15:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-05  7:30 [Buildroot] [PATCH 1/1] package/freeradius-server: remove redundant pcre dependency Bernd Kuhls
2026-04-06  8:36 ` Julien Olivain via buildroot
2026-04-14 15:46 ` Thomas Perale via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox