* [Buildroot] [PATCH] package/icu: fix static linking with icu-uc for musl static toolchains @ 2026-03-03 16:28 Shubham Chakraborty 2026-03-03 18:21 ` [Buildroot] [PATCH v2] " Shubham Chakraborty 0 siblings, 1 reply; 10+ messages in thread From: Shubham Chakraborty @ 2026-03-03 16:28 UTC (permalink / raw) To: buildroot Cc: Thomas Petazzoni, Maxime Hadjinlian, Romain Naour, Shubham Chakraborty During static linking with a C application and libicuuc.a, -lstdc++ is required. The previous patch (0003) only addressed the shared library case (Libs.private). This patch adds -lstdc++ to the main Libs line for the static case to fix undefined reference errors when linking programs like xmlcatalog (libxml2) with musl static toolchains. Upstream: Inactive-Upstream [Buildroot specific] Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> --- ...atic-linking-with-icu-uc-static-musl.patch | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch diff --git a/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch b/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch new file mode 100644 index 0000000000..40d3aa21a2 --- /dev/null +++ b/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch @@ -0,0 +1,30 @@ +From 2107f9dfb39eeb6559fb4271c7af8b39aef521ca Mon Sep 17 00:00:00 2001 +From: Shubham Chakraborty <chakrabortyshubham66@gmail.com> +Date: Tue, 3 Mar 2026 10:00:00 +0000 +Subject: [PATCH] fix static linking with icu-uc (static case) + +During static linking with a C application and libicuuc.a, +-lstdc++ is required. The previous patch (0003) only addressed the +shared library case (Libs.private). This patch adds -lstdc++ to the +main Libs line for the static case to fix undefined reference +errors when linking programs like xmlcatalog (libxml2) with +musl toolchains. + +Upstream: Inactive-Upstream [Buildroot specific] +Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> +--- + source/Makefile.in | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff -git icu.orig/source/Makefile.in icu/source/Makefile.in +--- icu.orig/source/Makefile.in ++++ icu/source/Makefile.in +@@ -278,7 +278,7 @@ config/icu-uc.pc: config/icu.pc Makefile icudefs.mk + @echo "Description: $(PACKAGE_ICU_DESCRIPTION): Common and Data libraries" >> $@ + @echo "Name: $(PACKAGE)-uc" >> $@ + ifeq ($(ENABLE_SHARED),) +- @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' >> $@ ++ @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' -lstdc++ >> $@ + else + @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" >> $@ + @echo "Libs.private:" "${ICULIBS_DT}" '$${baselibs}' -lstdc++ >> $@ -- 2.53.0 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2] package/icu: fix static linking with icu-uc for musl static toolchains 2026-03-03 16:28 [Buildroot] [PATCH] package/icu: fix static linking with icu-uc for musl static toolchains Shubham Chakraborty @ 2026-03-03 18:21 ` Shubham Chakraborty 2026-03-26 11:36 ` [Buildroot] [PATCH v3] package/icu: fix static linking with icu-uc Shubham Chakraborty 0 siblings, 1 reply; 10+ messages in thread From: Shubham Chakraborty @ 2026-03-03 18:21 UTC (permalink / raw) To: buildroot; +Cc: Thomas Petazzoni, Shubham Chakraborty During static linking with a C application and libicuuc.a, -lstdc++ is required. The previous patch (0003) only addressed the shared library case (Libs.private). This patch adds -lstdc++ to the main Libs line for the static case to fix undefined reference errors when linking programs like xmlcatalog (libxml2) with musl static toolchains. Upstream: Inactive-Upstream [Buildroot specific] Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> --- Changes v1 -> v2: - Fixed the malformed patch - Removed unnecessary whitespace Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> --- ...atic-linking-with-icu-uc-static-musl.patch | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch diff --git a/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch b/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch new file mode 100644 index 0000000000..e17f6ac775 --- /dev/null +++ b/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch @@ -0,0 +1,26 @@ +From 2107f9dfb39eeb6559fb4271c7af8b39aef521ca Mon Sep 17 00:00:00 2001 +From: Shubham Chakraborty <chakrabortyshubham66@gmail.com> +Date: Tue, 3 Mar 2026 10:00:00 +0000 +Subject: [PATCH] fix static linking with icu-uc (static case) + +During static linking with a C application and libicuuc.a, +-lstdc++ is required. The previous patch (0003) only addressed the +shared library case (Libs.private). This patch adds -lstdc++ to the +main Libs line for the static case to fix undefined reference +errors when linking programs like xmlcatalog (libxml2) with +musl toolchains. + +Upstream: Inactive-Upstream [Buildroot specific] +Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> +--- + source/Makefile.in | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff -git icu.orig/source/Makefile.in icu/source/Makefile.in +--- icu.orig/source/Makefile.in ++++ icu/source/Makefile.in +@@ -281,3 +281,3 @@ + ifeq ($(ENABLE_SHARED),) +- @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' >> $@ ++ @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' -lstdc++ >> $@ + else -- 2.53.0 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v3] package/icu: fix static linking with icu-uc 2026-03-03 18:21 ` [Buildroot] [PATCH v2] " Shubham Chakraborty @ 2026-03-26 11:36 ` Shubham Chakraborty 2026-03-27 4:27 ` Andreas Ziegler 2026-03-27 9:43 ` [Buildroot] [PATCH v4] Extend the existing patch to also add -lstdc++ to the Libs field, fixing static linking issues with libicuuc.a Shubham Chakraborty 0 siblings, 2 replies; 10+ messages in thread From: Shubham Chakraborty @ 2026-03-26 11:36 UTC (permalink / raw) To: buildroot; +Cc: thomas.petazzoni, romain.naour, br025, Shubham Chakraborty Extend the existing patch to also add -lstdc++ to the Libs field, fixing static linking issues with libicuuc.a. This combines the previous 0003 and 0004 changes into a single patch, following review feedback from Andreas. Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> --- Changes v2 -> v3: - Merge previous 0003 and 0004 into a single patch - Extend existing fix to also add -lstdc++ to Libs (static linking case) - Keep original authorship and add my Signed-off-by below Romain's - Update commit message and description based on review feedback --- .../0003-fix-static-linking-with-icu-uc.patch | 29 ++++++++++++------- ...atic-linking-with-icu-uc-static-musl.patch | 26 ----------------- 2 files changed, 19 insertions(+), 36 deletions(-) delete mode 100644 package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch diff --git a/package/icu/0003-fix-static-linking-with-icu-uc.patch b/package/icu/0003-fix-static-linking-with-icu-uc.patch index 36a3d1f696..ec393254e8 100644 --- a/package/icu/0003-fix-static-linking-with-icu-uc.patch +++ b/package/icu/0003-fix-static-linking-with-icu-uc.patch @@ -3,9 +3,6 @@ From: Romain Naour <romain.naour@openwide.fr> Date: Wed, 22 Jul 2015 22:43:25 +0200 Subject: [PATCH] fix static linking with icu-uc -During static linking with a C application and libicuuc.a, --lstdc++ is required. - Add -lstdc++ in Libs.private of icu-uc.pc. Fixes: @@ -13,14 +10,26 @@ http://autobuild.buildroot.net/results/210/2107f9dfb39eeb6559fb4271c7af8b39aef52 Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- - source/Makefile.in | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) +This patch currently addresses linking against stdc++ for shared-library +builds. Add -lstdc++ to the static build flags also, to fix 'undefined +reference' errors when linking programs like xmlcatalog (libxml2) +with musl static toolchains. + +Upstream: Inactive-Upstream [Buildroot specific] +Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> +--- + source/Makefile.in | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) -diff -git icu.orig/source/Makefile.in icu/source/Makefile.in ---- icu.orig/source/Makefile.in 2025-03-13 19:31:23.000000000 +0100 -+++ icu/source/Makefile.in 2025-09-22 08:56:36.791792784 +0200 -@@ -279,7 +279,7 @@ - @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' >> $@ +diff --git icu.orig/source/Makefile.in icu/source/Makefile.in +--- icu.orig/source/Makefile.in ++++ icu/source/Makefile.in +@@ -279,10 +279,10 @@ config/icu-uc.pc: config/icu.pc Makefile icudefs.mk + @echo "Description: $(PACKAGE_ICU_DESCRIPTION): Common and Data libraries" >> $@ + @echo "Name: $(PACKAGE)-uc" >> $@ + ifeq ($(ENABLE_SHARED),) +- @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' >> $@ ++ @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' -lstdc++ >> $@ else @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" >> $@ - @echo "Libs.private:" "${ICULIBS_DT}" '$${baselibs}' >> $@ diff --git a/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch b/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch deleted file mode 100644 index e17f6ac775..0000000000 --- a/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch +++ /dev/null @@ -1,26 +0,0 @@ -From 2107f9dfb39eeb6559fb4271c7af8b39aef521ca Mon Sep 17 00:00:00 2001 -From: Shubham Chakraborty <chakrabortyshubham66@gmail.com> -Date: Tue, 3 Mar 2026 10:00:00 +0000 -Subject: [PATCH] fix static linking with icu-uc (static case) - -During static linking with a C application and libicuuc.a, --lstdc++ is required. The previous patch (0003) only addressed the -shared library case (Libs.private). This patch adds -lstdc++ to the -main Libs line for the static case to fix undefined reference -errors when linking programs like xmlcatalog (libxml2) with -musl toolchains. - -Upstream: Inactive-Upstream [Buildroot specific] -Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> ---- - source/Makefile.in | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff -git icu.orig/source/Makefile.in icu/source/Makefile.in ---- icu.orig/source/Makefile.in -+++ icu/source/Makefile.in -@@ -281,3 +281,3 @@ - ifeq ($(ENABLE_SHARED),) -- @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' >> $@ -+ @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' -lstdc++ >> $@ - else -- 2.53.0 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v3] package/icu: fix static linking with icu-uc 2026-03-26 11:36 ` [Buildroot] [PATCH v3] package/icu: fix static linking with icu-uc Shubham Chakraborty @ 2026-03-27 4:27 ` Andreas Ziegler 2026-03-27 9:50 ` Shubham Chakraborty 2026-03-27 9:43 ` [Buildroot] [PATCH v4] Extend the existing patch to also add -lstdc++ to the Libs field, fixing static linking issues with libicuuc.a Shubham Chakraborty 1 sibling, 1 reply; 10+ messages in thread From: Andreas Ziegler @ 2026-03-27 4:27 UTC (permalink / raw) To: Shubham Chakraborty; +Cc: buildroot, thomas.petazzoni, romain.naour Hi Shubham, On 2026-03-26 11:36, Shubham Chakraborty wrote: > Extend the existing patch to also add -lstdc++ to the Libs > field, fixing static linking issues with libicuuc.a. > > This combines the previous 0003 and 0004 changes into a > single patch, following review feedback from Andreas. > > Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> > --- > Changes v2 -> v3: > - Merge previous 0003 and 0004 into a single patch > - Extend existing fix to also add -lstdc++ to Libs (static linking > case) > - Keep original authorship and add my Signed-off-by below Romain's > - Update commit message and description based on review feedback > --- > .../0003-fix-static-linking-with-icu-uc.patch | 29 ++++++++++++------- > ...atic-linking-with-icu-uc-static-musl.patch | 26 ----------------- > 2 files changed, 19 insertions(+), 36 deletions(-) > delete mode 100644 > package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch > > diff --git a/package/icu/0003-fix-static-linking-with-icu-uc.patch > b/package/icu/0003-fix-static-linking-with-icu-uc.patch > index 36a3d1f696..ec393254e8 100644 > --- a/package/icu/0003-fix-static-linking-with-icu-uc.patch > +++ b/package/icu/0003-fix-static-linking-with-icu-uc.patch > @@ -3,9 +3,6 @@ From: Romain Naour <romain.naour@openwide.fr> > Date: Wed, 22 Jul 2015 22:43:25 +0200 > Subject: [PATCH] fix static linking with icu-uc > > -During static linking with a C application and libicuuc.a, > --lstdc++ is required. > - > Add -lstdc++ in Libs.private of icu-uc.pc. > > Fixes: > @@ -13,14 +10,26 @@ > http://autobuild.buildroot.net/results/210/2107f9dfb39eeb6559fb4271c7af8b39aef52 > > Signed-off-by: Romain Naour <romain.naour@openwide.fr> > --- > - source/Makefile.in | 2 +- > - 1 file changed, 1 insertion(+), 1 deletion(-) > +This patch currently addresses linking against stdc++ for > shared-library > +builds. Add -lstdc++ to the static build flags also, to fix 'undefined > +reference' errors when linking programs like xmlcatalog (libxml2) > +with musl static toolchains. > + > +Upstream: Inactive-Upstream [Buildroot specific] > +Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> > +--- > + source/Makefile.in | 4 ++-- > + 1 file changed, 2 insertions(+), 2 deletions(-) > > -diff -git icu.orig/source/Makefile.in icu/source/Makefile.in > ---- icu.orig/source/Makefile.in 2025-03-13 19:31:23.000000000 +0100 > -+++ icu/source/Makefile.in 2025-09-22 08:56:36.791792784 +0200 > -@@ -279,7 +279,7 @@ > - @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > '$${baselibs}' >> $@ > +diff --git icu.orig/source/Makefile.in icu/source/Makefile.in > +--- icu.orig/source/Makefile.in > ++++ icu/source/Makefile.in > +@@ -279,10 +279,10 @@ config/icu-uc.pc: config/icu.pc Makefile > icudefs.mk > + @echo "Description: $(PACKAGE_ICU_DESCRIPTION): Common and Data > libraries" >> $@ > + @echo "Name: $(PACKAGE)-uc" >> $@ > + ifeq ($(ENABLE_SHARED),) > +- @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > '$${baselibs}' >> $@ > ++ @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > '$${baselibs}' -lstdc++ >> $@ > else > @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" >> $@ > - @echo "Libs.private:" "${ICULIBS_DT}" '$${baselibs}' >> $@ > diff --git > a/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch > b/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch > deleted file mode 100644 > index e17f6ac775..0000000000 > --- a/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch > +++ /dev/null Your patch seems not to be based on the current Buildroot master branch. It cannot be applied, unfortunately. > @@ -1,26 +0,0 @@ > -From 2107f9dfb39eeb6559fb4271c7af8b39aef521ca Mon Sep 17 00:00:00 2001 > -From: Shubham Chakraborty <chakrabortyshubham66@gmail.com> > -Date: Tue, 3 Mar 2026 10:00:00 +0000 > -Subject: [PATCH] fix static linking with icu-uc (static case) > - > -During static linking with a C application and libicuuc.a, > --lstdc++ is required. The previous patch (0003) only addressed the > -shared library case (Libs.private). This patch adds -lstdc++ to the > -main Libs line for the static case to fix undefined reference > -errors when linking programs like xmlcatalog (libxml2) with > -musl toolchains. > - > -Upstream: Inactive-Upstream [Buildroot specific] > -Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> > ---- > - source/Makefile.in | 2 +- > - 1 file changed, 1 insertion(+), 1 deletion(-) > - > -diff -git icu.orig/source/Makefile.in icu/source/Makefile.in > ---- icu.orig/source/Makefile.in > -+++ icu/source/Makefile.in > -@@ -281,3 +281,3 @@ > - ifeq ($(ENABLE_SHARED),) > -- @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > '$${baselibs}' >> $@ > -+ @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > '$${baselibs}' -lstdc++ >> $@ > - else > -- > 2.53.0 Kind regards, Andreas _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v3] package/icu: fix static linking with icu-uc 2026-03-27 4:27 ` Andreas Ziegler @ 2026-03-27 9:50 ` Shubham Chakraborty 0 siblings, 0 replies; 10+ messages in thread From: Shubham Chakraborty @ 2026-03-27 9:50 UTC (permalink / raw) To: Andreas Ziegler; +Cc: buildroot, Thomas Petazzoni, Romain Naour [-- Attachment #1.1: Type: text/plain, Size: 5449 bytes --] Hi Andreas, I have sent a v4 patch which addresses the issue and is based on the current Buildroot master branch. Best regards, Shubham Chakraborty On Fri, 27 Mar, 2026, 9:57 am Andreas Ziegler, <br025@umbiko.net> wrote: > Hi Shubham, > > On 2026-03-26 11:36, Shubham Chakraborty wrote: > > Extend the existing patch to also add -lstdc++ to the Libs > > field, fixing static linking issues with libicuuc.a. > > > > This combines the previous 0003 and 0004 changes into a > > single patch, following review feedback from Andreas. > > > > Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> > > --- > > Changes v2 -> v3: > > - Merge previous 0003 and 0004 into a single patch > > - Extend existing fix to also add -lstdc++ to Libs (static linking > > case) > > - Keep original authorship and add my Signed-off-by below Romain's > > - Update commit message and description based on review feedback > > --- > > .../0003-fix-static-linking-with-icu-uc.patch | 29 ++++++++++++------- > > ...atic-linking-with-icu-uc-static-musl.patch | 26 ----------------- > > 2 files changed, 19 insertions(+), 36 deletions(-) > > delete mode 100644 > > package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch > > > > diff --git a/package/icu/0003-fix-static-linking-with-icu-uc.patch > > b/package/icu/0003-fix-static-linking-with-icu-uc.patch > > index 36a3d1f696..ec393254e8 100644 > > --- a/package/icu/0003-fix-static-linking-with-icu-uc.patch > > +++ b/package/icu/0003-fix-static-linking-with-icu-uc.patch > > @@ -3,9 +3,6 @@ From: Romain Naour <romain.naour@openwide.fr> > > Date: Wed, 22 Jul 2015 22:43:25 +0200 > > Subject: [PATCH] fix static linking with icu-uc > > > > -During static linking with a C application and libicuuc.a, > > --lstdc++ is required. > > - > > Add -lstdc++ in Libs.private of icu-uc.pc. > > > > Fixes: > > @@ -13,14 +10,26 @@ > > > http://autobuild.buildroot.net/results/210/2107f9dfb39eeb6559fb4271c7af8b39aef52 > > > > Signed-off-by: Romain Naour <romain.naour@openwide.fr> > > --- > > - source/Makefile.in | 2 +- > > - 1 file changed, 1 insertion(+), 1 deletion(-) > > +This patch currently addresses linking against stdc++ for > > shared-library > > +builds. Add -lstdc++ to the static build flags also, to fix 'undefined > > +reference' errors when linking programs like xmlcatalog (libxml2) > > +with musl static toolchains. > > + > > +Upstream: Inactive-Upstream [Buildroot specific] > > +Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> > > +--- > > + source/Makefile.in | 4 ++-- > > + 1 file changed, 2 insertions(+), 2 deletions(-) > > > > -diff -git icu.orig/source/Makefile.in icu/source/Makefile.in > > ---- icu.orig/source/Makefile.in 2025-03-13 19:31:23.000000000 +0100 > > -+++ icu/source/Makefile.in 2025-09-22 08:56:36.791792784 +0200 > > -@@ -279,7 +279,7 @@ > > - @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > > '$${baselibs}' >> $@ > > +diff --git icu.orig/source/Makefile.in icu/source/Makefile.in > > +--- icu.orig/source/Makefile.in > > ++++ icu/source/Makefile.in > > +@@ -279,10 +279,10 @@ config/icu-uc.pc: config/icu.pc Makefile > > icudefs.mk > > + @echo "Description: $(PACKAGE_ICU_DESCRIPTION): Common and Data > > libraries" >> $@ > > + @echo "Name: $(PACKAGE)-uc" >> $@ > > + ifeq ($(ENABLE_SHARED),) > > +- @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > > '$${baselibs}' >> $@ > > ++ @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > > '$${baselibs}' -lstdc++ >> $@ > > else > > @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" >> $@ > > - @echo "Libs.private:" "${ICULIBS_DT}" '$${baselibs}' >> $@ > > diff --git > > a/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch > > b/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch > > deleted file mode 100644 > > index e17f6ac775..0000000000 > > --- a/package/icu/0004-fix-static-linking-with-icu-uc-static-musl.patch > > +++ /dev/null > > Your patch seems not to be based on the current Buildroot master branch. > It cannot be applied, unfortunately. > > > @@ -1,26 +0,0 @@ > > -From 2107f9dfb39eeb6559fb4271c7af8b39aef521ca Mon Sep 17 00:00:00 2001 > > -From: Shubham Chakraborty <chakrabortyshubham66@gmail.com> > > -Date: Tue, 3 Mar 2026 10:00:00 +0000 > > -Subject: [PATCH] fix static linking with icu-uc (static case) > > - > > -During static linking with a C application and libicuuc.a, > > --lstdc++ is required. The previous patch (0003) only addressed the > > -shared library case (Libs.private). This patch adds -lstdc++ to the > > -main Libs line for the static case to fix undefined reference > > -errors when linking programs like xmlcatalog (libxml2) with > > -musl toolchains. > > - > > -Upstream: Inactive-Upstream [Buildroot specific] > > -Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> > > ---- > > - source/Makefile.in | 2 +- > > - 1 file changed, 1 insertion(+), 1 deletion(-) > > - > > -diff -git icu.orig/source/Makefile.in icu/source/Makefile.in > > ---- icu.orig/source/Makefile.in > > -+++ icu/source/Makefile.in > > -@@ -281,3 +281,3 @@ > > - ifeq ($(ENABLE_SHARED),) > > -- @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > > '$${baselibs}' >> $@ > > -+ @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > > '$${baselibs}' -lstdc++ >> $@ > > - else > > -- > > 2.53.0 > > Kind regards, > Andreas > [-- Attachment #1.2: Type: text/html, Size: 7676 bytes --] [-- Attachment #2: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v4] Extend the existing patch to also add -lstdc++ to the Libs field, fixing static linking issues with libicuuc.a. 2026-03-26 11:36 ` [Buildroot] [PATCH v3] package/icu: fix static linking with icu-uc Shubham Chakraborty 2026-03-27 4:27 ` Andreas Ziegler @ 2026-03-27 9:43 ` Shubham Chakraborty 2026-03-28 5:30 ` Andreas Ziegler 2026-03-28 7:47 ` [Buildroot] [PATCH v5] icu: fix static linking by adding -lstdc++ to pkg-config Shubham Chakraborty 1 sibling, 2 replies; 10+ messages in thread From: Shubham Chakraborty @ 2026-03-27 9:43 UTC (permalink / raw) To: buildroot; +Cc: thomas.petazzoni, romain.naour, br025, Shubham Chakraborty This combines the previous 0003 and 0004 changes into a single patch, following review feedback from Andreas. Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>--- --- Changes v3 -> v4: - Clean up patch to remove deleted 0004 patch file - Ensure only 0003 patch is modified; no extra files or deletions - Remove any rebase or history artifacts that caused previous patch failures --- .../0003-fix-static-linking-with-icu-uc.patch | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/package/icu/0003-fix-static-linking-with-icu-uc.patch b/package/icu/0003-fix-static-linking-with-icu-uc.patch index 36a3d1f696..c58f2700ee 100644 --- a/package/icu/0003-fix-static-linking-with-icu-uc.patch +++ b/package/icu/0003-fix-static-linking-with-icu-uc.patch @@ -13,14 +13,26 @@ http://autobuild.buildroot.net/results/210/2107f9dfb39eeb6559fb4271c7af8b39aef52 Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- - source/Makefile.in | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) +This patch currently addresses linking against stdc++ for shared-library +builds. Add -lstdc++ to the static build flags also, to fix 'undefined +reference' errors when linking programs like xmlcatalog (libxml2) +with musl static toolchains. + +Upstream: Inactive-Upstream [Buildroot specific] +Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> +--- + source/Makefile.in | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) diff -git icu.orig/source/Makefile.in icu/source/Makefile.in --- icu.orig/source/Makefile.in 2025-03-13 19:31:23.000000000 +0100 +++ icu/source/Makefile.in 2025-09-22 08:56:36.791792784 +0200 -@@ -279,7 +279,7 @@ - @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' >> $@ +@@ -276,10 +276,10 @@ config/icu-uc.pc: config/icu.pc Makefile icudefs.mk + @echo "Description: $(PACKAGE_ICU_DESCRIPTION): Common and Data libraries" >> $@ + @echo "Name: $(PACKAGE)-uc" >> $@ + ifeq ($(ENABLE_SHARED),) +- @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' >> $@ ++ @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' -lstdc++ >> $@ else @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" >> $@ - @echo "Libs.private:" "${ICULIBS_DT}" '$${baselibs}' >> $@ -- 2.53.0 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v4] Extend the existing patch to also add -lstdc++ to the Libs field, fixing static linking issues with libicuuc.a. 2026-03-27 9:43 ` [Buildroot] [PATCH v4] Extend the existing patch to also add -lstdc++ to the Libs field, fixing static linking issues with libicuuc.a Shubham Chakraborty @ 2026-03-28 5:30 ` Andreas Ziegler 2026-03-28 8:16 ` Shubham Chakraborty 2026-03-28 7:47 ` [Buildroot] [PATCH v5] icu: fix static linking by adding -lstdc++ to pkg-config Shubham Chakraborty 1 sibling, 1 reply; 10+ messages in thread From: Andreas Ziegler @ 2026-03-28 5:30 UTC (permalink / raw) To: Shubham Chakraborty; +Cc: buildroot, thomas.petazzoni, romain.naour Hi Shubham, Applying this patch now works, build fails, please see below ... On 2026-03-27 09:43, Shubham Chakraborty wrote: > This combines the previous 0003 and 0004 changes into a > single patch, following review feedback from Andreas. Your previous commit messages were more descriptive. Also 0004 never existed in the Buildroot sources ... > > Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>--- > --- > Changes v3 -> v4: > - Clean up patch to remove deleted 0004 patch file > - Ensure only 0003 patch is modified; no extra files or deletions > - Remove any rebase or history artifacts that caused previous patch > failures > --- > .../0003-fix-static-linking-with-icu-uc.patch | 20 +++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff --git a/package/icu/0003-fix-static-linking-with-icu-uc.patch > b/package/icu/0003-fix-static-linking-with-icu-uc.patch > index 36a3d1f696..c58f2700ee 100644 > --- a/package/icu/0003-fix-static-linking-with-icu-uc.patch > +++ b/package/icu/0003-fix-static-linking-with-icu-uc.patch > @@ -13,14 +13,26 @@ > http://autobuild.buildroot.net/results/210/2107f9dfb39eeb6559fb4271c7af8b39aef52 > > Signed-off-by: Romain Naour <romain.naour@openwide.fr> > --- > - source/Makefile.in | 2 +- > - 1 file changed, 1 insertion(+), 1 deletion(-) > +This patch currently addresses linking against stdc++ for > shared-library > +builds. Add -lstdc++ to the static build flags also, to fix 'undefined > +reference' errors when linking programs like xmlcatalog (libxml2) > +with musl static toolchains. > + > +Upstream: Inactive-Upstream [Buildroot specific] > +Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> > +--- > + source/Makefile.in | 4 ++-- > + 1 file changed, 2 insertions(+), 2 deletions(-) > > diff -git icu.orig/source/Makefile.in icu/source/Makefile.in > --- icu.orig/source/Makefile.in 2025-03-13 19:31:23.000000000 +0100 > +++ icu/source/Makefile.in 2025-09-22 08:56:36.791792784 +0200 > -@@ -279,7 +279,7 @@ > - @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > '$${baselibs}' >> $@ > +@@ -276,10 +276,10 @@ config/icu-uc.pc: config/icu.pc Makefile > icudefs.mk > + @echo "Description: $(PACKAGE_ICU_DESCRIPTION): Common and Data > libraries" >> $@ > + @echo "Name: $(PACKAGE)-uc" >> $@ There are eight space characters in the resulting patch, the icu Makefile uses one tab. The build fails with: Applying 0003-fix-static-linking-with-icu-uc.patch using patch: patching file source/Makefile.in Hunk #1 FAILED at 276. 1 out of 1 hunk FAILED -- saving rejects to file source/Makefile.in.rej > + ifeq ($(ENABLE_SHARED),) > +- @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > '$${baselibs}' >> $@ > ++ @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > '$${baselibs}' -lstdc++ >> $@ > else > @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" >> $@ > - @echo "Libs.private:" "${ICULIBS_DT}" '$${baselibs}' >> $@ > -- > 2.53.0 Kind regards, Andreas _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v4] Extend the existing patch to also add -lstdc++ to the Libs field, fixing static linking issues with libicuuc.a. 2026-03-28 5:30 ` Andreas Ziegler @ 2026-03-28 8:16 ` Shubham Chakraborty 0 siblings, 0 replies; 10+ messages in thread From: Shubham Chakraborty @ 2026-03-28 8:16 UTC (permalink / raw) To: Andreas Ziegler; +Cc: buildroot, Thomas Petazzoni, Romain Naour [-- Attachment #1.1: Type: text/plain, Size: 3489 bytes --] Hey Andreas, Apologies for sending a messy patch again. I'll clean up the formatting and ensure only the necessary changes from 0003 and more descriptive commit message are present in v5. Best regards, Shubham On Sat, 28 Mar, 2026, 11:00 am Andreas Ziegler, <br025@umbiko.net> wrote: > Hi Shubham, > > Applying this patch now works, build fails, please see below ... > > On 2026-03-27 09:43, Shubham Chakraborty wrote: > > This combines the previous 0003 and 0004 changes into a > > single patch, following review feedback from Andreas. > > Your previous commit messages were more descriptive. Also 0004 never > existed in the Buildroot sources ... > > > > > Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>--- > > --- > > Changes v3 -> v4: > > - Clean up patch to remove deleted 0004 patch file > > - Ensure only 0003 patch is modified; no extra files or deletions > > - Remove any rebase or history artifacts that caused previous patch > > failures > > --- > > .../0003-fix-static-linking-with-icu-uc.patch | 20 +++++++++++++++---- > > 1 file changed, 16 insertions(+), 4 deletions(-) > > > > diff --git a/package/icu/0003-fix-static-linking-with-icu-uc.patch > > b/package/icu/0003-fix-static-linking-with-icu-uc.patch > > index 36a3d1f696..c58f2700ee 100644 > > --- a/package/icu/0003-fix-static-linking-with-icu-uc.patch > > +++ b/package/icu/0003-fix-static-linking-with-icu-uc.patch > > @@ -13,14 +13,26 @@ > > > http://autobuild.buildroot.net/results/210/2107f9dfb39eeb6559fb4271c7af8b39aef52 > > > > Signed-off-by: Romain Naour <romain.naour@openwide.fr> > > --- > > - source/Makefile.in | 2 +- > > - 1 file changed, 1 insertion(+), 1 deletion(-) > > +This patch currently addresses linking against stdc++ for > > shared-library > > +builds. Add -lstdc++ to the static build flags also, to fix 'undefined > > +reference' errors when linking programs like xmlcatalog (libxml2) > > +with musl static toolchains. > > + > > +Upstream: Inactive-Upstream [Buildroot specific] > > +Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> > > +--- > > + source/Makefile.in | 4 ++-- > > + 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff -git icu.orig/source/Makefile.in icu/source/Makefile.in > > --- icu.orig/source/Makefile.in 2025-03-13 19:31:23.000000000 +0100 > > +++ icu/source/Makefile.in 2025-09-22 08:56:36.791792784 +0200 > > -@@ -279,7 +279,7 @@ > > - @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > > '$${baselibs}' >> $@ > > +@@ -276,10 +276,10 @@ config/icu-uc.pc: config/icu.pc Makefile > > icudefs.mk > > + @echo "Description: $(PACKAGE_ICU_DESCRIPTION): Common and Data > > libraries" >> $@ > > + @echo "Name: $(PACKAGE)-uc" >> $@ > > There are eight space characters in the resulting patch, the icu > Makefile uses one tab. The build fails with: > > Applying 0003-fix-static-linking-with-icu-uc.patch using patch: > patching file source/Makefile.in > Hunk #1 FAILED at 276. > 1 out of 1 hunk FAILED -- saving rejects to file source/Makefile.in.rej > > > + ifeq ($(ENABLE_SHARED),) > > +- @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > > '$${baselibs}' >> $@ > > ++ @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" > > '$${baselibs}' -lstdc++ >> $@ > > else > > @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" >> $@ > > - @echo "Libs.private:" "${ICULIBS_DT}" '$${baselibs}' >> $@ > > -- > > 2.53.0 > > Kind regards, > Andreas > [-- Attachment #1.2: Type: text/html, Size: 5056 bytes --] [-- Attachment #2: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v5] icu: fix static linking by adding -lstdc++ to pkg-config 2026-03-27 9:43 ` [Buildroot] [PATCH v4] Extend the existing patch to also add -lstdc++ to the Libs field, fixing static linking issues with libicuuc.a Shubham Chakraborty 2026-03-28 5:30 ` Andreas Ziegler @ 2026-03-28 7:47 ` Shubham Chakraborty 2026-03-29 6:33 ` Andreas Ziegler 1 sibling, 1 reply; 10+ messages in thread From: Shubham Chakraborty @ 2026-03-28 7:47 UTC (permalink / raw) To: buildroot; +Cc: thomas.petazzoni, romain.naour, br025, Shubham Chakraborty The ICU library requires C++ standard library when linking statically. Without this, applications using pkg-config --libs --static icu-uc will fail to link with undefined reference errors to C++ symbols. This patch extends the existing fix for static linking to also add -lstdc++ to the Libs field in the pkg-config file when building in static-only mode (ENABLE_SHARED is not set). Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> --- .../0003-fix-static-linking-with-icu-uc.patch | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/package/icu/0003-fix-static-linking-with-icu-uc.patch b/package/icu/0003-fix-static-linking-with-icu-uc.patch index 36a3d1f696..d74aca8088 100644 --- a/package/icu/0003-fix-static-linking-with-icu-uc.patch +++ b/package/icu/0003-fix-static-linking-with-icu-uc.patch @@ -13,14 +13,26 @@ http://autobuild.buildroot.net/results/210/2107f9dfb39eeb6559fb4271c7af8b39aef52 Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- - source/Makefile.in | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) +This patch currently addresses linking against stdc++ for shared-library +builds. Add -lstdc++ to the static build flags also, to fix 'undefined +reference' errors when linking programs like xmlcatalog (libxml2) +with musl static toolchains. + +Upstream: Inactive-Upstream [Buildroot specific] +Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> +--- + source/Makefile.in | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) diff -git icu.orig/source/Makefile.in icu/source/Makefile.in --- icu.orig/source/Makefile.in 2025-03-13 19:31:23.000000000 +0100 +++ icu/source/Makefile.in 2025-09-22 08:56:36.791792784 +0200 -@@ -279,7 +279,7 @@ - @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' >> $@ +@@ -276,10 +276,10 @@ + @echo "Description: $(PACKAGE_ICU_DESCRIPTION): Common and Data libraries" >> $@ + @echo "Name: $(PACKAGE)-uc" >> $@ + ifeq ($(ENABLE_SHARED),) +- @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' >> $@ ++ @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" "${ICULIBS_DT}" '$${baselibs}' -lstdc++ >> $@ else @echo "Libs:" '-L$${libdir}' "${ICULIBS_UC}" >> $@ - @echo "Libs.private:" "${ICULIBS_DT}" '$${baselibs}' >> $@ -- 2.53.0 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v5] icu: fix static linking by adding -lstdc++ to pkg-config 2026-03-28 7:47 ` [Buildroot] [PATCH v5] icu: fix static linking by adding -lstdc++ to pkg-config Shubham Chakraborty @ 2026-03-29 6:33 ` Andreas Ziegler 0 siblings, 0 replies; 10+ messages in thread From: Andreas Ziegler @ 2026-03-29 6:33 UTC (permalink / raw) To: Shubham Chakraborty; +Cc: buildroot, thomas.petazzoni, romain.naour Hi Shubham, Thank you! On 2026-03-28 07:47, Shubham Chakraborty wrote: > The ICU library requires C++ standard library when linking statically. > Without this, applications using pkg-config --libs --static icu-uc > will fail to link with undefined reference errors to C++ symbols. > > This patch extends the existing fix for static linking to also add > -lstdc++ to the Libs field in the pkg-config file when building > in static-only mode (ENABLE_SHARED is not set). > > Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com> > --- > .../0003-fix-static-linking-with-icu-uc.patch | 20 +++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > Acked-by: Andreas Ziegler <br025@umbiko.net> Kind regards, Andreas _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-03-29 6:33 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-03-03 16:28 [Buildroot] [PATCH] package/icu: fix static linking with icu-uc for musl static toolchains Shubham Chakraborty 2026-03-03 18:21 ` [Buildroot] [PATCH v2] " Shubham Chakraborty 2026-03-26 11:36 ` [Buildroot] [PATCH v3] package/icu: fix static linking with icu-uc Shubham Chakraborty 2026-03-27 4:27 ` Andreas Ziegler 2026-03-27 9:50 ` Shubham Chakraborty 2026-03-27 9:43 ` [Buildroot] [PATCH v4] Extend the existing patch to also add -lstdc++ to the Libs field, fixing static linking issues with libicuuc.a Shubham Chakraborty 2026-03-28 5:30 ` Andreas Ziegler 2026-03-28 8:16 ` Shubham Chakraborty 2026-03-28 7:47 ` [Buildroot] [PATCH v5] icu: fix static linking by adding -lstdc++ to pkg-config Shubham Chakraborty 2026-03-29 6:33 ` Andreas Ziegler
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox