public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Quentin Schulz via buildroot <buildroot@buildroot.org>
To: Jimmy Durand Wesolowski <jimmy.wesolowski@mobileye.com>,
	buildroot@buildroot.org
Cc: Kadambini Nema <kadambini.nema@gmail.com>,
	guenther.harrasser@mobileye.com
Subject: Re: [Buildroot] [PATCH 1/5] package/libopenssl: bump version to 3.5.0
Date: Tue, 17 Mar 2026 16:00:02 +0100	[thread overview]
Message-ID: <d703edf5-c644-453d-a3e3-7e2024d1890e@cherry.de> (raw)
In-Reply-To: <20260316161402.1994225-1-jimmy.wesolowski@mobileye.com>

Hi Jimmy,

Thanks for doing that :) A few things to improve though, see below.

This series doesn't follow the naming scheme required for backporting to 
stable releases. See 
https://buildroot.org/downloads/manual/manual.html#submitting-patches 
22.5.4. Patches for maintenance branches, specifically

"""
However, some bugs may apply only to a specific release, for example 
because it is using an older version of a package. In that case, patches 
should be based off the maintenance branch, and the patch subject prefix 
must include the maintenance branch name (for example "[PATCH 2020.02.x]").
"""

You also said on the #buildroot IRC channel to "Please wait that I test 
it on the runner." so please consider only sending series once you're 
done with your own testing.

I highly suggest to provide a cover letter to your v2, anybody not 
following the IRC channel won't be able to understand why this was done 
(and people who do follow the channel may forget about it). There needs 
to be context and justification why this is fine to backport even though 
it's a major version bump.

For what it's worth, I've done this in a local branch and added an 
additional patch for OpenSSL 3.5.5 security bump (see 
https://github.com/openssl/openssl/releases/tag/openssl-3.5.5) and I'm 
about to publish a new release for one of our products based on that 
(just so you know there's been *some* testing).

Cheers,
Quentin

On 3/16/26 5:13 PM, Jimmy Durand Wesolowski via buildroot wrote:
> From: Kadambini Nema <kadambini.nema@gmail.com>
> 
> Release notes:
> https://github.com/openssl/openssl/releases/tag/openssl-3.5.0
> 
> Changelog:
> https://github.com/openssl/openssl/blob/master/CHANGES.md#openssl-35
> 
> Rebased patches for the new version.
> 
> Signed-off-by: Kadambini Nema <kadambini.nema@gmail.com>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> (cherry picked from commit 9868ca6ec98afa28a94aea50cc940db7df860396)
> Conflicts on
>    package/libopenssl/libopenssl.hash
>    package/libopenssl/libopenssl.mk
> due to intermediate security bumps from 4.1 to 4.4 with commits
>    0ec6cf7f69da "package/libopenssl: bump to v3.4.2"
>    cd6d8b9b251d "package/libopenssl: security bump to version 3.4.3"
>    dbf192e1764e "Package/libopenssl: security bump to v3.4.4"
> Signed-off-by: Jimmy Durand Wesolowski <jimmy.wesolowski@mobileye.com>
> ---
>   ...nfigure-use-ELFv2-ABI-on-some-ppc64-big-endian-sys.patch | 4 ++--
>   package/libopenssl/0003-Revert-Fix-static-builds.patch      | 6 +++---
>   package/libopenssl/libopenssl.hash                          | 4 ++--
>   package/libopenssl/libopenssl.mk                            | 2 +-
>   4 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/package/libopenssl/0002-Configure-use-ELFv2-ABI-on-some-ppc64-big-endian-sys.patch b/package/libopenssl/0002-Configure-use-ELFv2-ABI-on-some-ppc64-big-endian-sys.patch
> index 629d9c26ce..2634d69f35 100644
> --- a/package/libopenssl/0002-Configure-use-ELFv2-ABI-on-some-ppc64-big-endian-sys.patch
> +++ b/package/libopenssl/0002-Configure-use-ELFv2-ABI-on-some-ppc64-big-endian-sys.patch
> @@ -18,10 +18,10 @@ Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
>    1 file changed, 4 insertions(+)
>   
>   diff --git a/Configure b/Configure
> -index 5a699836f3..f9152b1702 100755
> +index 15054f9..ac3206e 100755
>   --- a/Configure
>   +++ b/Configure
> -@@ -1549,6 +1549,10 @@ unless ($disabled{asm}) {
> +@@ -1685,6 +1685,10 @@ unless ($disabled{asm}) {
>        }
>    }
>    
> diff --git a/package/libopenssl/0003-Revert-Fix-static-builds.patch b/package/libopenssl/0003-Revert-Fix-static-builds.patch
> index b4b78c97fc..e800b782ad 100644
> --- a/package/libopenssl/0003-Revert-Fix-static-builds.patch
> +++ b/package/libopenssl/0003-Revert-Fix-static-builds.patch
> @@ -15,10 +15,10 @@ Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>    1 file changed, 4 insertions(+), 4 deletions(-)
>   
>   diff --git a/Configure b/Configure
> -index 2a5e58805c3b..0e8c1ce5cc74 100755
> +index ac3206e..764ef89 100755
>   --- a/Configure
>   +++ b/Configure
> -@@ -1466,10 +1466,6 @@ if ($config{prefix} && !$config{CROSS_COMPILE}) {
> +@@ -1509,10 +1509,6 @@ if ($config{prefix} && !$config{CROSS_COMPILE}) {
>            unless file_name_is_absolute($config{prefix});
>    }
>    
> @@ -29,7 +29,7 @@ index 2a5e58805c3b..0e8c1ce5cc74 100755
>    # Allow overriding the build file name
>    $config{build_file} = env('BUILDFILE') || $target{build_file} || "Makefile";
>    
> -@@ -1764,6 +1760,10 @@ if ($strict_warnings)
> +@@ -1807,6 +1803,10 @@ if ($strict_warnings)
>                    }
>            }
>    
> diff --git a/package/libopenssl/libopenssl.hash b/package/libopenssl/libopenssl.hash
> index ea288054e9..9f8b23005a 100644
> --- a/package/libopenssl/libopenssl.hash
> +++ b/package/libopenssl/libopenssl.hash
> @@ -1,5 +1,5 @@
> -# From https://github.com/openssl/openssl/releases/download/openssl-3.4.4/openssl-3.4.4.tar.gz.sha256
> -sha256  7bdf55ac20f2779e99e5eca306f824fad2b37dee5a06cc35ed5a8b85a6060010  openssl-3.4.4.tar.gz
> +# From https://github.com/openssl/openssl/releases/download/openssl-3.5.0/openssl-3.5.0.tar.gz.sha256
> +sha256  344d0a79f1a9b08029b0744e2cc401a43f9c90acd1044d09a530b4885a8e9fc0  openssl-3.5.0.tar.gz
>   
>   # License files
>   sha256  7d5450cb2d142651b8afa315b5f238efc805dad827d91ba367d8516bc9d49e7a  LICENSE.txt
> diff --git a/package/libopenssl/libopenssl.mk b/package/libopenssl/libopenssl.mk
> index 8e3ae4cc21..5e785e1bf0 100644
> --- a/package/libopenssl/libopenssl.mk
> +++ b/package/libopenssl/libopenssl.mk
> @@ -4,7 +4,7 @@
>   #
>   ################################################################################
>   
> -LIBOPENSSL_VERSION = 3.4.4
> +LIBOPENSSL_VERSION = 3.5.0
>   LIBOPENSSL_SITE = https://github.com/openssl/openssl/releases/download/openssl-$(LIBOPENSSL_VERSION)
>   LIBOPENSSL_SOURCE = openssl-$(LIBOPENSSL_VERSION).tar.gz
>   LIBOPENSSL_LICENSE = Apache-2.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2026-03-17 15:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 16:13 [Buildroot] [PATCH 1/5] package/libopenssl: bump version to 3.5.0 Jimmy Durand Wesolowski via buildroot
2026-03-16 16:13 ` [Buildroot] [PATCH 2/5] package/libopenssl: security bump version to 3.5.1 Jimmy Durand Wesolowski via buildroot
2026-03-16 16:13 ` [Buildroot] [PATCH 3/5] package/libopenssl: bump version to 3.5.2 Jimmy Durand Wesolowski via buildroot
2026-03-16 16:13 ` [Buildroot] [PATCH 4/5] package/libopenssl: bump version to 3.5.3 Jimmy Durand Wesolowski via buildroot
2026-03-16 16:13 ` [Buildroot] [PATCH 5/5] package/libopenssl: security bump to version 3.5.4 Jimmy Durand Wesolowski via buildroot
2026-03-17 15:00 ` Quentin Schulz via buildroot [this message]
2026-03-17 15:24   ` [Buildroot] [PATCH 1/5] package/libopenssl: bump version to 3.5.0 Jimmy Wesolowski via buildroot
2026-03-17 15:40     ` Quentin Schulz via buildroot
2026-03-19 12:42 ` [Buildroot] [PATCH 2025.02.x v2] Package/libopenssl: security bump to version 3.5.4 Jimmy Durand Wesolowski via buildroot
2026-03-19 12:42   ` [Buildroot] [PATCH 2025.02.x v2] package/libopenssl: bump version to 3.5.0 Jimmy Durand Wesolowski via buildroot
2026-03-19 12:42   ` [Buildroot] [PATCH 2025.02.x v2] package/libopenssl: security bump version to 3.5.1 Jimmy Durand Wesolowski via buildroot
2026-03-19 12:42   ` [Buildroot] [PATCH 2025.02.x v2] package/libopenssl: bump version to 3.5.2 Jimmy Durand Wesolowski via buildroot
2026-03-19 12:42   ` [Buildroot] [PATCH 2025.02.x v2] package/libopenssl: bump version to 3.5.3 Jimmy Durand Wesolowski via buildroot
2026-03-19 12:42   ` [Buildroot] [PATCH 2025.02.x v2] package/libopenssl: security bump to version 3.5.4 Jimmy Durand Wesolowski via buildroot
2026-03-23 15:50   ` [Buildroot] [PATCH 2025.02.x v2] Package/libopenssl: " Quentin Schulz via buildroot
2026-03-25  8:39     ` Jimmy Wesolowski via buildroot
2026-04-13 12:27     ` Thomas Perale via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d703edf5-c644-453d-a3e3-7e2024d1890e@cherry.de \
    --to=buildroot@buildroot.org \
    --cc=guenther.harrasser@mobileye.com \
    --cc=jimmy.wesolowski@mobileye.com \
    --cc=kadambini.nema@gmail.com \
    --cc=quentin.schulz@cherry.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox