Re: [Buildroot] [PATCH] package/linux-tools: selftests: Use KHDR_INCLUDES to locate the headers

[Maxime Chevallier via buildroot <buildroot@buildroot.org>]

Hi Thomas,

On 9/7/26 08:23, Thomas Petazzoni wrote:
> Hello Maxime,
> 
> On Sat, Sep 05, 2026 at 11:39:51AM +0200, Maxime Chevallier via buildroot wrote:
>> Since v6.7 [1], the KHDR_DIR variable isn't used anymore  by the kernel
>> selftest Makefiles to locate the kernel headers. Instead, KHDR_INCLUDES
>> is used to specify their location.
> 
> But then doesn't that mean that the build would be broken for people
> who build Linux < 6.7 ? Keep in mind that the Linux kernel version in
> Buildroot is configurable, so not everyone is building the latest and
> greatest.

Looking at the kernel history, the KHDR_DIR only existed between v6.4 and v6.7 :

Added in v6.4 :

9fc96c7c19df ("selftests: error out if kernel header files are not yet built")

Reverted in v6.7 :

43e8832fed08 ("Revert "selftests: error out if kernel header files are not yet built"")

And it looks like even between that v6.4 and v6.7 window, KHDR_DIR is just used to
populate KHDR_INCLUDES :


  tools/testing/selftests/lib.mk

  [...]

  KHDR_INCLUDES := -isystem $(KHDR_DIR)


So I think this should work even on kernels older than v6.7, I haven't
tried though ;(

I can add these details in the commit log in a resend if you want,

Maxime

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot