Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: "Raphaël Gallais-Pou" <rgallaispou@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/alacritty: new package
Date: Wed, 02 Sep 2026 22:26:39 +0200	[thread overview]
Message-ID: <de0534fd002f0672c206820051607641@free.fr> (raw)
In-Reply-To: <20260830-alacritty-v1-1-a4965888e281@gmail.com>

Hi Raphaël,

Thanks for the patch. I have few comments, see below.

On 30/08/2026 20:53, Raphaël Gallais-Pou wrote:
> Alacritty is a modern terminal emulator that comes with sensible
> defaults, but allows for extensive configuration.  By integrating with
> other applications, rather than reimplementing their functionality, it
> manages to provide a flexible set of features with high performance.
> 
> Although this project works both on Wayland and X11, it is for now only
> enabled with Wayland support.
> 
> Project mainpage: https://github.com/alacritty/alacritty
> 
> Signed-off-by: Raphaël Gallais-Pou <rgallaispou@gmail.com>
> ---
[...]
> diff --git a/package/alacritty/Config.in b/package/alacritty/Config.in
> new file mode 100644
> index 000000000000..f8f7716163fb
> --- /dev/null
> +++ b/package/alacritty/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_ALACRITTY
> +	bool "alacritty"
> +	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
> +	depends on BR2_PACKAGE_HAS_UDEV
> +	depends on !BR2_STATIC_LIBS # wayland
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
> +	select BR2_PACKAGE_HOST_RUSTC
> +	select BR2_PACKAGE_WAYLAND
> +	select BR2_PACKAGE_WAYLAND_PROTOCOLS
> +	select BR2_PACKAGE_LIBXKBCOMMON
> +	select BR2_PACKAGE_FREETYPE
> +	select BR2_PACKAGE_FONTCONFIG

Could you sort package selection alphabetically, please?

> +	help
> +	  Alacritty is a modern terminal emulator that comes with
> +	  sensible defaults, but allows for extensive configuration.
> +	  By integrating with other applications, rather than
> +	  reimplementing their functionality, it manages to provide a
> +	  flexible set of features with high performance.
> +
> +	  https://github.com/alacritty/alacritty.git
> diff --git a/package/alacritty/alacritty.hash 
> b/package/alacritty/alacritty.hash
> new file mode 100644
> index 000000000000..746980695baa
> --- /dev/null
> +++ b/package/alacritty/alacritty.hash
> @@ -0,0 +1,4 @@
> +# Locally computed
> +sha256  
> c1017a192d606c968e471b8363c29c259847bb84c9700044a521856edd7aba07  
> alacritty-0.17-cargo6.tar.gz
> +sha256  
> 651999319c27e92fe8eaf76451f18237107230b27cd6d580a0ab99f1c622d167  
> LICENSE-APACHE
> +sha256  
> 5675ca8acdd280622f93c6ff64c3a2714d9322da4337c2028d4dbb0475686ff2  
> LICENSE-MIT

Running the command "make alacritty-legal-info"
reports license hash failures.

Could you fix those license hash please?

> diff --git a/package/alacritty/alacritty.mk 
> b/package/alacritty/alacritty.mk
> new file mode 100644
> index 000000000000..65675a4524a2
> --- /dev/null
> +++ b/package/alacritty/alacritty.mk
> @@ -0,0 +1,33 @@
> +################################################################################
> +#
> +# alacritty
> +#
> +################################################################################
> +
> +ALACRITTY_VERSION = 0.17

Testing this package with "test-pkg -a -p alacritty" reports few build 
failures. See:
https://gitlab.com/jolivain/buildroot/-/pipelines/2814538626

Could you have a look please?

> +ALACRITTY_SITE = $(call 
> github,alacritty,alacritty,v$(ALACRITTY_VERSION))
> +ALACRITTY_LICENSE = Apache-2.0, MIT
> +ALACRITTY_LICENSE_FILES = LICENSE-APACHE LICENSE-MIT
> +ALACRITTY_DEPENDENCIES = wayland wayland-protocols libxkbcommon 
> freetype fontconfig

Could you sort those dependencies alphabetically, please?

> +
> +ALACRITTY_SUBDIR = alacritty
> +ALACRITTY_CARGO_BUILD_OPTS = --no-default-features --features=wayland
> +ALACRITTY_CARGO_INSTALL_OPTS = --no-default-features 
> --features=wayland
> +
> +define ALACRITTY_INSTALL_ADDITIONAL_FILES
> +	# Create destination folders if the do not exist
> +	$(INSTALL) -d -m 0755 $(TARGET_DIR)/usr/share/applications
> +	$(INSTALL) -d -m 0755 $(TARGET_DIR)/usr/share/pixmaps
> +
> +	# Install .desktop file
> +	$(INSTALL) -D -m 0644 $(@D)/extra/linux/Alacritty.desktop \
> +		$(TARGET_DIR)/usr/share/applications/Alacritty.desktop
> +
> +	# Install SVG icon
> +	$(INSTALL) -D -m 0644 $(@D)/extra/logo/alacritty-term.svg \
> +		$(TARGET_DIR)/usr/share/pixmaps/Alacritty.svg
> +endef
> +
> +ALACRITTY_POST_INSTALL_TARGET_HOOKS += 
> ALACRITTY_INSTALL_ADDITIONAL_FILES
> +
> +$(eval $(cargo-package))
> 
> ---
> base-commit: e1ec936cf732e50bddb588985a8d6738b43da3ac
> change-id: 20260830-alacritty-6a3c8a3edee7
> 
> Best regards,
> --
> Raphaël Gallais-Pou <rgallaispou@gmail.com>

Could you send an updated patch addressing those issues, please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-09-02 20:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-30 18:53 [Buildroot] [PATCH] package/alacritty: new package Raphaël Gallais-Pou
2026-09-02 20:26 ` Julien Olivain via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de0534fd002f0672c206820051607641@free.fr \
    --to=buildroot@buildroot.org \
    --cc=ju.o@free.fr \
    --cc=rgallaispou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox