From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package: linuxptp: enhance systemd service
Date: Mon, 22 Oct 2018 00:19:46 +0100 [thread overview]
Message-ID: <eaee0d92-ef95-f48d-05eb-04124c459ef3@mind.be> (raw)
In-Reply-To: <c63fff97-491b-8d5a-fb99-095e3fa08423@jikos.cz>
On 30/01/2018 22:19, Petr Kulhavy wrote:
> Hi Thomas,
>
> The Before= and Wants=? time-sync.target is what I found in the systemd
> documentation. A time synchronization service should pull in this special
> target, so that applications needing time synchronization can depend on it.
> Other time synchronizing services like ntpd or systemd-timesyncd use the same
> mechanism.
?I double-checked this and confirm. So I've extended the commit log a little and
applied to master, thanks.
?Sorry that it took so long...
?Regards,
?Arnout
> Cheers
> Petr
>
> On 30/01/18 23:00, Thomas Petazzoni wrote:
>> Hello,
>>
>> On Sun, 28 Jan 2018 17:00:20 +0100, Petr Kulhavy wrote:
>>> linuxptp now pulls in the time-sync.target
>>> phc2sys (linuxptp-system-clock.service) starts after ptp4l (linuxptp.service)
>>>
>>> Signed-off-by: Petr Kulhavy <brain@jikos.cz>
>>> ---
>>> ? package/linuxptp/linuxptp-system-clock.service | 2 +-
>>> ? package/linuxptp/linuxptp.service????????????? | 2 ++
>>> ? 2 files changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/package/linuxptp/linuxptp-system-clock.service
>>> b/package/linuxptp/linuxptp-system-clock.service
>>> index 7327254..a4436a3 100644
>>> --- a/package/linuxptp/linuxptp-system-clock.service
>>> +++ b/package/linuxptp/linuxptp-system-clock.service
>>> @@ -1,6 +1,6 @@
>>> ? [Unit]
>>> ? Description=Precision Time Protocol system clock synchronization
>>> -After=syslog.target network.target
>>> +After=linuxptp.service
>>> ? ? [Service]
>>> ? ExecStart=/usr/sbin/phc2sys -s /dev/ptp0 -c CLOCK_REALTIME -w -S 1.0
>>> diff --git a/package/linuxptp/linuxptp.service
>>> b/package/linuxptp/linuxptp.service
>>> index f690430..14e9814 100644
>>> --- a/package/linuxptp/linuxptp.service
>>> +++ b/package/linuxptp/linuxptp.service
>>> @@ -1,6 +1,8 @@
>>> ? [Unit]
>>> ? Description=Precision Time Protocol daemon
>>> ? After=syslog.target network.target
>>> +Before=time-sync.target
>>> +Wants=time-sync.target
>>> ? Wants=linuxptp-system-clock.service
>>> ? ? [Service]
>> I'm not knowledgeable enough in systemd stuff to decide on this one.
>> Anyone with more systemd knowledge ?
>>
>> Thomas
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
next prev parent reply other threads:[~2018-10-21 23:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 16:00 [Buildroot] [PATCH 1/3] package: linuxptp: bump to the latest GIT version Petr Kulhavy
2018-01-28 16:00 ` [Buildroot] [PATCH 2/3] package: linuxptp: enhance systemd service Petr Kulhavy
2018-01-30 22:00 ` Thomas Petazzoni
2018-01-30 22:19 ` Petr Kulhavy
2018-10-21 23:19 ` Arnout Vandecappelle [this message]
2018-01-28 16:00 ` [Buildroot] [PATCH 3/3] package: linuxptp: workaround for system crash if PHY is not initialized Petr Kulhavy
2018-01-30 22:01 ` Thomas Petazzoni
2018-01-30 22:14 ` Petr Kulhavy
2018-10-21 22:12 ` Arnout Vandecappelle
2018-01-30 22:00 ` [Buildroot] [PATCH 1/3] package: linuxptp: bump to the latest GIT version Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaee0d92-ef95-f48d-05eb-04124c459ef3@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox