From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Bernd Kuhls <bernd@kuhls.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/3] package/xxhash: fix prefix in libxxhash.pc
Date: Wed, 21 Oct 2026 21:28:43 +0200 [thread overview]
Message-ID: <eb71be4a052714bf1ef447349b3b7dc7@free.fr> (raw)
In-Reply-To: <atkIH64LJ8KOg8sZ@windsurf>
Hi Thomas,
On 21/10/2026 20:46, Thomas Petazzoni via buildroot wrote:
> Hello Bernd,
>
> Wow, the timing is crazy, I sent the same patch at:
>
> Date: Wed, 21 Oct 2026 20:35:32 +0200
>
> Just a few minutes before you did!
>
> On Wed, Oct 21, 2026 at 08:41:38PM +0200, Bernd Kuhls wrote:
>> PREFIX defaults to /usr/local according to
>> https://github.com/Cyan4973/xxHash/blob/v0.8.3/Makefile#L549
>>
>> libxxhash.pc contains "prefix=/usr/local" without this patch causing a
>> build error with libplacebo when xxhash was built before libplacebo:
>>
>> Run-time dependency libxxhash found: YES 0.8.3
>> Configuring config.h using configuration
>> Configuring config_internal.h using configuration
>>
>> ../output-1/build/libplacebo-v7.360.1/src/meson.build:247:6: ERROR:
>> Include dir
>>
>> /home/thomas/autobuild/instance-0/output-1/host/i686-buildroot-linux-gnu/sysroot/usr/local/include
>> does not exist.
>>
>> Fixes:
>> https://autobuild.buildroot.net/results/344/344af8504a77ae96e4009d76a77572180cf49b14/
>>
>> No changes were made in upstream libplacebo to src/meson.build since
>> its
>> addition with commit 006aab8d64d2179d77df9a696b3fd8636f541640 so a
>> backport to LTS branches should be considered.
>
> libplacebo doesn't matter here, what matters is xxhash, placebo
> failing is just one illustration of the libxxhash.pc issue. So the
> research on since when the problem exists should have focused on
> xxhash, not libplacebo.
I applied your proposal
https://lore.kernel.org/buildroot/20261021183533.2649298-1-thomas.petazzoni@bootlin.com/T/#u
instead of this patch. I also applied the rest of this series.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
Best regards,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-10-21 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 18:41 [Buildroot] [PATCH 1/3] package/libplacebo: add optional dependencies to lcms & xxhash Bernd Kuhls
2026-10-21 18:41 ` [Buildroot] [PATCH 2/3] package/xxhash: fix prefix in libxxhash.pc Bernd Kuhls
2026-10-21 18:46 ` Thomas Petazzoni via buildroot
2026-10-21 19:28 ` Julien Olivain via buildroot [this message]
2026-10-21 18:41 ` [Buildroot] [PATCH 3/3] package/xxhash: bump version to 0.8.4 Bernd Kuhls
2026-10-21 19:27 ` [Buildroot] [PATCH 1/3] package/libplacebo: add optional dependencies to lcms & xxhash Julien Olivain via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb71be4a052714bf1ef447349b3b7dc7@free.fr \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox