From: Julien Olivain <juju@cotds.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] board/freescale: use correct ahab-container.img file name
Date: Thu, 20 Feb 2020 21:27:34 +0100 [thread overview]
Message-ID: <efadf675f8868fca038b0eb30f9d20df@cotds.org> (raw)
In-Reply-To: <20200220021858.700249-1-thomas.petazzoni@bootlin.com>
Hi Thomas,
Patch looks good. I successfully built and booted on i.MX8 MEK QM and
QXP boards. Thanks!
On 2020-02-20 03:18, Thomas Petazzoni wrote:
> Commit 3f8ace002831a01ed6aec59b704bd92c8a3b957f
> ("board/freescale/common/imx: add support for i.MX8") had its
> conflicts incorrectly tweaked when applied to Buildroot. The
> ahab-container.img is installed with this name (ahab-container.img) by
> the imx-firmware package, and not mx8qm-ahab-container.img or
> mx8qx-ahab-container.img.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> board/freescale/common/imx/imx8-bootloader-prepare.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/freescale/common/imx/imx8-bootloader-prepare.sh
> b/board/freescale/common/imx/imx8-bootloader-prepare.sh
> index 302fd00658..45c648e360 100755
> --- a/board/freescale/common/imx/imx8-bootloader-prepare.sh
> +++ b/board/freescale/common/imx/imx8-bootloader-prepare.sh
> @@ -28,9 +28,9 @@ main ()
> cp ${BINARIES_DIR}/bl31.bin ${BINARIES_DIR}/u-boot-atf.bin
> dd if=${BINARIES_DIR}/u-boot-hash.bin
> of=${BINARIES_DIR}/u-boot-atf.bin bs=1K seek=128
> if grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8=y$"
> ${BR2_CONFIG}; then
> - ${HOST_DIR}/bin/mkimage_imx8 -soc QM -rev B0 -append
> ${BINARIES_DIR}/mx8qm-ahab-container.img -c -scfw
> ${BINARIES_DIR}/mx8qm-mek-scfw-tcm.bin -ap
> ${BINARIES_DIR}/u-boot-atf.bin a53 0x80000000 -out
> ${BINARIES_DIR}/imx8-boot-sd.bin
> + ${HOST_DIR}/bin/mkimage_imx8 -soc QM -rev B0 -append
> ${BINARIES_DIR}/ahab-container.img -c -scfw
> ${BINARIES_DIR}/mx8qm-mek-scfw-tcm.bin -ap
> ${BINARIES_DIR}/u-boot-atf.bin a53 0x80000000 -out
> ${BINARIES_DIR}/imx8-boot-sd.bin
> else
> - ${HOST_DIR}/bin/mkimage_imx8 -soc QX -rev B0 -append
> ${BINARIES_DIR}/mx8qx-ahab-container.img -c -scfw
> ${BINARIES_DIR}/mx8qx-mek-scfw-tcm.bin -ap
> ${BINARIES_DIR}/u-boot-atf.bin a35 0x80000000 -out
> ${BINARIES_DIR}/imx8-boot-sd.bin
> + ${HOST_DIR}/bin/mkimage_imx8 -soc QX -rev B0 -append
> ${BINARIES_DIR}/ahab-container.img -c -scfw
> ${BINARIES_DIR}/mx8qx-mek-scfw-tcm.bin -ap
> ${BINARIES_DIR}/u-boot-atf.bin a35 0x80000000 -out
> ${BINARIES_DIR}/imx8-boot-sd.bin
> fi
> fi
Reviewed-by: Julien Olivain <juju@cotds.org>
Tested-by: Julien Olivain <juju@cotds.org>
next prev parent reply other threads:[~2020-02-20 20:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 2:18 [Buildroot] [PATCH 1/2] board/freescale: use correct ahab-container.img file name Thomas Petazzoni
2020-02-20 2:18 ` [Buildroot] [PATCH 2/2] package/freescale-imx/firmware-imx: install mx8qm-ahab-container.img Thomas Petazzoni
2020-02-20 7:02 ` Refik Tuzakli
2020-02-20 20:28 ` Julien Olivain
2020-07-27 13:25 ` Thomas Petazzoni
2020-02-20 20:27 ` Julien Olivain [this message]
2020-02-20 20:33 ` [Buildroot] [PATCH 1/2] board/freescale: use correct ahab-container.img file name Fabio Estevam
2020-02-26 21:28 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efadf675f8868fca038b0eb30f9d20df@cotds.org \
--to=juju@cotds.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox