Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] Revert "glibc: install the obsolete libnsl"
Date: Tue, 1 May 2018 22:09:01 +0200	[thread overview]
Message-ID: <eff9b6b0-1abb-8edc-8cf9-9aa4e25ddfb2@gmail.com> (raw)
In-Reply-To: <20180501200508.13974-2-romain.naour@gmail.com>

All,

Le 01/05/2018 ? 22:05, Romain Naour a ?crit?:
> libnsl from Glibc is deprecated and should not be used anymore.
> libnsl is now an separate library that can be packaged later if
> necessary [1].
> 
> Note: libnsl from Glibc doesn't build with gcc 8 due new warning [2].
> 
> [1] https://github.com/thkukuk/libnsl.git
> [2] http://patchwork.sourceware.org/patch/26437
> 
> This reverts commit 398747f5fafca8c07e696612d8eded53d4f935c7.

I missed libnsl.so.* from GLIBC_LIBS_LIB list. It should be removed.
Same for libnsl.so.* from TOOLCHAIN_EXTERNAL_LIBS.

Thoughts?

Best regards,
Romain

> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/glibc/glibc.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/glibc/glibc.mk b/package/glibc/glibc.mk
> index 3ab673c0cc..0d406c195e 100644
> --- a/package/glibc/glibc.mk
> +++ b/package/glibc/glibc.mk
> @@ -100,7 +100,6 @@ define GLIBC_CONFIGURE_CMDS
>  		--disable-profile \
>  		--without-gd \
>  		--enable-obsolete-rpc \
> -		--enable-obsolete-nsl \
>  		--enable-kernel=$(call qstrip,$(BR2_TOOLCHAIN_HEADERS_AT_LEAST)) \
>  		--with-headers=$(STAGING_DIR)/usr/include)
>  	$(GLIBC_ADD_MISSING_STUB_H)
> 

  reply	other threads:[~2018-05-01 20:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 20:05 [Buildroot] [PATCH 1/2] package/exim: remove libnsl linking with Glibc Romain Naour
2018-05-01 20:05 ` [Buildroot] [PATCH 2/2] Revert "glibc: install the obsolete libnsl" Romain Naour
2018-05-01 20:09   ` Romain Naour [this message]
2018-05-01 20:12 ` [Buildroot] [PATCH 1/2] package/exim: remove libnsl linking with Glibc Thomas Petazzoni
2018-05-01 20:19   ` Romain Naour
2018-05-01 20:37     ` Thomas Petazzoni
2018-05-04 20:54       ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eff9b6b0-1abb-8edc-8cf9-9aa4e25ddfb2@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox