Re: [Buildroot] [PATCH] package/rtl8821cu: fix build failure on PowerPC64

[Giulio Benetti <giulio.benetti@benettiengineering.com>]

Hi Peter,

On 05/03/23 19:33, Peter Korsgaard wrote:
>>>>>> "Christian" == Christian Stewart via buildroot <buildroot@buildroot.org> writes:
> 
>   > Hi Giulio,
>   > On Thu, Mar 2, 2023 at 7:19 AM Giulio Benetti
>   > <giulio.benetti@benettiengineering.com> wrote:
>   >>
>   >> Let's add local patch pending upstream to fix get_ra() conflict on
>   >> PowerPC64 architecture.
>   >>
>   >> [0]: https://github.com/morrownr/8821cu-20210118/pull/93
>   >>
>   >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>   >> ---
>   >> .../0001-Fix-build-on-PowerPC64.patch         | 123 ++++++++++++++++++
>   >> 1 file changed, 123 insertions(+)
>   >> create mode 100644 package/rtl8821cu/0001-Fix-build-on-PowerPC64.patch
> 
>   > The repo owner morrownr requested that we switch to the newer version
>   > of the package, and send the PR there.
> 
>   > I sent the PR there: https://github.com/morrownr/8821cu-20210916/pull/73
> 
>   > The patch to update to the new version:
> 
>   > https://patchwork.ozlabs.org/project/buildroot/patch/20230303074829.2139881-1-christian@paral.in/
> 
> What is the relation exactly between these two patches? Are they fixing
> the same issue? Is this patch superseeded by your patch changing the
> version?

This patch is still valid, it fixes the bug for the current repository
used by the package.
But soon the repository will be moved to a new one:
https://github.com/morrownr/8821cu-20210916
because the actual one will be deleted(it's a strange choice...).
So Christian moved my PR to the new Repository but it's still now merged.
So IMHO, at this stage, I would:
1) apply this patch
2) wait for PR to be merged or for repository to be deleted
3) switch to the new repository keeping the local patch applied with 
point 1) or if it will be merged upstream we can remove local patch of
point 1)

This is my 2 cents.

Kind regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot