Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/boost: disable boost-locale for static only build
Date: Mon, 15 May 2017 21:56:09 +0200	[thread overview]
Message-ID: <f55f2318-2f79-83c1-71d8-4e0d27737cf8@gmail.com> (raw)
In-Reply-To: <CAGm1_ksMXXjviJAact4vDgnRJCrfvQUMxKU2Jytjn2rBwBU2qw@mail.gmail.com>

Hi Yegor,

Le 15/05/2017 ? 10:30, Yegor Yefremov a ?crit :
> Hi Romain,
> 
> On Mon, May 15, 2017 at 9:15 AM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>> Hello,
>>
>> On Sun, 14 May 2017 23:45:56 +0200, Romain Naour wrote:
>>
>>> diff --git a/package/boost/Config.in b/package/boost/Config.in
>>> index 9825c09..6ffa8f0 100644
>>> --- a/package/boost/Config.in
>>> +++ b/package/boost/Config.in
>>> @@ -98,8 +98,15 @@ config BR2_PACKAGE_BOOST_IOSTREAMS
>>>
>>>  config BR2_PACKAGE_BOOST_LOCALE
>>>       bool "boost-locale"
>>> +     # boost-locale build system try to link dynamically with icu
>>> +     # see <link>shared and <runtime-link>shared in locale/build/Jamfile.v2
>>> +     # Related to https://svn.boost.org/trac/boost/ticket/9685
>>> +     depends on !BR2_STATIC_LIBS
>>>       select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
>>
>> OK, but doesn't the problem occurs only when icu is enabled? Do we want
>> to prevent from using boost-locale in static linking situations in all
>> cases, or only when combined with icu?
>>
>> Perhaps we should keep it simple and do like you suggest, i.e make it
>> unavailable for all static linking configurations, regardless of icu
>> availability. I'm just trying to figure out the best/right approach
>> between yours and the one proposed by Yegor.
> 
> Have you also tested regex module? It seems to have the same
> structure/dependencies as locale module.

Yes, the boost-regex module was still selected when I disabled boost-locale and
rebuilt boost package (after a boost-dirclean).

Maybe I missed something, please share a defconfig if you're able to trigger the
issue with boost-regex :)

Best regards,
Romain

> 
> Yegor
> 

      reply	other threads:[~2017-05-15 19:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-14 21:45 [Buildroot] [PATCH] package/boost: disable boost-locale for static only build Romain Naour
2017-05-15  7:15 ` Thomas Petazzoni
2017-05-15  8:30   ` Yegor Yefremov
2017-05-15 19:56     ` Romain Naour [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f55f2318-2f79-83c1-71d8-4e0d27737cf8@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox