Re: [Buildroot] [PATCH v2] package/psmisc: bump to version 23.7

[Marcus Hoffmann via buildroot <buildroot@buildroot.org>]

Hi Shubham,

On 4/28/26 22:45, Shubham Chakraborty wrote:
> - Fix --disable-statx build option
> - fuser: Add stat() fallback, ignore EACCES errors
> - pstree: Fix assumption about root PID
> - killall: Output formatting fixes
> - Update gettext to 0.21
> 
> https://gitlab.com/psmisc/psmisc/-/tags/v23.7

As you are bumping the package from 23.5 -> 23.7, you should also 
include the changelog of the 23.6 release [1] in the commit description.

> 
> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> ---
>   package/psmisc/psmisc.hash | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/package/psmisc/psmisc.hash b/package/psmisc/psmisc.hash
> index 646c01b3c6..f16b95eee3 100644
> --- a/package/psmisc/psmisc.hash
> +++ b/package/psmisc/psmisc.hash
> @@ -1,3 +1,6 @@
>   # From https://sourceforge.net/projects/psmisc/files/psmisc/
> +md5  53eae841735189a896d614cba440eb10  psmisc-23.7.tar.xz
> +sha1  89046d35a8919def79200115c9cc78e91b98ad53  psmisc-23.7.tar.xz
> +# Locally computed:

This patch does not apply. I assume it is currently based on top of your 
v1, but that is not how you should send a v2 patch. Any new version 
should contain all the previous changes.

Also it's nice to include a changelog in the new revision for what 
changed in the new revision (below a --- mark, so it's visible in the 
email but doesn't get included in the commit that gets applied).

See section "22.5.5. Patch revision changelog" in the manual[2]

 > [...]

Could you send a v3 with these changes incorporated?

Best,
Marcus

[1] https://gitlab.com/psmisc/psmisc/-/tags/v23.6
[2] https://nightly.buildroot.org/manual.html#submitting-patches

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot