public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Francois Perrad <francois.perrad@gadz.org>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH v2 2/2] package/ficl: bump to version 3.05
Date: Mon, 09 Mar 2026 22:26:00 +0100	[thread overview]
Message-ID: <f729111f87eafb3bbc02cc86213f7c2a@free.fr> (raw)
In-Reply-To: <20260308150650.48948-3-francois.perrad@gadz.org>

Hi Francois,

Thanks for the update.

On 08/03/2026 16:06, Francois Perrad via buildroot wrote:
> - sources are now hosted on Github
> - ficl have its own LICENSE file
> - remove one upstreamed patch
> - support only static lib
> - requires C11
> ---
[...]
> diff --git a/package/ficl/ficl.mk b/package/ficl/ficl.mk
> index da9a9a33f..6ef94f11e 100644
> --- a/package/ficl/ficl.mk
> +++ b/package/ficl/ficl.mk
> @@ -4,55 +4,27 @@
>  #
>  
> ################################################################################
> 
> -FICL_VERSION = 303
> -FICL_VERSION_SO = 3.0.1
> +FICL_VERSION = 305

This new version does not resolve the issue on my side. See:
https://gitlab.com/jolivain/buildroot/-/pipelines/2374011153

Those build failures seems related to older uclibc. You might
need to do something like this:
https://gitlab.com/buildroot.org/buildroot/-/blob/2026.02/package/util-linux/util-linux.mk#L124

Also, your v2 also misses the "Signed-off-by:".

Did you considered my other comments in my last review?
https://lore.kernel.org/buildroot/907a398121ce011ac302cf4ff78de312@free.fr/
- squashing those two commits into a single one,
- updating to 3.06

You can test your patches with the command:

utils/test-pkg -a -p ficl

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-03-09 21:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08 15:06 [Buildroot] [PATCH v2 0/2] ficl Francois Perrad via buildroot
2026-03-08 15:06 ` [Buildroot] [PATCH v2 1/2] package/ficl: downgrade to version 3.03 Francois Perrad via buildroot
2026-03-08 15:06 ` [Buildroot] [PATCH v2 2/2] package/ficl: bump to version 3.05 Francois Perrad via buildroot
2026-03-09 21:26   ` Julien Olivain via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f729111f87eafb3bbc02cc86213f7c2a@free.fr \
    --to=buildroot@buildroot.org \
    --cc=buildroot@busybox.net \
    --cc=francois.perrad@gadz.org \
    --cc=ju.o@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox