From: Trent Piepho <trent.piepho@synapse.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3, 1/1] package/samba4: Do not force target python
Date: Mon, 6 Jan 2020 20:58:53 +0000 [thread overview]
Message-ID: <f9c453d2c255c9bf5eae3a95da77da2520441742.camel@synapse.com> (raw)
In-Reply-To: <20200103134341.1505177-1-fontaine.fabrice@gmail.com>
On Fri, 2020-01-03 at 14:43 +0100, Fabrice Fontaine wrote:
> Samba does not need python on the target for file server functionality.
> It does need it for the Active Directory Domain Controller feature,
> which is already configured in buildroot as optional and already depends
> on python3 since commit 4485a75859fbae99090b065ddd7c088a65571d37.
>
> An unnecessary target python greatly increases the size of the target
> filesystem. A somewhat minimal configuration with a samba server shunk
> from an 82 MB rootfs to 53 MB with this patch.
>
> Signed-off-by: Trent Piepho <trent.piepho@synapse.com>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v2 -> v3 (after review of Thomas Petazzoni):
> - Only drop select in Config.in
>
> Changes v1 -> v2 (after review of Thomas Petazzoni):
> - Rework patch due so it can be applied after commits
> fe033bdf534a7892ced72c11635d863afa92d1d2 and
> 4485a75859fbae99090b065ddd7c088a65571d37
Test v3 and it looks good to me. After commit fe033bd added the
disable-python logic, the samba4.mk part of my origina v1 isn't needed
anymore to get a working build.
next prev parent reply other threads:[~2020-01-06 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 13:43 [Buildroot] [PATCH v3, 1/1] package/samba4: Do not force target python Fabrice Fontaine
2020-01-06 20:58 ` Trent Piepho [this message]
2020-01-08 8:32 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9c453d2c255c9bf5eae3a95da77da2520441742.camel@synapse.com \
--to=trent.piepho@synapse.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox