Re: [Buildroot] [PATCH] package/eigen: bump to version 5.0.1

[Julien Olivain via buildroot <buildroot@buildroot.org>]

Hi Shubham,

Thanks for the patch.

On 04/04/2026 12:01, Shubham Chakraborty wrote:
> Update Eigen from 3.4.0 to 5.0.1.
> 
> Remove the downstream CMake patch because the BLAS, LAPACK and
> CMake package toggles are now provided upstream in 5.0.1.
> 
> Refresh the source and license hashes to match the new release and
> update the package license metadata to reflect the current upstream
> licensing files.
> 
> Add a gcc >= 5 dependency in Config.in because Eigen 5.x requires
> C++14 support.
> 
> Update the project homepage to the current upstream GitLab URL.
> 
> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
> ---
>  ...ptions-for-controlling-build-compone.patch | 88 -------------------
>  package/eigen/Config.in                       |  7 +-
>  package/eigen/eigen.hash                      | 11 ++-
>  package/eigen/eigen.mk                        |  6 +-
>  4 files changed, 12 insertions(+), 100 deletions(-)
>  delete mode 100644 
> package/eigen/0001-Adds-new-CMake-Options-for-controlling-build-compone.patch
> 
> diff --git 
> a/package/eigen/0001-Adds-new-CMake-Options-for-controlling-build-compone.patch 
> b/package/eigen/0001-Adds-new-CMake-Options-for-controlling-build-compone.patch
> deleted file mode 100644

If you are removing the patch here, you should remove the entry
in ".checkpackageignore". This is detected by the command:
"utils/docker-run make check-package" which report the error:

.checkpackageignore:311: ignored file 
package/eigen/0001-Adds-new-CMake-Options-for-controlling-build-compone.patch 
is missing

> index 737e7d39b7..0000000000
> --- 
> a/package/eigen/0001-Adds-new-CMake-Options-for-controlling-build-compone.patch
> +++ /dev/null
[...]
> diff --git a/package/eigen/Config.in b/package/eigen/Config.in
> index ef0a16f2f7..b1746da9e9 100644
> --- a/package/eigen/Config.in
> +++ b/package/eigen/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_EIGEN
>  	bool "eigen"
>  	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14

If you add a new dependency on gcc 5 here, it should be propagated
on all packages selecting eigen. You can have the list with the
command:

git grep 'select BR2_PACKAGE_EIGEN'

Which gives gtkiostream, opencv4-contrib and tensorflow-lite.
So this patch should add in the Config.in for those package the
new dependency:

depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # eigen

>  	help
>  	  Eigen is a C++ template library for linear algebra: vectors,
>  	  matrices, and related algorithms. It is versatile, fast,
> @@ -11,7 +12,7 @@ config BR2_PACKAGE_EIGEN
>  	  right away. There is no binary to link to. Eigen is a pure
>  	  template library defined in the headers.
> 
> -	  http://eigen.tuxfamily.org/
> +	  https://gitlab.com/libeigen/eigen
> 
> -comment "eigen needs a toolchain w/ C++"
> -	depends on !BR2_INSTALL_LIBSTDCPP
> +comment "eigen needs a toolchain w/ C++, gcc >= 5"
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_5

Could you send an updated pactch addressing those issue, please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot