Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Edwards <grant.b.edwards@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] Customize package makefile seems broken
Date: Thu, 7 Jan 2010 21:22:42 +0000 (UTC)	[thread overview]
Message-ID: <hi5jb1$cra$1@ger.gmane.org> (raw)

I'm attempting to use the "customize" package to get
libgcc_s.so files into my target filesystem, and it doesn't
seem to work.  I put files into the package like so:

   $ tree customize
   customize
   |-- Config.in
   |-- customize.mk
   `-- source
       |-- asdf
       `-- lib
           |-- foobar
           |-- libgcc.a
           |-- libgcc_eh.a
           |-- libgcc_s.so
           `-- libgcc_s.so.1
        
But what ends up on my target filesystem is

  /asdf
  /lib/lib/libgcc_s.so
  /lib/lib/libgcc_s.so.1
  /lib/lib/foobar

The two .a files vanish, and the other files that I expect to
find in /lib end up in /lib/lib.  I haven't figured out why two
of the 6 files aren't getting copied, but the mislocation
appears to be due to a bug in customize.mk:

     1	#############################################################
     2	#
     3	# Any custom stuff you feel like doing....
     4	#
     5	#############################################################
     6	CUST_DIR:=package/customize/source
     7	
     8	$(BUILD_DIR)/.customize:
     9		rm -f $(BUILD_DIR)/series
    10		(cd $(CUST_DIR); \
    11		 /bin/ls -d * > $(BUILD_DIR)/series || \
    12		 touch $(BUILD_DIR)/series )
    13		for f in `cat $(BUILD_DIR)/series`; do \
    14			cp -af $(CUST_DIR)/$$f $(TARGET_DIR)/$$f; \
    15		done
    16		rm -f $(BUILD_DIR)/series
    17		touch $@

Line 14 doesn't work right if there are any pre-existing
directories in the target directory.  In my case it ends up
doing:

   cp -af package/custom/source/lib output/target/lib

That results in files ending up in /lib/lib instead of /lib

Shouldn't line 14 specify the bare target_dir (and not
specify a target filename)?  Copy a file will still work the
same (since the destination is known to be a directory), and
now copying a directory will work when it didn't used to:

    14                  cp -af $(CUST_DIR)/$$f $(TARGET_DIR)/; \

Or an I not understanding how the customize package is supposed
to be used?    

-- 
Grant Edwards                   grante             Yow! I wish I was a
                                  at               sex-starved manicurist
                               visi.com            found dead in the Bronx!!

             reply	other threads:[~2010-01-07 21:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-07 21:22 Grant Edwards [this message]
2010-01-08  7:59 ` [Buildroot] Customize package makefile seems broken Thomas Petazzoni
2010-01-08 15:38   ` Grant Edwards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='hi5jb1$cra$1@ger.gmane.org' \
    --to=grant.b.edwards@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox