Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bernd Kuhls <bernd.kuhls@t-online.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/sngrep: needs ncurses form/menu/panel libraries
Date: Sun, 29 Jan 2017 18:12:22 +0100	[thread overview]
Message-ID: <mck1mdxd4l.ln2@ID-313208.user.individual.net> (raw)
In-Reply-To: 20170129143037.130cb2e3@free-electrons.com

Am Sun, 29 Jan 2017 14:30:37 +0100 schrieb Thomas Petazzoni:

> Hello,
> 
> On Sat, 28 Jan 2017 17:57:45 +0100, Bernd Kuhls wrote:
>> Please see configure checks for the various ncurses libraries:
>> 
>> form https://github.com/irontec/sngrep/blob/master/configure.ac#L90
>> 
>> menu https://github.com/irontec/sngrep/blob/master/configure.ac#L94
>> 
>> panel https://github.com/irontec/sngrep/blob/master/configure.ac#L86
>> 
>> Fixes
>> http://autobuild.buildroot.net/
results/3a4/3a4751fcc6184d562df80d1cd6bf53e788e21392/
>> 
>> Signed-off-by: Bernd Kuhls
>> <bernd.kuhls@t-online.de>
> 
> I don't yet understand those build failures. Indeed, locally, I'm able
> to build the following defconfig, which has form/menu/panel disabled,
> but sngrep builds fine:

Hi,

you are right, your defconfig works because BR2_PACKAGE_NCURSES_WCHAR is 
disabled. All autobuilder failures occur with BR2_PACKAGE_NCURSES_WCHAR=y.

sngrep.mk contains --disable-unicode due to problems while detecting 
ncurses.h, see commit log for details:
https://git.buildroot.net/buildroot/commit/package/sngrep?
id=bf09290977a5b43f53479dd52777fde0bb20bf5a

Using --disable-unicode forces the configure script to check for the 
ncurses libs without "w" in their name only:
https://github.com/irontec/sngrep/blob/master/configure.ac#L77, but they 
are not present with BR2_PACKAGE_NCURSES_WCHAR=y leading to the configure 
error seen by the autobuilders.

Quick fix: depends on !BR2_PACKAGE_NCURSES_WCHAR

Regards, Bernd

      reply	other threads:[~2017-01-29 17:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-28 16:57 [Buildroot] [PATCH 1/1] package/sngrep: needs ncurses form/menu/panel libraries Bernd Kuhls
2017-01-29 13:30 ` Thomas Petazzoni
2017-01-29 17:12   ` Bernd Kuhls [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mck1mdxd4l.ln2@ID-313208.user.individual.net \
    --to=bernd.kuhls@t-online.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox