* [Buildroot] [PATCH] pulseaudio: needs threads
From: Peter Korsgaard @ 2012-12-23 7:30 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1356177979-8784-1-git-send-email-gustavo@zacarias.com.ar>
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
Gustavo> Fixes:
Gustavo> http://autobuild.buildroot.net/results/4d6a5793e475683fbc58ccaf03cf7816233a5052/
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply
* [Buildroot] [git commit] pulseaudio: needs threads
From: Peter Korsgaard @ 2012-12-23 7:27 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=1b603449fd0dcbaf22188e1f2e149da115ff2ea1
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Fixes:
http://autobuild.buildroot.net/results/4d6a5793e475683fbc58ccaf03cf7816233a5052/
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
package/multimedia/gst-plugins-good/Config.in | 1 +
package/multimedia/mpd/Config.in | 1 +
package/multimedia/pulseaudio/Config.in | 5 +++--
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/package/multimedia/gst-plugins-good/Config.in b/package/multimedia/gst-plugins-good/Config.in
index 33ecb5c..b5006e6 100644
--- a/package/multimedia/gst-plugins-good/Config.in
+++ b/package/multimedia/gst-plugins-good/Config.in
@@ -193,6 +193,7 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_OSS4
bool "oss4 (Open Sound System 4)"
config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PULSE
+ depends on BR2_TOOLCHAIN_HAS_THREADS # pulseaudio
select BR2_PACKAGE_PULSEAUDIO
bool "pulseaudio"
diff --git a/package/multimedia/mpd/Config.in b/package/multimedia/mpd/Config.in
index 5d08182..2e44741 100644
--- a/package/multimedia/mpd/Config.in
+++ b/package/multimedia/mpd/Config.in
@@ -40,6 +40,7 @@ config BR2_PACKAGE_MPD_AUDIOFILE
config BR2_PACKAGE_MPD_PULSEAUDIO
bool "pulseaudio"
+ depends on BR2_TOOLCHAIN_HAS_THREADS # pulseaudio
select BR2_PACKAGE_PULSEAUDIO
help
Enable pulseaudio output support.
diff --git a/package/multimedia/pulseaudio/Config.in b/package/multimedia/pulseaudio/Config.in
index 6c767bb..eeb8b5a 100644
--- a/package/multimedia/pulseaudio/Config.in
+++ b/package/multimedia/pulseaudio/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_PULSEAUDIO
bool "pulseaudio"
depends on BR2_USE_WCHAR
+ depends on BR2_TOOLCHAIN_HAS_THREADS
select BR2_PACKAGE_LIBTOOL
select BR2_PACKAGE_JSON_C
select BR2_PACKAGE_LIBSNDFILE
@@ -17,5 +18,5 @@ config BR2_PACKAGE_PULSEAUDIO
http://pulseaudio.org
-comment "pulseaudio requires a toolchain with WCHAR support"
- depends on !BR2_USE_WCHAR
+comment "pulseaudio requires a toolchain with WCHAR and threads support"
+ depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
^ permalink raw reply related
* [Buildroot] [PATCH] new package: p7zip
From: Stefan Fröberg @ 2012-12-23 1:05 UTC (permalink / raw)
To: buildroot
Signed-off-by: Stefan Fr?berg <stefan.froberg@petroprogram.com>
---
package/Config.in | 1 +
package/p7zip/7z | 3 +
package/p7zip/7za | 3 +
package/p7zip/Config.in | 9 +++
package/p7zip/p7zip-9.20.1-QA.patch | 12 ++++
package/p7zip/p7zip-9.20.1-execstack.patch | 24 ++++++++
package/p7zip/p7zip.mk | 81 ++++++++++++++++++++++++++++
7 files changed, 133 insertions(+), 0 deletions(-)
create mode 100755 package/p7zip/7z
create mode 100755 package/p7zip/7za
create mode 100644 package/p7zip/Config.in
create mode 100644 package/p7zip/p7zip-9.20.1-QA.patch
create mode 100644 package/p7zip/p7zip-9.20.1-execstack.patch
create mode 100644 package/p7zip/p7zip.mk
diff --git a/package/Config.in b/package/Config.in
index 47a281e..e6487d4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -13,6 +13,7 @@ source "package/gzip/Config.in"
endif
source "package/lzop/Config.in"
source "package/lzma/Config.in"
+source "package/p7zip/Config.in"
source "package/xz/Config.in"
endmenu
diff --git a/package/p7zip/7z b/package/p7zip/7z
new file mode 100755
index 0000000..c04e07f
--- /dev/null
+++ b/package/p7zip/7z
@@ -0,0 +1,3 @@
+#!/bin/sh
+"/usr/lib/p7zip/7z" "$@"
+
diff --git a/package/p7zip/7za b/package/p7zip/7za
new file mode 100755
index 0000000..1d7374e
--- /dev/null
+++ b/package/p7zip/7za
@@ -0,0 +1,3 @@
+#!/bin/sh
+"/usr/lib/p7zip/7za" "$@"
+
diff --git a/package/p7zip/Config.in b/package/p7zip/Config.in
new file mode 100644
index 0000000..689feb4
--- /dev/null
+++ b/package/p7zip/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_P7ZIP
+ bool "p7zip"
+ help
+ p7zip is a quick port of 7.exe and 7za.exe
+ (command line version of 7-zip, see http://www.7-zip.org) for Unix.
+
+ 7-Zip is a file archiver with highest compression ratio.
+
+ http://sourceforge.net/projects/p7zip
diff --git a/package/p7zip/p7zip-9.20.1-QA.patch b/package/p7zip/p7zip-9.20.1-QA.patch
new file mode 100644
index 0000000..b7c121b
--- /dev/null
+++ b/package/p7zip/p7zip-9.20.1-QA.patch
@@ -0,0 +1,12 @@
+diff -Naur p7zip_9.20.1.org/CPP/7zip/Archive/NtfsHandler.cpp p7zip_9.20.1/CPP/7zip/Archive/NtfsHandler.cpp
+--- p7zip_9.20.1.org/CPP/7zip/Archive/NtfsHandler.cpp 2012-09-06 01:20:35.220955438 +0300
++++ p7zip_9.20.1/CPP/7zip/Archive/NtfsHandler.cpp 2012-09-06 01:21:35.361955043 +0300
+@@ -1280,7 +1280,7 @@
+ if (recSizeLog < Header.SectorSizeLog)
+ return false;
+ numSectorsInRec = 1 << (recSizeLog - Header.SectorSizeLog);
+- if (!mftRec.Parse(ByteBuf, Header.SectorSizeLog, numSectorsInRec, NULL, 0))
++ if (!mftRec.Parse(ByteBuf, Header.SectorSizeLog, numSectorsInRec, 0, NULL))
+ return S_FALSE;
+ if (!mftRec.IsFILE())
+ return S_FALSE;
diff --git a/package/p7zip/p7zip-9.20.1-execstack.patch b/package/p7zip/p7zip-9.20.1-execstack.patch
new file mode 100644
index 0000000..1fdff48
--- /dev/null
+++ b/package/p7zip/p7zip-9.20.1-execstack.patch
@@ -0,0 +1,24 @@
+diff -Naupr p7zip_9.20.1.orig/Asm/x64/7zCrcT8U.asm p7zip_9.20.1/Asm/x64/7zCrcT8U.asm
+--- p7zip_9.20.1.orig/Asm/x64/7zCrcT8U.asm 2008-08-14 11:18:07.000000000 +0200
++++ p7zip_9.20.1/Asm/x64/7zCrcT8U.asm 2011-07-26 17:43:57.727910278 +0200
+@@ -101,3 +101,8 @@ _CrcUpdateT8:
+ ret
+
+ end
++
++%ifidn __OUTPUT_FORMAT__,elf
++section .note.GNU-stack noalloc noexec nowrite progbits
++%endif
++
+diff -Naupr p7zip_9.20.1.orig/Asm/x86/7zCrcT8U.asm p7zip_9.20.1/Asm/x86/7zCrcT8U.asm
+--- p7zip_9.20.1.orig/Asm/x86/7zCrcT8U.asm 2009-07-14 12:44:15.000000000 +0200
++++ p7zip_9.20.1/Asm/x86/7zCrcT8U.asm 2011-07-26 17:44:23.938864508 +0200
+@@ -99,3 +99,8 @@ _CrcUpdateT8:
+
+
+ ; end
++
++%ifidn __OUTPUT_FORMAT__,elf
++section .note.GNU-stack noalloc noexec nowrite progbits
++%endif
++
diff --git a/package/p7zip/p7zip.mk b/package/p7zip/p7zip.mk
new file mode 100644
index 0000000..efc0adc
--- /dev/null
+++ b/package/p7zip/p7zip.mk
@@ -0,0 +1,81 @@
+############################################
+#
+# p7zip
+#
+# Note: I just constructed this (mostly) from
+# Gentoo ebuild file of p7zip.
+#
+# Original can be found from here:
+# http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-arch/p7zip/p7zip-9.20.1-r2.ebuild
+#
+############################################
+P7ZIP_VERSION = 9.20.1
+P7ZIP_SOURCE = p7zip_$(P7ZIP_VERSION)_src_all.tar.bz2
+P7ZIP_SITE = http://downloads.sourceforge.net/project/p7zip/p7zip/$(P7ZIP_VERSION)
+P7ZIP_DEPENDENCIES = host-yasm
+# What UnRAR license basically means here is that as long
+# as you are not using UnRAR source code to reverse engineer
+# the RAR *compression* algorithm, which is proprietary and owned by Alexander L. Roshal,
+# then everything should be fine, in this case (LGPLv2.1+).
+P7ZIP_LICENSE = LGPLv2.1+ UnRAR
+
+# Is this the right way to do ?
+# Basically this should mean:
+# "If we have 32-bit Intel/AMD machine, then use 32-bit asm optimized makefile for building"
+# "If we have 64-bit Intel/AMD machine, then use 64-bit asm optimized makefile for building"
+# "If we have anything else than Intel or AMD CPU, then use the generic makefile for building"
+# (those sed lines will just ensure that we are using host-yasm assembler for 32-bit and 64-bit building)
+ifeq ($(BR2_i386),y)
+define P7ZIP_POST_CONFIGURE_FIXUP
+ (cd $(@D); \
+ sed -i -e "/^ASM=/s:nasm:$(HOST_DIR)/usr/bin/yasm:" makefile.linux_x86_asm_gcc_4.X ;\
+ cp makefile.linux_x86_asm_gcc_4.X makefile.machine)
+endef
+else if ($(BR2_x86_64),y)
+define P7ZIP_POST_CONFIGURE_FIXUP
+ (cd $(@D); \
+ sed -i -e "/^ASM=/s:yasm:$(HOST_DIR)/usr/bin/yasm:" makefile.linux_amd64_asm ;\
+ cp makefile.linux_amd64_asm makefile.machine)
+endef
+else
+define P7ZIP_POST_CONFIGURE_FIXUP
+ (cd $(@D); \
+ cp makefile.linux_any_cpu_gcc_4.X makefile.machine)
+endef
+endif
+
+P7ZIP_POST_CONFIGURE_HOOKS += P7ZIP_POST_CONFIGURE_FIXUP
+
+define P7ZIP_CONFIGURE_CMDS
+ # Do some PCH disabling and makefile fixup
+ (cd $(@D); \
+ sed "s:PRE_COMPILED_HEADER=StdAfx.h.gch:PRE_COMPILED_HEADER=:g" -i makefile.* ;\
+ sed -e 's:-m32 ::g' -e 's:-m64 ::g' -e 's:-O::g' -e 's:-pipe::g' \
+ -e "/^CC/s:\$$(ALLFLAGS):$${CFLAGS} \$$(ALLFLAGS):g" \
+ -e "/^CXX/s:\$$(ALLFLAGS):$${CXXFLAGS} \$$(ALLFLAGS):g" -i makefile* ;\
+ sed -i -e "/^CXX=/s:g++:$(TARGET_CXX):" \
+ -e "/^CC=/s:gcc:$(TARGET_CC):" \
+ -e '/ALLFLAGS/s:-s ::' makefile* )
+endef
+
+define P7ZIP_BUILD_CMDS
+ $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) all2
+endef
+
+define P7ZIP_INSTALL_TARGET_CMDS
+ mkdir -p $(TARGET_DIR)/usr/lib/p7zip
+ cp -r $(@D)/bin/* $(TARGET_DIR)/usr/lib/p7zip/
+
+ # According to Gentoo folks, we can't just use symlinks
+ # but have to invoke p7zip programs (7z & 7za) with full path (/usr/lib/p7zip)
+ # when using them (which is really annoying)
+
+ # That's why we use more helpful wrapper scripts instead.
+ cp package/p7zip/7z $(TARGET_DIR)/usr/bin/
+ cp package/p7zip/7za $(TARGET_DIR)/usr/bin/
+endef
+
+$(eval $(generic-package))
+$(eval $(host-generic-package))
+
+
--
1.7.7.6
^ permalink raw reply related
* [Buildroot] [PATCH] new package: proxychains
From: Stefan Fröberg @ 2012-12-23 0:20 UTC (permalink / raw)
To: buildroot
Signed-off-by: Stefan Fr?berg <stefan.froberg@petroprogram.com>
---
package/Config.in | 1 +
package/proxychains/Config.in | 7 +++++++
package/proxychains/proxychains.mk | 10 ++++++++++
3 files changed, 18 insertions(+), 0 deletions(-)
create mode 100644 package/proxychains/Config.in
create mode 100644 package/proxychains/proxychains.mk
diff --git a/package/Config.in b/package/Config.in
index 562bfda..47a281e 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -656,6 +656,7 @@ source "package/portmap/Config.in"
source "package/pppd/Config.in"
source "package/pptp-linux/Config.in"
source "package/proftpd/Config.in"
+source "package/proxychains/Config.in"
source "package/quagga/Config.in"
source "package/radvd/Config.in"
source "package/rp-pppoe/Config.in"
diff --git a/package/proxychains/Config.in b/package/proxychains/Config.in
new file mode 100644
index 0000000..332aa3b
--- /dev/null
+++ b/package/proxychains/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_PROXYCHAINS
+ bool "proxychains"
+ help
+ force any tcp connections to flow through a proxy (or proxy chain)
+
+ http://proxychains.sourceforge.net
+
diff --git a/package/proxychains/proxychains.mk b/package/proxychains/proxychains.mk
new file mode 100644
index 0000000..7c4500d
--- /dev/null
+++ b/package/proxychains/proxychains.mk
@@ -0,0 +1,10 @@
+#############################################################
+#
+# ProxyChains
+#
+#############################################################
+PROXYCHAINS_VERSION = 3.1
+PROXYCHAINS_SOURCE = proxychains-$(PROXYCHAINS_VERSION).tar.gz
+PROXYCHAINS_SITE = http://downloads.sourceforge.net/project/proxychains/proxychains/version%20$(PROXYCHAINS_VERSION)
+
+$(eval $(autotools-package))
--
1.7.7.6
^ permalink raw reply related
* [Buildroot] [PATCH] rxvt-unicode: new package
From: Stefan Fröberg @ 2012-12-23 0:06 UTC (permalink / raw)
To: buildroot
Signed-off-by: Stefan Fr?berg <stefan.froberg@petroprogram.com>
---
package/Config.in | 1 +
package/rxvt-unicode/Config.in | 9 +++++++++
.../rxvt-unicode/rxvt-unicode-9.15-terminfo.patch | 12 ++++++++++++
package/rxvt-unicode/rxvt-unicode.mk | 12 ++++++++++++
4 files changed, 34 insertions(+), 0 deletions(-)
create mode 100644 package/rxvt-unicode/Config.in
create mode 100644 package/rxvt-unicode/rxvt-unicode-9.15-terminfo.patch
create mode 100644 package/rxvt-unicode/rxvt-unicode.mk
diff --git a/package/Config.in b/package/Config.in
index d5e94db..562bfda 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -169,6 +169,7 @@ source "package/leafpad/Config.in"
source "package/midori/Config.in"
source "package/pcmanfm/Config.in"
source "package/rdesktop/Config.in"
+source "package/rxvt-unicode/Config.in"
source "package/sylpheed/Config.in"
source "package/synergy/Config.in"
source "package/torsmo/Config.in"
diff --git a/package/rxvt-unicode/Config.in b/package/rxvt-unicode/Config.in
new file mode 100644
index 0000000..3eab31d
--- /dev/null
+++ b/package/rxvt-unicode/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_RXVT_UNICODE
+ bool "rxvt-unicode"
+ select BR2_PACKAGE_FONTCONFIG
+ select BR2_PACKAGE_XLIB_LIBX11
+ select BR2_PACKAGE_XLIB_LIBXRENDER
+ help
+ rxvt clone with xft and unicode support
+
+ http://software.schmorp.de/pkg/rxvt-unicode
diff --git a/package/rxvt-unicode/rxvt-unicode-9.15-terminfo.patch b/package/rxvt-unicode/rxvt-unicode-9.15-terminfo.patch
new file mode 100644
index 0000000..910ce76
--- /dev/null
+++ b/package/rxvt-unicode/rxvt-unicode-9.15-terminfo.patch
@@ -0,0 +1,12 @@
+diff -Naur rxvt-unicode-9.15.org/doc/Makefile.in rxvt-unicode-9.15/doc/Makefile.in
+--- rxvt-unicode-9.15.org/doc/Makefile.in 2012-04-11 23:57:47.105465883 +0300
++++ rxvt-unicode-9.15/doc/Makefile.in 2012-04-12 00:02:13.848367530 +0300
+@@ -102,7 +102,7 @@
+ $(INSTALL_DATA) rxvt.7.man $(DESTDIR)$(man7dir)/$(RXVTNAME).$(man7ext)
+ @IF_PERL@ $(INSTALL) -d $(DESTDIR)$(man3dir)
+ @IF_PERL@ $(INSTALL_DATA) rxvtperl.3.man $(DESTDIR)$(man3dir)/$(RXVTNAME)perl.$(man3ext)
+- @TIC@ $(srcdir)/etc/rxvt-unicode.terminfo
++ @TIC@ $(srcdir)/etc/rxvt-unicode.terminfo -o $(DESTDIR)/usr/share/terminfo
+
+ distdepend: alldoc
+
diff --git a/package/rxvt-unicode/rxvt-unicode.mk b/package/rxvt-unicode/rxvt-unicode.mk
new file mode 100644
index 0000000..009b40e
--- /dev/null
+++ b/package/rxvt-unicode/rxvt-unicode.mk
@@ -0,0 +1,12 @@
+#############################################################
+#
+# rxvt-unicode
+#
+#############################################################
+RXVT_UNICODE_VERSION = 9.15
+RXVT_UNICODE_SOURCE = rxvt-unicode-$(RXVT_UNICODE_VERSION).tar.bz2
+RXVT_UNICODE_SITE = http://dist.schmorp.de/rxvt-unicode
+RXVT_UNICODE_DEPENDENCIES = fontconfig ncurses xlib_libX11 xlib_libXrender
+RXVT_UNICODE_CONF_OPT += --enable-everything --disable-perl --with-x --with-terminfo=/usr/share/terminfo
+
+$(eval $(autotools-package))
--
1.7.7.6
^ permalink raw reply related
* [Buildroot] [PATCH] new package: libpciaccess
From: Stefan Fröberg @ 2012-12-22 23:51 UTC (permalink / raw)
To: buildroot
Signed-off-by: Stefan Fr?berg <stefan.froberg@petroprogram.com>
---
package/Config.in | 1 +
package/libpciaccess/Config.in | 6 ++++++
package/libpciaccess/libpciaccess.mk | 12 ++++++++++++
3 files changed, 19 insertions(+), 0 deletions(-)
create mode 100644 package/libpciaccess/Config.in
create mode 100644 package/libpciaccess/libpciaccess.mk
diff --git a/package/Config.in b/package/Config.in
index 66445ff..d5e94db 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -431,6 +431,7 @@ source "package/libhid/Config.in"
source "package/libiqrf/Config.in"
source "package/libnfc/Config.in"
source "package/libnfc-llcp/Config.in"
+source "package/libpciaccess/Config.in"
source "package/libusb/Config.in"
source "package/libusb-compat/Config.in"
source "package/libv4l/Config.in"
diff --git a/package/libpciaccess/Config.in b/package/libpciaccess/Config.in
new file mode 100644
index 0000000..ce5cbfc
--- /dev/null
+++ b/package/libpciaccess/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBPCIACCESS
+ bool "libpciaccess"
+ help
+ Library providing generic access to the PCI bus and devices
+
+ http://cgit.freedesktop.org/xorg/lib/libpciaccess
diff --git a/package/libpciaccess/libpciaccess.mk b/package/libpciaccess/libpciaccess.mk
new file mode 100644
index 0000000..901c058
--- /dev/null
+++ b/package/libpciaccess/libpciaccess.mk
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libpciaccess
+#
+#############################################################
+LIBPCIACCESS_VERSION = 0.13.1
+LIBPCIACCESS_SOURCE = libpciaccess-$(LIBPCIACCESS_VERSION).tar.gz
+LIBPCIACCESS_SITE = http://cgit.freedesktop.org/xorg/lib/libpciaccess/snapshot
+LIBPCIACCESS_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
+
--
1.7.7.6
^ permalink raw reply related
* [Buildroot] [PATCH 2/6] polkit: new package
From: Thomas Petazzoni @ 2012-12-22 23:27 UTC (permalink / raw)
To: buildroot
In-Reply-To: <CAAfyv37M7Ogi4bhv4Qoxf0-0xVHVGP6sjL+J66R2xJ8BTQNoqQ@mail.gmail.com>
Dear Belisko Marek,
On Sat, 22 Dec 2012 22:54:03 +0100, Belisko Marek wrote:
> >> +POLKIT_INSTALL_STAGING = YES
> >
> > I don't remember, does polkit installs some libraries or .pc files, or
> > something that justify its installation in staging ?
> Yes. In staging there are added 3 libraries with polkit-agent-1.pc
> polkit-backend-1.pc polkit-gobject-1.pc files.
Ok, thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply
* [Buildroot] XBMC
From: Thomas Petazzoni @ 2012-12-22 23:26 UTC (permalink / raw)
To: buildroot
In-Reply-To: <CAGduivzZU=-GOQzAj4keyBVVMZ=9zuXaHX0wD68X7VSpB-c1aQ@mail.gmail.com>
Dear Maxime Hadjinlian,
On Sat, 22 Dec 2012 00:58:49 +0100, Maxime Hadjinlian wrote:
> I wanted to add XBMC to buildroot, but since it's a pretty big
> application with a lot of dependency, I have created a separated tree
> at github :
> https://github.com/maximeh/buildroot
>
> I would like to know if it would be of any interest to upstream this
> before sending all theses patches for review ?
It is indeed of interest to have something such as XBMC, I'd say. Of
course, it'd be even better if you could maintain the package from time
to time.
Here is a preliminary review of the patches that you have posted on
Github for XMBC. A more detailed review will be needed once you send
the patches on the list (doing review without being able to reply to
patches is annoying). Do not hesitate to send the full patch set, even
if it is quite big. I will do the review patch by patch, below.
rpi-userland
============
The package requires libcofi, so the patch should be *after* the patch
introducing libcofi in the patch set.
The help text would need a bit of love.
We don't like packages that will pull a random version of the upstream
software, so RPI_USERLAND_VERSION = master isn't good. Use either a
tag (better) or a commit ID as the version.
RPI_USERLANG_INSTALL_TARGET = YES is not needed, this is the default.
I'm not sure it's really worth the effort to clean up the staging
directory from unneeded stuff.
The rmdir -p $(TARGET_DIR_DIR)/etc/init.d || true could be replaced by
a rmdir -p --ignore-fail-on-non-empty, and TARGET_DIR_DIR should be
replaced by TARGET_DIR.
Instead of adding /opt/vc/lib in /etc/ld.so.conf, isn't it possible to
install the libraries in the right directory /usr/lib ?
Also, there have been some patches sent some time ago to add support
for the Rasberry-Pi. I don't remember if rpi-userland was part of
them, but maybe you should have a look at these patches and see how
they interact with your patch set. Another solution is to split the
problems: do one patch set adding XMBC only, and then another patch
set adding the Rasberry-Pi specific bits.
afpfs-ng
========
There is a crazy number of patches here, and none of them have a
description. Do we need all those patches? Have they been merged
upstream so that we can hope to reduce the number of patches in the
future?
AFPFS_NG_INSTALL_TARGET = YES is useless.
The += when defining the DEPENDENCIES should be simply a =.
Passing ac_cv_func_malloc_0_nonnull=yes it not needed, it is already
done by default by the autotools infrastructure. See the definition of
TARGET_CONFIGURE_ARGS in package/Makefile.in.
The Config.in file help text should be wrapped. The URL of the
upstream project should be added. And if the package actually requires
readline, then a 'select BR2_PACKAGE_READLINE' is needed here.
Minor nit: in the commit title, we don't usually put a space after the
package name. So it should be "afpfs-ng: new package" rather than
"afpfs-ng : new package".
fridibi
=======
Wrap the help text in Config.in.
Remove FRIDIBI_INSTALL_TARGET = YES
Get rid of FRIDIBI_SOURCE definition, this is the default value.
jasper
======
Does this package really depends on libjpeg ? The Config.in has a
"depends on", but the .mk file has no dependency.
Remove JASPER_INSTALL_TARGET = YES.
libass
======
I am not sure this package should be listed in "Text and terminal
handling". Maybe in Libraries -> Multimedia ?
Don't use "depends on", but use "select" for freetype and fontconfig.
Since this package uses libenca, the patch adding libenca should be
before the patch adding libass.
Please wrap the help text in Config.in.
LIBASS_SOURCE and LIBASS_INSTALL_TARGET should be removed, they are
the default value.
LIBASS_DEPENDENCIES does not mention freetype and fontconfig. Are
those needed dependencies or not? Also use = instead of += here.
libbluray
=========
Should go in Libraries -> Multimedia, not directly Multimedia, and so
the package should be in package/libbluray/.
Having _AUTORECONF = YES for a package where the source is taken from
a tarball and for which no patch is applied is unusual. Add a comment
explaining why AUTORECONF=YES is needed, or if it's not needed, remove
it.
Remove _INSTALL_TARGET=YES
libcdio
=======
Use $(BR2_GNU_MIRROR) for the download URL.
LIBCDIO_SOURCE is unneeded, this value is the default. Ditto for
LIBCDIO_INSTALL_TARGET.
libcec
======
This package depends on the lockdev package, but the lockdev package
is added in a later patch. The lockdev patch should be before the
libcec patch.
Please improve the help text with a better description of what this
library is.
Use tab for indentation in Config.in.
The BR2_PACKAGE_LIBCEC_RBP short text should probably be "Rasberry-Pi
support" or something like that.
The LIBCEC_VERSION should not be master, but a tag or a commit ID, so
everybody builds a similar known-working version.
_INSTALL_TARGET is not needed.
Maybe add a comment explaining why -Wno-psabi is needed.
Properly re-indent the --with-rpi-include-path and
--with-rpi-lib-path lines.
Missing newline before $(eval $(autotools-package)).
libcofi
=======
Shouldn't go in Miscellaneous, but in Libraries -> Other, or Libraries
-> Hardware Handling.
Please rewrap the help text in Config.in, and add upstream URL.
Please use a tag or commit ID instead of "master" as the version.
No need to define LIBCOFI_MAKE_OPT += -j1, just use $(MAKE1) instead
of $(MAKE) insthe build and install steps.
If you have _INSTALL_STAGING = YES, then you *must* have a
LIBCOFI_INSTALL_STAGING_CMDS. With the current package, I really don't
see who can link against libcofi: it doesn't get installed in staging,
which prevents the cross-compiler from using this library.
I haven't had a look at this package, but I guess it might be
architecture-specific, so please add a "depends on BR2_arm" if
necessary.
libenca
=======
A description of the patches is needed. Also, it would be better to
patch Makefile.am and configure.in (or configure.ac) and do a
LIBENCA_AUTORECONF = YES. And even better: make a proper change to
disable the compilation of tools, so that we can submit it upstream,
with the hope of getting rid of the patches in the long term.
Are you sure about ac_cv_file__dev_arandom=yes and
ac_cv_file__dev_srandom=yes ? I am not sure we have /dev/arandom and
/dev/srandom in our default installation (I'm not even sure what those
devices are).
Use $(@D) instead of $(LIBENCA_DIR) in the LIBENCA_MAKE_FIX. Also,
LIBENCA_MAKE_FIX could be named LIBENCA_BUILD_HOST_TOOL instead.
Add an empty newline before the $(eval $(autotools-package)) line.
libmodplug
==========
In Config.in, add a comment that explains why libmodplug is not
visible when the C++ support is not available in the toolchain:
comment "libmodplug requires C++ support in toolchain"
depends on !BR2_INSTALL_LIBSTDCPP
LIBMODPLUG_SOURCE is not needed, this is the default value.
libnfs
======
Add spaces around the = in the LIBNFS_MAKE definition.
Use $(@D) instead of $(LIBNFS_DIR) in LIBNFS_BOOTSTRAP. I guess the
./bootstrap script uses autoconf/automake/libtool, so you should
probably depend on host-autoconf, host-automake and host-libtool. Or
better, did you try just adding LIBNFS_AUTORECONF = YES, and remove
the LIBNFS_BOOTSTRAP hook? It might work (or not, depending on what
the ./bootstrap script does).
libplist
========
Please add a description for the patch. Also, are you sure it is
really needed? Maybe we can pass a CMake argument to make sure that
SWIG is not found, or something like that.
In the Config.in, please wrap the help text.
The depends on BR2_PACKAGE_LIBXML2 should be a select.
LIBPLIST_SOURCE is the default value, please
remove. LIBPLIST_INSTALL_TARGET = YES is not needed.
Please add spaces around = signs.
librtmp
=======
I am wondering whether it should go in Libraries -> Graphics as you
did, or in Libraries -> Networking.
Tabs for indentation in Config.in. Please wrap the help text. Please
add the upstream URL.
Description + Signed-off-by needed in the patch. Is this patch part of
upstream? Do we have a chance of getting rid of it some day?
Defining a tarball-based LIBRTMP_SOURCE sounds strange when the
SITE_METHOD is git, and SITE points to a Git repository.
If you depend on OpenSSL, then the Config.in should select it.
Use $(TARGET_CONFIGURE_OPTS) instead of passing CC, LD, AR manually in
the BUILD_CMDS.
I'm pretty sure you could use "make install" for the
INSTALL_TARGET_CMDS. Just have a look at what the package installs. If
the only thing that the package installs are libraries in
target/usr/lib, headers in target/usr/include, and pkg-config stuff in
target/usr/lib/pkgconfig, then please use "make install": Buildroot
will automatically clean up what is not needed on the target.
libshairport
============
PLease replace LIBSHAIRPORT by libshairport in the commit log.
Wrap the help text in Config.in, and add the upstream project URL.
Add a description + Signed-off-by line in the patches and if possible
comment on the upstream status of those patches.
No need for _SOURCE and _INSTALL_TARGET variables.
Use = instead of += in _DEPENDENCIES.
If you depend on openssl, please add a select BR2_PACKAGE_OPENSSL in
Config.in.
lockdev
=======
I don't have the source code here, but the installation process looks
quite ugly. There's no DESTDIR variable? The "make install" target
doesn't create the symbolic links to the library?
_INSTALL_TARGET = YES not needed.
tinyxml
=======
Yet Another XML Parser \o/
Please add the upstream project URL in the Config.in help text. If you
have a slightly better description of the package, it would be great.
_SOURCE not needed, this is the default.
Is _AUTORECONF = YES really needed? If yes, then add a comment before
that line explaining why.
_INSTALL_TARGET = YES not needed.
Newline needed between the header (#####) and the first variable
definition, and between the last variable definition and the $(eval
$(...)) call.
Also, the "(libraries needed by some apps)" text in the header is
useless, get rid of it.
tvheadend
=========
A slightly better description of the package in Config.in would be
great. Also, add the upstream project URL.
Put the BR2_PACKAGE_TVHEADEND_AVAHI option inside a "if
BR2_PACKAGE_TVHEADEND ... endif" block, and drop the "depends on
BR2_PACKAGE_TVHEADEND". Replace the "depends on
BR2_PACKAGE_AVAHI_DAEMON" by "select BR2_PACKAGE_AVAHI" and "select
BR2_PACKAGE_AVAHI_DAEMON", and I would probably suggest to remove the
"default y" here, unless not having Avahi support makes the software
entirely useless.
Drop the _INSTALL_TARGET.
Since you depend on libv4l and openssl, please add the necessary
"select BR2_PACKAGE..." in Config.in.
xmbc
====
select BR2_INSTALL_LIBSTDCPP -> depends on BR2_INSTALL_LIBSDTCPP +
comment when BR2_INSTALL_LIBSTDCPP is not available.
Do we really need *all* these libraries for a basic build of XMBC ?
Having a more reduced XBMC would make it easier for you to get the
patches merged, and then progressively send improvements to add more
features.
Don't forget the wrap the lines in the Config.in help texts.
Typo in "select BR2_PACKAGE_LIBTHEORAK"
The fact that the BR2_PACKAGE_XBMC_AFPFS_NG selects both
BR2_PACKAGE_AFPFS_NG and BR2_PACKAGE_LIBPLIST is curious. Can afpfs-ng
really be built without libplist ? So in other words, is it really the
XMBC code that requires libplist *when* afpfs-ng support is enabled ?
Beware of trailing spaces in the Config.in file.
The S99xmbc script has some Rasberry-Pi specific parts, so it cannot
be integrated as is: the xmbc package should be usable on other
platforms as well. One solution is to have different
S99xmbc.$platformname script, and have Config.in options to enable the
installation of a particular script depending on the selected
platform.
advancedsettings.xml has some trailing spaces. I am not sure how much
this file is Rasberry-Pi specific or not.
What is the status of the different patches ?
_INSTALL_TARGET = YES not needed.
Can you explain why host-sdl_image is needed? If it is really needed,
then please put the necessary patches *before* the xmbc patch.
XBMC_MAKE_OPT += -j1 -> XMBC_MAKE = $(MAKE1)
The rpi-userland dependencies should not be here unconditionnally, we
must be able to build XMBC on other platforms. Note that a second
dependency on rpi-userland is added a bit later, under a condition,
which is OK.
What is this HOST="$(HOST)" variable ?
It should not be needed to have -I$(STAGING_DIR)/usr/include in the
"INCLUDES" variable, since the cross-compiler looks by default in this
directory for header files.
Splitting the line adding INCLUDES, LDFLAGS, CFLAGS and CXXFLAGS would be good.
The line:
XBMC_CONF_ENV += PATH=$(STAGING_DIR)/usr/bin:$(TARGET_PATH)
is really not great. It would be better to figure out what's going on
with mysql, which script it tries to run, and if needed pass only the
path to this script. Clearly, putting the entire STAGING_DIR/usr/bin
directory in the PATH is bad.
Then, for all the optional features (for example FLAG or MAD), is it
possible to make sure that the feature will *not* be enabled when the
corresponding option is disabled. Usually, we do something like:
ifeq ($(BR2_PACKAGE_FOO_FEATURE_A),y)
FOO_CONF_OPT += --enable-feature-a
FOO_DEPENDENCIES += liba
else
FOO_CONT_OPT += --disable-feature-a
endif
If it's possible to do the same here, it would be great.
For XBMC_BOOTSTRAP, same comment as with another package: try to see
if you can use XBMC_AUTORECONF = YES instead. If not, then keep your
XBMC_BOOTSTRAP macro, but use $(@D) instead of $(XBMC_DIR) and add
host-autoconf, host-automake and possibly host-libtool in the
dependencies.
For the calls to install, do:
$(INSTALL) -D -m 0755 package/thirdparty/xbmc/S99xbmc $(TARGET_DIR)/etc/init.d/S99xbmc
(i.e use $(INSTALL) instead of install, and use the -D option).
Please use the same indentation in all macros.
The XBMC_STRIP_BINARIES is useless, it is done automatically for
Buildroot, except maybe for xbmc.bin if it is not installed with
execution rights (to be verified).
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply
* [Buildroot] [RFC 2/2] barebox: Add possibility to build also barebox xloader (MLO).
From: Marek Belisko @ 2012-12-22 23:04 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1356217460-20232-1-git-send-email-marek.belisko@open-nandra.com>
This add config option for user to select defconfig or custom xloader config.
Barebox have xloader defconfig for:
phycard_a_xl2_xload_defconfig
pcm049_xload_defconfig
archosg9_xload_defconfig
phycard_a_l1_xload_defconfig
omap3530_beagle_xload_defconfig
panda_xload_defconfig
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
boot/barebox/Config.in | 28 ++++++++++++++++++++++++++++
boot/barebox/barebox.mk | 28 ++++++++++++++++++++++++++++
2 files changed, 56 insertions(+)
diff --git a/boot/barebox/Config.in b/boot/barebox/Config.in
index 95f330f..bb20542 100644
--- a/boot/barebox/Config.in
+++ b/boot/barebox/Config.in
@@ -99,4 +99,32 @@ config BR2_TARGET_BAREBOX_BAREBOXENV
help
Install bareboxenv tool in target.
+choice
+ prompt "Barebox xloader configuration"
+ default BR2_TARGET_BAREBOX_XLOADER_NONE
+
+config BR2_TARGET_BAREBOX_XLOADER_NONE
+ bool "None"
+
+config BR2_TARGET_BAREBOX_XLOADER_USE_DEFCONFIG
+ bool "Using defconfig"
+
+config BR2_TARGET_BAREBOX_XLOADER_USE_CUSTOM_CONFIG
+ bool "Using a custom config file"
+
+endchoice
+
+config BR2_TARGET_BAREBOX_BOARD_XLOADER_DEFCONFIG
+ string "board xloader defconfig"
+ depends on BR2_TARGET_BAREBOX_XLOADER_USE_DEFCONFIG
+ help
+ Name of the board for which Barebox xloader should be built, without
+ the _defconfig suffix (can be used for pandaboard, beagleboard ...).
+
+config BR2_TARGET_BAREBOX_XLOADER_CUSTOM_CONFIG_FILE
+ string "Xloader configuration file path"
+ depends on BR2_TARGET_BAREBOX_XLOADER_USE_CUSTOM_CONFIG
+ help
+ Path to the barebox custom xloader configuration file.
+
endif
diff --git a/boot/barebox/barebox.mk b/boot/barebox/barebox.mk
index 16110b9..199b708 100644
--- a/boot/barebox/barebox.mk
+++ b/boot/barebox/barebox.mk
@@ -56,7 +56,33 @@ endif
BAREBOX_BUILD_DIR = barebox
+ifneq ($(BR2_TARGET_BAREBOX_XLOADER_NONE),y)
+ifeq ($(BR2_TARGET_BAREBOX_XLOADER_USE_DEFCONFIG),y)
+BAREBOX_XLOADER_SOURCE_CONFIG = $(@D)/arch/$(BAREBOX_ARCH)/configs/$(call qstrip,$(BR2_TARGET_BAREBOX_BOARD_XLOADER_DEFCONFIG))_defconfig
+else ifeq ($(BR2_TARGET_BAREBOX_XLOADER_USE_CUSTOM_CONFIG),y)
+BAREBOX_XLOADER_SOURCE_CONFIG = $(BR2_TARGET_BAREBOX_XLOADER_CUSTOM_CONFIG_FILE)
+endif
+
+BAREBOX_XLOADER_BUILD_DIR = MLO
+
+define BAREBOX_XLOADER_CONFIGURE_CMDS
+ mkdir -p $(@D)/$(BAREBOX_XLOADER_BUILD_DIR)
+ cp $(BAREBOX_XLOADER_SOURCE_CONFIG) $(@D)/arch/$(BAREBOX_ARCH)/configs/buildroot_xload_defconfig
+ $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(@D) buildroot_xload_defconfig O=$(BAREBOX_XLOADER_BUILD_DIR)
+endef
+
+define BAREBOX_XLOADER_BUILD_CMDS
+ $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(@D) O=$(BAREBOX_XLOADER_BUILD_DIR)
+endef
+
+define BAREBOX_XLOADER_INSTALL_IMAGES_CMDS
+ cp $(@D)/$(BAREBOX_XLOADER_BUILD_DIR)/MLO $(BINARIES_DIR)
+endef
+
+endif
+
define BAREBOX_CONFIGURE_CMDS
+ $(BAREBOX_XLOADER_CONFIGURE_CMDS)
mkdir -p $(@D)/$(BAREBOX_BUILD_DIR)
cp $(BAREBOX_SOURCE_CONFIG) $(@D)/arch/$(BAREBOX_ARCH)/configs/buildroot_defconfig
$(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(@D) buildroot_defconfig O=$(BAREBOX_BUILD_DIR)
@@ -70,11 +96,13 @@ endef
endif
define BAREBOX_BUILD_CMDS
+ $(BAREBOX_XLOADER_BUILD_CMDS)
$(BAREBOX_BUILD_BAREBOXENV_CMDS)
$(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(@D) O=$(BAREBOX_BUILD_DIR)
endef
define BAREBOX_INSTALL_IMAGES_CMDS
+ $(BAREBOX_XLOADER_INSTALL_IMAGES_CMDS)
cp $(@D)/$(BAREBOX_BUILD_DIR)/barebox.bin $(BINARIES_DIR)
endef
--
1.7.10.4
^ permalink raw reply related
* [Buildroot] [RFC 1/2] barebox: Build barebox in separate directory.
From: Marek Belisko @ 2012-12-22 23:04 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1356217460-20232-1-git-send-email-marek.belisko@open-nandra.com>
This is necessary when we would like to add support for building also barebox
xloader (MLO).
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
boot/barebox/barebox.mk | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/boot/barebox/barebox.mk b/boot/barebox/barebox.mk
index a025d5f..16110b9 100644
--- a/boot/barebox/barebox.mk
+++ b/boot/barebox/barebox.mk
@@ -54,9 +54,12 @@ else ifeq ($(BR2_TARGET_BAREBOX_USE_CUSTOM_CONFIG),y)
BAREBOX_SOURCE_CONFIG = $(BR2_TARGET_BAREBOX_CUSTOM_CONFIG_FILE)
endif
+BAREBOX_BUILD_DIR = barebox
+
define BAREBOX_CONFIGURE_CMDS
+ mkdir -p $(@D)/$(BAREBOX_BUILD_DIR)
cp $(BAREBOX_SOURCE_CONFIG) $(@D)/arch/$(BAREBOX_ARCH)/configs/buildroot_defconfig
- $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(@D) buildroot_defconfig
+ $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(@D) buildroot_defconfig O=$(BAREBOX_BUILD_DIR)
endef
ifeq ($(BR2_TARGET_BAREBOX_BAREBOXENV),y)
@@ -68,11 +71,11 @@ endif
define BAREBOX_BUILD_CMDS
$(BAREBOX_BUILD_BAREBOXENV_CMDS)
- $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(@D)
+ $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(@D) O=$(BAREBOX_BUILD_DIR)
endef
define BAREBOX_INSTALL_IMAGES_CMDS
- cp $(@D)/barebox.bin $(BINARIES_DIR)
+ cp $(@D)/$(BAREBOX_BUILD_DIR)/barebox.bin $(BINARIES_DIR)
endef
ifeq ($(BR2_TARGET_BAREBOX_BAREBOXENV),y)
@@ -97,15 +100,15 @@ barebox-menuconfig barebox-xconfig barebox-gconfig barebox-nconfig: barebox-conf
rm -f $(BAREBOX_DIR)/.stamp_{built,target_installed,images_installed}
barebox-savedefconfig: barebox-configure
- $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(BAREBOX_DIR) \
+ $(MAKE) $(BAREBOX_MAKE_FLAGS) -C $(BAREBOX_DIR) O=$(BAREBOX_BUILD_DIR) \
$(subst barebox-,,$@)
ifeq ($(BR2_TARGET_BAREBOX_USE_CUSTOM_CONFIG),y)
-barebox-update-config: barebox-configure $(BAREBOX_DIR)/.config
- cp -f $(BAREBOX_DIR)/.config $(BR2_TARGET_BAREBOX_CUSTOM_CONFIG_FILE)
+barebox-update-config: barebox-configure $(BAREBOX_DIR)/$(BAREBOX_BUILD_DIR)/.config
+ cp -f $(BAREBOX_DIR)/$(BAREBOX_BUILD_DIR)/.config $(BR2_TARGET_BAREBOX_CUSTOM_CONFIG_FILE)
barebox-update-defconfig: barebox-savedefconfig
- cp -f $(BAREBOX_DIR)/defconfig $(BR2_TARGET_BAREBOX_CUSTOM_CONFIG_FILE)
+ cp -f $(BAREBOX_DIR)/$(BAREBOX_BUILD_DIR)/defconfig $(BR2_TARGET_BAREBOX_CUSTOM_CONFIG_FILE)
else
barebox-update-config: ;
barebox-update-defconfig: ;
--
1.7.10.4
^ permalink raw reply related
* [Buildroot] [RFC 0/2] Add support for building barebox xloader.
From: Marek Belisko @ 2012-12-22 23:04 UTC (permalink / raw)
To: buildroot
Reposting-> first time was sent to wrong mailing list.
Currently Buildroot have support to build barebox only. For some board there is possibility
to build also xloader (first stage bootloader) based on barebox. Following patches add
support for building barebox + xloader (aka MLO) by once if user specify configuration for
xloader.
First patch move building barebox to separate directory. Second patch add support for building
xloader. Both binaries are build in separate directories to avoid problems with not clean tree.
With this patches we can build complete image for e.g. pandaboard (which is my case) without building
anything by hand.
Marek Belisko (2):
barebox: Build barebox in separate directory.
barebox: Add possibility to build also barebox xloader (MLO).
boot/barebox/Config.in | 28 ++++++++++++++++++++++++++++
boot/barebox/barebox.mk | 45 ++++++++++++++++++++++++++++++++++++++-------
2 files changed, 66 insertions(+), 7 deletions(-)
--
1.7.10.4
^ permalink raw reply
* [Buildroot] XBMC
From: Belisko Marek @ 2012-12-22 23:00 UTC (permalink / raw)
To: buildroot
In-Reply-To: <CAGduivzZU=-GOQzAj4keyBVVMZ=9zuXaHX0wD68X7VSpB-c1aQ@mail.gmail.com>
Dear Maxime Hadjinlian,
On Sat, Dec 22, 2012 at 12:58 AM, Maxime Hadjinlian
<maxime.hadjinlian@gmail.com> wrote:
> Hi everyone,
>
> I wanted to add XBMC to buildroot, but since it's a pretty big
> application with a lot of dependency, I have created a separated tree
> at github :
> https://github.com/maximeh/buildroot
I was look at some last of your commits and the are some things which
could be good to fix before sending patches for review:
1. new packages doesn't contain licence info in mk file
2. new packages doesn't have link to webpage
3. packages which are autotools based don't need INSTALL_TARGET = YES
(it is default)
4. some packages are located at github and git protocol is used to
fetch. Please convert
according: http://buildroot.uclibc.org/downloads/manual/manual.html#github-download-url
5. lot of new packages contains really big patches (e.g.: afpfs-ng).
Patches should be post upstream
to avoid adding then to BR.
>
> I would like to know if it would be of any interest to upstream this
> before sending all theses patches for review ?
>
> Thanks
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Cheers,
mbe
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
^ permalink raw reply
* [Buildroot] [PATCH 2/6] polkit: new package
From: Belisko Marek @ 2012-12-22 22:10 UTC (permalink / raw)
To: buildroot
In-Reply-To: <20121222161922.59aad225@skate>
Hi Thomas,
On Sat, Dec 22, 2012 at 4:19 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Marek Belisko,
>
> On Fri, 21 Dec 2012 22:51:06 +0100, Marek Belisko wrote:
>
>> + select BR2_PACKAGE_LIBGLIB2
>> + select BR2_DBUS_EXPAT
>
> Are you sure this shouldn't be BR2_PACKAGE_EXPAT instead?
Good catch. Thanks.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
Cheers,
mbe
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
^ permalink raw reply
* [Buildroot] [PATCH 2/6] polkit: new package
From: Belisko Marek @ 2012-12-22 21:54 UTC (permalink / raw)
To: buildroot
In-Reply-To: <20121222161826.05b661e3@skate>
Hi Thomas,
On Sat, Dec 22, 2012 at 4:18 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Marek Belisko,
>
> On Fri, 21 Dec 2012 22:51:06 +0100, Marek Belisko wrote:
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Signed-off-by: Marek Belisko <marek.belisko@streamunlimited.com>
>> ---
>> package/Config.in | 1 +
>> package/polkit/Config.in | 8 ++++++++
>> package/polkit/polkit.mk | 18 ++++++++++++++++++
>> 3 files changed, 27 insertions(+)
>> create mode 100644 package/polkit/Config.in
>> create mode 100644 package/polkit/polkit.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index afecb8e..155a429 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -749,6 +749,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>> source "package/module-init-tools/Config.in"
>> endif
>> source "package/monit/Config.in"
>> +source "package/polkit/Config.in"
>> if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>> source "package/procps/Config.in"
>> source "package/psmisc/Config.in"
>> diff --git a/package/polkit/Config.in b/package/polkit/Config.in
>> new file mode 100644
>> index 0000000..9ca347a
>> --- /dev/null
>> +++ b/package/polkit/Config.in
>> @@ -0,0 +1,8 @@
>> +config BR2_PACKAGE_POLKIT
>> + bool "polkit"
>
> Should be a tab, not spaces.
>
>> + select BR2_PACKAGE_LIBGLIB2
>> + select BR2_DBUS_EXPAT
>> + help
>> + PolicyKit is a toolkit for defining and handling
>> + authorizations. It is used for allowing unprivileged
>> + processes to speak to privileged processes.
>
> Upstream URL missing.
>
>> diff --git a/package/polkit/polkit.mk b/package/polkit/polkit.mk
>> new file mode 100644
>> index 0000000..8c882f2
>> --- /dev/null
>> +++ b/package/polkit/polkit.mk
>> @@ -0,0 +1,18 @@
>> +#############################################################
>> +#
>> +# polkit
>> +#
>> +#############################################################
>> +POLKIT_VERSION = 0.103
>> +POLKIT_SITE = http://www.freedesktop.org/software/polkit/releases/
>> +
>> +POLKIT_INSTALL_STAGING = YES
>
> I don't remember, does polkit installs some libraries or .pc files, or
> something that justify its installation in staging ?
Yes. In staging there are added 3 libraries with polkit-agent-1.pc
polkit-backend-1.pc polkit-gobject-1.pc files.
>
>> +POLKIT_DEPENDENCIES = libglib2 host-intltool expat
>> +
>> +# We could also support --with-authfw=pam
>> +POLKIT_CONF_OPT = \
>> + --with-authfw=shadow \
>> + --with-os-type=unknown
>> +
>> +$(eval $(autotools-package))
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
Thanks,
mbe
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
^ permalink raw reply
* [Buildroot] Can buildroot build kernel documentations?
From: Woody Wu @ 2012-12-22 15:37 UTC (permalink / raw)
To: buildroot
In-Reply-To: <20121221184714.0cdfded6@skate>
On Fri, Dec 21, 2012 at 06:47:14PM +0100, Thomas Petazzoni wrote:
> Dear Woody Wu,
>
> On Sat, 22 Dec 2012 01:10:52 +0800, Woody Wu wrote:
>
> > In addtional to build the kernel image, if I also want to build the
> > kernel documentation (make htmldocs), can I do it in buildroot?
>
> cd output/build/linux-* ; make htmldocs
Nice! Thanks :)
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
--
woody
I can't go back to yesterday - because I was a different person then.
^ permalink raw reply
* [Buildroot] [PATCH 2/6] polkit: new package
From: Thomas Petazzoni @ 2012-12-22 15:19 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1356126670-16186-3-git-send-email-marek.belisko@open-nandra.com>
Dear Marek Belisko,
On Fri, 21 Dec 2012 22:51:06 +0100, Marek Belisko wrote:
> + select BR2_PACKAGE_LIBGLIB2
> + select BR2_DBUS_EXPAT
Are you sure this shouldn't be BR2_PACKAGE_EXPAT instead?
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply
* [Buildroot] [PATCH 2/6] polkit: new package
From: Thomas Petazzoni @ 2012-12-22 15:18 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1356126670-16186-3-git-send-email-marek.belisko@open-nandra.com>
Dear Marek Belisko,
On Fri, 21 Dec 2012 22:51:06 +0100, Marek Belisko wrote:
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Marek Belisko <marek.belisko@streamunlimited.com>
> ---
> package/Config.in | 1 +
> package/polkit/Config.in | 8 ++++++++
> package/polkit/polkit.mk | 18 ++++++++++++++++++
> 3 files changed, 27 insertions(+)
> create mode 100644 package/polkit/Config.in
> create mode 100644 package/polkit/polkit.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index afecb8e..155a429 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -749,6 +749,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> source "package/module-init-tools/Config.in"
> endif
> source "package/monit/Config.in"
> +source "package/polkit/Config.in"
> if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> source "package/procps/Config.in"
> source "package/psmisc/Config.in"
> diff --git a/package/polkit/Config.in b/package/polkit/Config.in
> new file mode 100644
> index 0000000..9ca347a
> --- /dev/null
> +++ b/package/polkit/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_POLKIT
> + bool "polkit"
Should be a tab, not spaces.
> + select BR2_PACKAGE_LIBGLIB2
> + select BR2_DBUS_EXPAT
> + help
> + PolicyKit is a toolkit for defining and handling
> + authorizations. It is used for allowing unprivileged
> + processes to speak to privileged processes.
Upstream URL missing.
> diff --git a/package/polkit/polkit.mk b/package/polkit/polkit.mk
> new file mode 100644
> index 0000000..8c882f2
> --- /dev/null
> +++ b/package/polkit/polkit.mk
> @@ -0,0 +1,18 @@
> +#############################################################
> +#
> +# polkit
> +#
> +#############################################################
> +POLKIT_VERSION = 0.103
> +POLKIT_SITE = http://www.freedesktop.org/software/polkit/releases/
> +
> +POLKIT_INSTALL_STAGING = YES
I don't remember, does polkit installs some libraries or .pc files, or
something that justify its installation in staging ?
> +POLKIT_DEPENDENCIES = libglib2 host-intltool expat
> +
> +# We could also support --with-authfw=pam
> +POLKIT_CONF_OPT = \
> + --with-authfw=shadow \
> + --with-os-type=unknown
> +
> +$(eval $(autotools-package))
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply
* [Buildroot] [PATCH 1/6] sg3_utils: new package
From: Thomas Petazzoni @ 2012-12-22 15:14 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1356126670-16186-2-git-send-email-marek.belisko@open-nandra.com>
Dear Marek Belisko,
On Fri, 21 Dec 2012 22:51:05 +0100, Marek Belisko wrote:
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Marek Belisko <marek.belisko@streamunlimited.com>
> ---
> package/Config.in | 1 +
> package/sg3_utils/Config.in | 15 +++++++++++++++
> package/sg3_utils/sg3_utils.mk | 33 +++++++++++++++++++++++++++++++++
> 3 files changed, 49 insertions(+)
> create mode 100644 package/sg3_utils/Config.in
> create mode 100644 package/sg3_utils/sg3_utils.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 66445ff..afecb8e 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -253,6 +253,7 @@ source "package/rng-tools/Config.in"
> source "package/sane-backends/Config.in"
> source "package/sdparm/Config.in"
> source "package/setserial/Config.in"
> +source "package/sg3_utils/Config.in"
> source "package/smartmontools/Config.in"
> source "package/snowball-hdmiservice/Config.in"
> source "package/sredird/Config.in"
> diff --git a/package/sg3_utils/Config.in b/package/sg3_utils/Config.in
> new file mode 100644
> index 0000000..d120e55
> --- /dev/null
> +++ b/package/sg3_utils/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_SG3_UTILS
> + bool "sgutils"
> + depends on BR2_LARGEFILE
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> + help
> + Low level utilities for devices that use a SCSI command set.
> +
> + http://sg.danny.cz/sg/sg3_utils.html
> +
> +config BR2_PACKAGE_SG3_UTILS_PROGS
> + bool "install programs"
The "bool" should be preceded by a tab, not spaces.
> + depends on BR2_PACKAGE_SG3_UTILS
> +
> +comment "sgutils requires a toolchain with LARGEFILE and threads support"
> + depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
Tab, not spaces before the depends on.
> diff --git a/package/sg3_utils/sg3_utils.mk b/package/sg3_utils/sg3_utils.mk
> new file mode 100644
> index 0000000..1c629e8
> --- /dev/null
> +++ b/package/sg3_utils/sg3_utils.mk
> @@ -0,0 +1,33 @@
> +#############################################################
> +#
> +# sg3_utils
> +#
> +#############################################################
> +SG3_UTILS_VERSION = 1.34
> +SG3_UTILS_SITE = http://sg.danny.cz/sg/p/
Please add SG3_UTILS_LICENSE and SG3_UTILS_LICENSE_FILES.
> +# install the libsgutils2 library
> +SG3_UTILS_INSTALL_STAGING = YES
> +
> +define SG3_UTILS_REMOVE_PROGS
> + for prog in \
> + dd decode_sense emc_trespass format get_config \
> + get_lba_status ident inq logs luns map26 \
> + map sgm_dd modes opcodes sgp_dd persist prevent \
> + raw rbuf rdac read readcap read_block_limits \
> + read_buffer read_long reassign referrals \
> + requests reset rmsn rtpg safte sanitize \
> + sat_identify sat_phy_event sat_set_features scan \
> + senddiag ses start stpg sync test_rwbuf turs \
> + unmap verify vpd write_buffer write_long \
> + write_same wr_mode ; do \
> + $(RM) $(TARGET_DIR)/usr/bin/sg_$${prog} ; \
> + done
> + $(RM) $(TARGET_DIR)/usr/bin/sginfo
> +endef
> +
> +ifneq ($(BR2_PACKAGE_SG3_UTILS_PROGS),y)
> +SG3_UTILS_POST_INSTALL_TARGET_HOOKS += SG3_UTILS_REMOVE_PROGS
> +endif
Maybe we should turn this into positive logic, and put the
SG3_UTILS_REMOVE_PROGS macro inside the condition. Something like:
ifeq ($(BR2_PACKAGE_SG3_UTILS_PROGS),)
define SG3_UTILS_REMOVE_PROGS
...
endef
SG3_UTILS_POST_INSTALL_TARGET_HOOKS += SG3_UTILS_REMOVE_PROGS
endif
Otherwise, looks good (but untested).
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply
* [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain
From: Fabio Porcedda @ 2012-12-22 13:45 UTC (permalink / raw)
To: buildroot
In-Reply-To: <CAHXCMM+TKYDv5Fo-oY13+RSp1ayD+Du0AamTq7bA6KgZ54xfkg@mail.gmail.com>
On Sat, Dec 22, 2012 at 1:45 PM, Samuel Martin <s.martin49@gmail.com> wrote:
> Hi Fabio,
>
> 2012/12/21 Fabio Porcedda <fabio.porcedda@gmail.com>:
>> - Use a more descriptive name, the same of the "toolchain" directory.
>> - Add missing dependencies to be able to successfully use the target
>> right after the configuration.
>> - Move to a better position.
>> - Documentation it in the help target.
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>> ---
>> Makefile | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 4b09437..458b8c5 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config
>>
>> prepare: $(BUILD_DIR)/buildroot-config/auto.conf
>>
>> +toolchain: prepare dirs dependencies $(BASE_TARGETS)
>> +
>> world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
> Any reason to not make the world target depend on the toolchain and
> $(TARGETS_ALL) targets?
> IOW:
> world: toolchain $(TARGETS_ALL)
I've done exactly that in the following patch 2/2
> Otherwise, it looks good to me with few words in the manual as already
> mentioned by Arnout.
Thanks for the review
Best regards
--
Fabio Porcedda
^ permalink raw reply
* [Buildroot] Patch file too big
From: Stefan Fröberg @ 2012-12-22 13:41 UTC (permalink / raw)
To: buildroot
Hello to all.
I found out that my [PATCH 04/12] elfutils is too big to submit here.
It's size is about 1.5 MB (only grub.400-nic_update2.patch in buildroot
is bigger, with size of 1.6 MB)
The patch contains gnulib functionality to allow elfutils to compile and
it can't be easily splitted.
Is there any free, public service that I could use to upload it and just
submit link to it here ?
I already tried pastebin free version and it was too big for there too.
Regards
Stefan
^ permalink raw reply
* [Buildroot] [PATCH] fluxbox: fix build against imlib2
From: Samuel Martin @ 2012-12-22 13:28 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1355077123-5948-2-git-send-email-s.martin49@gmail.com>
ping?
2012/12/9 Samuel Martin <s.martin49@gmail.com>:
> * fix configure.in to take care of the given imlib2-prefix
> * disable imlib2 support if imlib2 is not part of the selection
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/fluxbox/fluxbox-1.3.2-fix-configure.patch | 19 +++++++++++++++++++
> package/fluxbox/fluxbox.mk | 10 +++++++++-
> 2 files changed, 28 insertions(+), 1 deletion(-)
> create mode 100644 package/fluxbox/fluxbox-1.3.2-fix-configure.patch
>
> diff --git a/package/fluxbox/fluxbox-1.3.2-fix-configure.patch b/package/fluxbox/fluxbox-1.3.2-fix-configure.patch
> new file mode 100644
> index 0000000..2cb8273
> --- /dev/null
> +++ b/package/fluxbox/fluxbox-1.3.2-fix-configure.patch
> @@ -0,0 +1,19 @@
> +Avoid to call the imlib2-config that may be installed on the host system
> +(even when --with-imlib2-prefix or --with-imlib2-exec-prefix is passed to
> +the configure script), which totally screws up the resulting linker flags.
> +
> +Inspired by: http://git.fluxbox.org/fluxbox.git/commit/?id=b178bed60b5bd8b2c9ed0cbc67fd729ff3820589
> +
> +Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> +
> +--- fluxbox-1.3.2.orig/configure.in 2012-10-21 16:11:59.445749396 +0200
> ++++ fluxbox-1.3.2/configure.in 2012-10-21 16:35:27.658390856 +0200
> +@@ -443,8 +443,6 @@ if test x$enable_imlib2 = "xyes"; then
> + [
> + IMLIB2=true
> + AC_DEFINE(HAVE_IMLIB2, [], [Imlib2 support])
> +- IMLIB2_LIBS=`imlib2-config --libs`
> +- IMLIB2_CFLAGS=`imlib2-config --cflags`
> + LIBS="$LIBS $IMLIB2_LIBS"
> + CXXFLAGS="$CXXFLAGS $IMLIB2_CFLAGS"
> + ], [ AC_MSG_RESULT(no)]
> diff --git a/package/fluxbox/fluxbox.mk b/package/fluxbox/fluxbox.mk
> index 356c5a2..04ffb91 100644
> --- a/package/fluxbox/fluxbox.mk
> +++ b/package/fluxbox/fluxbox.mk
> @@ -10,11 +10,19 @@ FLUXBOX_SITE = http://downloads.sourceforge.net/project/fluxbox/fluxbox/$(FLUXBO
> FLUXBOX_LICENSE = MIT
> FLUXBOX_LICENSE_FILES = COPYING
>
> +FLUXBOX_AUTORECONF = YES
> +
> FLUXBOX_CONF_OPT = --x-includes=$(STAGING_DIR)/usr/include/X11 \
> --x-libraries=$(STAGING_DIR)/usr/lib
> -
> FLUXBOX_DEPENDENCIES = xlib_libX11 $(if $(BR2_PACKAGE_LIBICONV),libiconv)
>
> +ifeq ($(BR2_PACKAGE_IMLIB2),y)
> +FLUXBOX_CONF_OPT += --enable-imlib2 --with-imlib2-prefix=$(STAGING_DIR)/usr
> +FLUXBOX_DEPENDENCIES += imlib2
> +else
> +FLUXBOX_CONF_OPT += --disable-imlib2
> +endif
> +
> define FLUXBOX_INSTALL_XSESSION_FILE
> [ -f $(TARGET_DIR)/root/.xsession ] || $(INSTALL) -m 0755 -D \
> package/fluxbox/xsession $(TARGET_DIR)/root/.xsession
> --
> 1.8.0.1
>
--
Sam
^ permalink raw reply
* [Buildroot] [PATCH] matchbox-lib: fix license info
From: Samuel Martin @ 2012-12-22 13:27 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1355077123-5948-1-git-send-email-s.martin49@gmail.com>
ping?
2012/12/9 Samuel Martin <s.martin49@gmail.com>:
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/matchbox/matchbox-lib/matchbox-lib.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/matchbox/matchbox-lib/matchbox-lib.mk b/package/matchbox/matchbox-lib/matchbox-lib.mk
> index 7730d94..d18df6b 100644
> --- a/package/matchbox/matchbox-lib/matchbox-lib.mk
> +++ b/package/matchbox/matchbox-lib/matchbox-lib.mk
> @@ -7,7 +7,7 @@
> MATCHBOX_LIB_VERSION = 1.9
> MATCHBOX_LIB_SOURCE = libmatchbox-$(MATCHBOX_LIB_VERSION).tar.bz2
> MATCHBOX_LIB_SITE = http://downloads.yoctoproject.org/releases/matchbox/libmatchbox/$(MATCHBOX_LIB_VERSION)
> -MATCHBOX_LIB_LICENSE = LGPLv2.1
> +MATCHBOX_LIB_LICENSE = LGPLv2.1+
> MATCHBOX_LIB_LICENSE_FILES = COPYING
> MATCHBOX_LIB_INSTALL_STAGING = YES
> MATCHBOX_LIB_DEPENDENCIES = host-pkgconf expat xlib_libXext
> --
> 1.8.0.1
>
--
Sam
^ permalink raw reply
* [Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain
From: Samuel Martin @ 2012-12-22 12:45 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1356086190-906-2-git-send-email-fabio.porcedda@gmail.com>
Hi Fabio,
2012/12/21 Fabio Porcedda <fabio.porcedda@gmail.com>:
> - Use a more descriptive name, the same of the "toolchain" directory.
> - Add missing dependencies to be able to successfully use the target
> right after the configuration.
> - Move to a better position.
> - Documentation it in the help target.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
> Makefile | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 4b09437..458b8c5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config
>
> prepare: $(BUILD_DIR)/buildroot-config/auto.conf
>
> +toolchain: prepare dirs dependencies $(BASE_TARGETS)
> +
> world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
Any reason to not make the world target depend on the toolchain and
$(TARGETS_ALL) targets?
IOW:
world: toolchain $(TARGETS_ALL)
Otherwise, it looks good to me with few words in the manual as already
mentioned by Arnout.
Regards,
--
Sam
^ permalink raw reply
* [Buildroot] [PATCH] gettext: disable tools tests when no threads
From: Gustavo Zacarias @ 2012-12-22 12:31 UTC (permalink / raw)
To: buildroot
Disable the gettext-tools tests build since they break when a full
toolchain without threads is being used.
Fixes:
http://autobuild.buildroot.net/results/a187c76c359787f8e2ec6e12da2d7b1e33ed43c5/
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/gettext/gettext.mk | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/package/gettext/gettext.mk b/package/gettext/gettext.mk
index 77881d3..a91cb7f 100644
--- a/package/gettext/gettext.mk
+++ b/package/gettext/gettext.mk
@@ -44,6 +44,12 @@ define GETTEXT_DISABLE_TOOLS
endef
endif # GETTEXT_TOOLS = n
+# The tools tests build fails with full toolchain without threads
+define GETTEXT_DISABLE_TESTS
+ $(SED) 's/m4 tests/m4/' $(@D)/gettext-tools/Makefile.in
+endef
+
GETTEXT_POST_PATCH_HOOKS += GETTEXT_DISABLE_TOOLS
+GETTEXT_POST_PATCH_HOOKS += GETTEXT_DISABLE_TESTS
$(eval $(autotools-package))
--
1.7.8.6
^ permalink raw reply related
* [Buildroot] [PATCH] pulseaudio: needs threads
From: Gustavo Zacarias @ 2012-12-22 12:06 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/4d6a5793e475683fbc58ccaf03cf7816233a5052/
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/multimedia/gst-plugins-good/Config.in | 1 +
package/multimedia/mpd/Config.in | 1 +
package/multimedia/pulseaudio/Config.in | 5 +++--
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/package/multimedia/gst-plugins-good/Config.in b/package/multimedia/gst-plugins-good/Config.in
index 33ecb5c..b5006e6 100644
--- a/package/multimedia/gst-plugins-good/Config.in
+++ b/package/multimedia/gst-plugins-good/Config.in
@@ -193,6 +193,7 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_OSS4
bool "oss4 (Open Sound System 4)"
config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PULSE
+ depends on BR2_TOOLCHAIN_HAS_THREADS # pulseaudio
select BR2_PACKAGE_PULSEAUDIO
bool "pulseaudio"
diff --git a/package/multimedia/mpd/Config.in b/package/multimedia/mpd/Config.in
index 5d08182..2e44741 100644
--- a/package/multimedia/mpd/Config.in
+++ b/package/multimedia/mpd/Config.in
@@ -40,6 +40,7 @@ config BR2_PACKAGE_MPD_AUDIOFILE
config BR2_PACKAGE_MPD_PULSEAUDIO
bool "pulseaudio"
+ depends on BR2_TOOLCHAIN_HAS_THREADS # pulseaudio
select BR2_PACKAGE_PULSEAUDIO
help
Enable pulseaudio output support.
diff --git a/package/multimedia/pulseaudio/Config.in b/package/multimedia/pulseaudio/Config.in
index 6c767bb..eeb8b5a 100644
--- a/package/multimedia/pulseaudio/Config.in
+++ b/package/multimedia/pulseaudio/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_PULSEAUDIO
bool "pulseaudio"
depends on BR2_USE_WCHAR
+ depends on BR2_TOOLCHAIN_HAS_THREADS
select BR2_PACKAGE_LIBTOOL
select BR2_PACKAGE_JSON_C
select BR2_PACKAGE_LIBSNDFILE
@@ -17,5 +18,5 @@ config BR2_PACKAGE_PULSEAUDIO
http://pulseaudio.org
-comment "pulseaudio requires a toolchain with WCHAR support"
- depends on !BR2_USE_WCHAR
+comment "pulseaudio requires a toolchain with WCHAR and threads support"
+ depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
--
1.7.8.6
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox