Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v4 1/2] rhash: new package
From: Vicente Olivert Riera @ 2017-05-09  9:28 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
Changes v3 -> v4:
- Add a comment explaining why we install the console utility to the
  staging directory. (Baruch)
- Perform the installation of the console utility to the staging
  directory into a post-install-staginig-hook. (Yann)
Changes v2 -> v3:
- Nothing
Changes v1 -> v2:
- Rename package to rhash
- Take the help text of the library instead of the console utility
- Sub-config option for the rhash binary starts with the package name
- Conditionals for shared/static/shared-static reordered
- Put make options into a make_opts variable
- Install the console utility to staging as well
  (All suggestions by Arnout)
---
 package/Config.in        |  1 +
 package/rhash/Config.in  | 24 ++++++++++++++++
 package/rhash/rhash.hash |  3 ++
 package/rhash/rhash.mk   | 73 ++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 101 insertions(+)
 create mode 100644 package/rhash/Config.in
 create mode 100644 package/rhash/rhash.hash
 create mode 100644 package/rhash/rhash.mk

diff --git a/package/Config.in b/package/Config.in
index d57813c..9b64ce2 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -964,6 +964,7 @@ menu "Crypto"
 	source "package/mbedtls/Config.in"
 	source "package/nettle/Config.in"
 	source "package/openssl/Config.in"
+	source "package/rhash/Config.in"
 	source "package/tinydtls/Config.in"
 	source "package/trousers/Config.in"
 	source "package/ustream-ssl/Config.in"
diff --git a/package/rhash/Config.in b/package/rhash/Config.in
new file mode 100644
index 0000000..6581243
--- /dev/null
+++ b/package/rhash/Config.in
@@ -0,0 +1,24 @@
+config BR2_PACKAGE_RHASH
+	bool "rhash"
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
+	help
+	  LibRHash is a professional,  portable,  thread-safe  C library for
+	  computing a wide variety of hash sums, such as  CRC32, MD4, MD5,
+	  SHA1, SHA256, SHA512, SHA3, AICH, ED2K, Tiger, DC++ TTH, BitTorrent
+	  BTIH,  GOST R 34.11-94, RIPEMD-160, HAS-160, EDON-R, Whirlpool and
+	  Snefru.
+
+	  https://github.com/rhash/RHash
+
+if BR2_PACKAGE_RHASH
+
+config BR2_PACKAGE_RHASH_BIN
+	bool "rhash binary"
+	depends on !BR2_STATIC_LIBS
+	help
+	  Install rhash console utility
+
+comment "rhash binary needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
+
+endif
diff --git a/package/rhash/rhash.hash b/package/rhash/rhash.hash
new file mode 100644
index 0000000..5efc3a6
--- /dev/null
+++ b/package/rhash/rhash.hash
@@ -0,0 +1,3 @@
+# From https://sourceforge.net/projects/rhash/files/rhash/1.3.4/
+md5 0b51010604659e9e99f6307b053ba13b  rhash-1.3.4-src.tar.gz
+sha1 411d8c7ba84fa9763bc49fa2fd3a7587712fd52c  rhash-1.3.4-src.tar.gz
diff --git a/package/rhash/rhash.mk b/package/rhash/rhash.mk
new file mode 100644
index 0000000..aa1a28d
--- /dev/null
+++ b/package/rhash/rhash.mk
@@ -0,0 +1,73 @@
+################################################################################
+#
+# rhash
+#
+################################################################################
+
+RHASH_VERSION = 1.3.4
+RHASH_SOURCE = rhash-$(RHASH_VERSION)-src.tar.gz
+RHASH_SITE = https://sourceforge.net/projects/rhash/files/rhash/$(RHASH_VERSION)
+RHASH_LICENSE = MIT
+RHASH_LICENSE_FILES = COPYING
+RHASH_INSTALL_STAGING = YES
+
+ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
+RHASH_DEPENDENCIES += gettext
+RHASH_ADDCFLAGS += -DUSE_GETTEXT
+RHASH_ADDLDFLAGS += -lintl
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yx)
+RHASH_DEPENDENCIES += openssl
+RHASH_ADDCFLAGS += -DOPENSSL_RUNTIME -rdynamic
+RHASH_ADDLDFLAGS += -ldl
+endif
+
+RHASH_MAKE_OPTS = \
+	ADDCFLAGS="$(RHASH_ADDCFLAGS)" \
+	ADDLDFLAGS="$(RHASH_ADDLDFLAGS)" \
+	PREFIX="/usr"
+
+ifeq ($(BR2_SHARED_LIBS),y)
+RHASH_BUILD_TARGETS = lib-shared build-shared
+RHASH_INSTALL_TARGETS = install-lib-shared install-so-link
+else ifeq ($(BR2_STATIC_LIBS),y)
+RHASH_BUILD_TARGETS = lib-static
+RHASH_INSTALL_TARGETS = install-lib-static
+else
+RHASH_BUILD_TARGETS = lib-static lib-shared build-shared
+RHASH_INSTALL_TARGETS = install-lib-static install-lib-shared install-so-link
+endif
+
+define RHASH_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+	$(RHASH_MAKE_OPTS) $(RHASH_BUILD_TARGETS)
+endef
+
+define RHASH_INSTALL_STAGING_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/librhash \
+		DESTDIR="$(STAGING_DIR)" $(RHASH_MAKE_OPTS) $(RHASH_INSTALL_TARGETS) \
+		install-headers
+endef
+
+define RHASH_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/librhash \
+		DESTDIR="$(TARGET_DIR)" $(RHASH_MAKE_OPTS) $(RHASH_INSTALL_TARGETS)
+endef
+
+ifeq ($(BR2_PACKAGE_RHASH_BIN),y)
+# We also install the rhash console utility to the staging directory
+# since we want it to be a superset of the target directory.
+define RHASH_INSTALL_STAGING_RHASH_BIN
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		DESTDIR="$(STAGING_DIR)" $(RHASH_MAKE_OPTS) install-shared
+endef
+RHASH_POST_INSTALL_STAGING_HOOKS += RHASH_INSTALL_STAGING_RHASH_BIN
+define RHASH_INSTALL_TARGET_RHASH_BIN
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		DESTDIR="$(TARGET_DIR)" $(RHASH_MAKE_OPTS) install-shared
+endef
+RHASH_POST_INSTALL_TARGET_HOOKS += RHASH_INSTALL_TARGET_RHASH_BIN
+endif
+
+$(eval $(generic-package))
-- 
2.10.2

^ permalink raw reply related

* [Buildroot] [PATCH v4 2/2] cmake: bump version to 3.8.1
From: Vicente Olivert Riera @ 2017-05-09  9:28 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170509092817.61068-1-Vincent.Riera@imgtec.com>

cmake depends on rhash, but host-cmake doesn't. This is because we use
the bundled dependencies for host-cmake but not for target.

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
Changes v3 -> v4:
- Nothing
Changes v2 -> v3:
- Bump version to 3.8.1
- Change LIBRHASH references to RHASH
Changes v1 -> v2:
- Added explanation in the commit log about why rhash dependency is
  needed for cmake but not for host-cmake. (Arnout)
---
 package/cmake/Config.in  | 1 +
 package/cmake/cmake.hash | 4 ++--
 package/cmake/cmake.mk   | 6 +++---
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/package/cmake/Config.in b/package/cmake/Config.in
index 64ab154..e7bd14e 100644
--- a/package/cmake/Config.in
+++ b/package/cmake/Config.in
@@ -29,6 +29,7 @@ config BR2_PACKAGE_CMAKE_CTEST
 	select BR2_PACKAGE_BZIP2
 	select BR2_PACKAGE_XZ
 	select BR2_PACKAGE_LIBUV
+	select BR2_PACKAGE_RHASH
 	help
 	  CTest is a testing tool distributed as a part of CMake. It
 	  can be used to automate updating (using CVS for example),
diff --git a/package/cmake/cmake.hash b/package/cmake/cmake.hash
index 13c0237..2aea9bc 100644
--- a/package/cmake/cmake.hash
+++ b/package/cmake/cmake.hash
@@ -1,2 +1,2 @@
-# From http://www.cmake.org/files/v3.7/cmake-3.7.2-SHA-256.txt
-sha256 dc1246c4e6d168ea4d6e042cfba577c1acd65feea27e56f5ff37df920c30cae0  cmake-3.7.2.tar.gz
+# From http://www.cmake.org/files/v3.8/cmake-3.8.1-SHA-256.txt
+sha256 ce5d9161396e06501b00e52933783150a87c33080d4bdcef461b5b7fd24ac228  cmake-3.8.1.tar.gz
diff --git a/package/cmake/cmake.mk b/package/cmake/cmake.mk
index d9eea32..10af415 100644
--- a/package/cmake/cmake.mk
+++ b/package/cmake/cmake.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-CMAKE_VERSION_MAJOR = 3.7
-CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).2
+CMAKE_VERSION_MAJOR = 3.8
+CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).1
 CMAKE_SITE = https://cmake.org/files/v$(CMAKE_VERSION_MAJOR)
 CMAKE_LICENSE = BSD-3-Clause
 CMAKE_LICENSE_FILES = Copyright.txt
@@ -22,7 +22,7 @@ CMAKE_LICENSE_FILES = Copyright.txt
 #   the system-wide libraries instead of rebuilding and statically
 #   linking with the ones bundled into the CMake sources.
 
-CMAKE_DEPENDENCIES = zlib jsoncpp libcurl libarchive expat bzip2 xz libuv
+CMAKE_DEPENDENCIES = zlib jsoncpp libcurl libarchive expat bzip2 xz libuv rhash
 
 CMAKE_CONF_OPTS = \
 	-DKWSYS_LFS_WORKS=TRUE \
-- 
2.10.2

^ permalink raw reply related

* [Buildroot] [PATCH v4 1/2] rhash: new package
From: Baruch Siach @ 2017-05-09  9:32 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170509092817.61068-1-Vincent.Riera@imgtec.com>

Hi Vicente,

On Tue, May 09, 2017 at 10:28:16AM +0100, Vicente Olivert Riera wrote:
> +ifeq ($(BR2_PACKAGE_RHASH_BIN),y)
> +# We also install the rhash console utility to the staging directory
> +# since we want it to be a superset of the target directory.

And why is that?

> +define RHASH_INSTALL_STAGING_RHASH_BIN
> +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		DESTDIR="$(STAGING_DIR)" $(RHASH_MAKE_OPTS) install-shared
> +endef
> +RHASH_POST_INSTALL_STAGING_HOOKS += RHASH_INSTALL_STAGING_RHASH_BIN
> +define RHASH_INSTALL_TARGET_RHASH_BIN
> +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		DESTDIR="$(TARGET_DIR)" $(RHASH_MAKE_OPTS) install-shared
> +endef
> +RHASH_POST_INSTALL_TARGET_HOOKS += RHASH_INSTALL_TARGET_RHASH_BIN
> +endif

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply

* [Buildroot] [PATCH v4 1/2] rhash: new package
From: Vicente Olivert Riera @ 2017-05-09  9:39 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170509093204.lkmflcffn7nrbvq3@sapphire.tkos.co.il>

Hi Baruch,

On 09/05/17 10:32, Baruch Siach wrote:
> Hi Vicente,
> 
> On Tue, May 09, 2017 at 10:28:16AM +0100, Vicente Olivert Riera wrote:
>> +ifeq ($(BR2_PACKAGE_RHASH_BIN),y)
>> +# We also install the rhash console utility to the staging directory
>> +# since we want it to be a superset of the target directory.
> 
> And why is that?

http://lists.busybox.net/pipermail/buildroot/2017-April/189827.html

"And of course it doesn't matter if you install the program in staging
as well - in fact I prefer it, ideally staging is a superset of target."

Personally, since we are now doing the installation of the rhash console
utility manually via post-install-hooks, I wouldn't install it to
staging. But Arnout said that he prefer it to be installed to staging
because ideally is a superset of target. Nobody said the opposite so I
modified the patch following Arnout's advice.

Vincent

> 
>> +define RHASH_INSTALL_STAGING_RHASH_BIN
>> +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>> +		DESTDIR="$(STAGING_DIR)" $(RHASH_MAKE_OPTS) install-shared
>> +endef
>> +RHASH_POST_INSTALL_STAGING_HOOKS += RHASH_INSTALL_STAGING_RHASH_BIN
>> +define RHASH_INSTALL_TARGET_RHASH_BIN
>> +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>> +		DESTDIR="$(TARGET_DIR)" $(RHASH_MAKE_OPTS) install-shared
>> +endef
>> +RHASH_POST_INSTALL_TARGET_HOOKS += RHASH_INSTALL_TARGET_RHASH_BIN
>> +endif
> 
> baruch
> 

^ permalink raw reply

* [Buildroot] [PATCH 1/1] ptp4l: new package
From: Petr Kulhavy @ 2017-05-09  9:42 UTC (permalink / raw)
  To: buildroot

Add the Linux PTP Project package, aka ptp4l.
http://linuxptp.sourceforge.net/

The sysV and systemd init scripts start the daemon in automatic mode on eth0.

Signed-off-by: Petr Kulhavy <brain@jikos.cz>
---
 package/Config.in           |  1 +
 package/ptp4l/Config.in     | 13 +++++++++++++
 package/ptp4l/S65ptp4l      | 29 +++++++++++++++++++++++++++++
 package/ptp4l/ptp4l.hash    |  2 ++
 package/ptp4l/ptp4l.mk      | 37 +++++++++++++++++++++++++++++++++++++
 package/ptp4l/ptp4l.service | 10 ++++++++++
 6 files changed, 92 insertions(+)
 create mode 100644 package/ptp4l/Config.in
 create mode 100755 package/ptp4l/S65ptp4l
 create mode 100644 package/ptp4l/ptp4l.hash
 create mode 100644 package/ptp4l/ptp4l.mk
 create mode 100644 package/ptp4l/ptp4l.service

diff --git a/package/Config.in b/package/Config.in
index d57813c..a59da25 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1660,6 +1660,7 @@ endif
 	source "package/proxychains-ng/Config.in"
 	source "package/ptpd/Config.in"
 	source "package/ptpd2/Config.in"
+	source "package/ptp4l/Config.in"
 	source "package/pure-ftpd/Config.in"
 	source "package/putty/Config.in"
 	source "package/quagga/Config.in"
diff --git a/package/ptp4l/Config.in b/package/ptp4l/Config.in
new file mode 100644
index 0000000..a070545
--- /dev/null
+++ b/package/ptp4l/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_PTP4L
+	bool "ptp4l / Linux PTP"
+	help
+	  The Linux PTP Project is the Precision Time Protocol implementation
+	  according to IEEE standard 1588 for Linux.
+
+	  The dual design goals are to provide a robust implementation of the
+	  standard and to use the most relevant and modern Application
+	  Programming Interfaces (API) offered by the Linux kernel. Supporting
+	  legacy APIs and other platforms is not a goal.
+
+	  http://linuxptp.sourceforge.net/
+
diff --git a/package/ptp4l/S65ptp4l b/package/ptp4l/S65ptp4l
new file mode 100755
index 0000000..6912658
--- /dev/null
+++ b/package/ptp4l/S65ptp4l
@@ -0,0 +1,29 @@
+#!/bin/sh
+#
+# Start ptp4l
+#
+
+case "$1" in
+  start)
+	printf "Starting ptp4l: "
+	start-stop-daemon -S -b -q -x /usr/sbin/ptp4l -- -A -i eth0
+	if [ $? != 0 ]; then
+		echo "FAILED"
+		exit 1
+	else
+		echo "OK"
+	fi
+	;;
+  stop)
+	printf "Stopping ptp4l: "
+	start-stop-daemon -K -q -x /usr/sbin/ptp4l
+	echo "OK"
+	;;
+  restart|reload)
+	;;
+  *)
+	echo "Usage: $0 {start|stop|restart}"
+	exit 1
+esac
+
+exit $?
diff --git a/package/ptp4l/ptp4l.hash b/package/ptp4l/ptp4l.hash
new file mode 100644
index 0000000..1ac9443
--- /dev/null
+++ b/package/ptp4l/ptp4l.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256	fa8e00f6ec73cefa7bb313dce7f60dfe5eb9e2bde3353594e9ac18edc93e5165  linuxptp-1.8.tgz
diff --git a/package/ptp4l/ptp4l.mk b/package/ptp4l/ptp4l.mk
new file mode 100644
index 0000000..49d083d
--- /dev/null
+++ b/package/ptp4l/ptp4l.mk
@@ -0,0 +1,37 @@
+################################################################################
+#
+# ptp4l
+#
+################################################################################
+
+PTP4L_VERSION = 1.8
+PTP4L_SOURCE = linuxptp-$(PTP4L_VERSION).tgz
+PTP4L_SITE = http://sourceforge.net/projects/linuxptp/files/v$(PTP4L_VERSION)
+PTP4L_LICENSE = GPLv2
+PTP4L_LICENSE_FILES = COPYING
+PTP4L_CFLAGS = $(TARGET_CFLAGS)
+
+
+define PTP4L_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) KBUILD_OUTPUT=$(TARGET_DIR) CC=$(TARGET_CC) EXTRA_CFLAGS="$(PTP4L_CFLAGS)" -C $(@D) all
+endef
+
+define PTP4L_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) prefix=$(TARGET_DIR)/usr $(TARGET_CONFIGURE_OPTS) -C $(@D) install
+endef
+
+define PTP4L_INSTALL_INIT_SYSV
+	$(INSTALL) -m 755 -D $(@D)/package/ptp4l/S65ptp4l \
+		$(TARGET_DIR)/etc/init.d/S65ptp4l
+endef
+
+define PTP4L_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -D -m 644 $(PTP4L_PKGDIR)/ptp4l.service \
+		$(TARGET_DIR)/usr/lib/systemd/system/ptp4l.service
+	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
+	ln -sf ../../../../usr/lib/systemd/system/ptp4l.service \
+		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/ptp4l.service
+endef
+
+$(eval $(generic-package))
+
diff --git a/package/ptp4l/ptp4l.service b/package/ptp4l/ptp4l.service
new file mode 100644
index 0000000..ec6bbc5
--- /dev/null
+++ b/package/ptp4l/ptp4l.service
@@ -0,0 +1,10 @@
+[Unit]
+Description=Precision Time Protocol daemon
+After=syslog.target network.target
+
+[Service]
+ExecStart=/usr/sbin/ptp4l -A -i eth0
+Restart=always
+
+[Install]
+WantedBy=multi-user.target
-- 
2.7.4

^ permalink raw reply related

* [Buildroot] [PATCH next] python-pytablewriter: bump version to 0.19.5
From: Vicente Olivert Riera @ 2017-05-09  9:43 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/python-pytablewriter/python-pytablewriter.hash | 4 ++--
 package/python-pytablewriter/python-pytablewriter.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/python-pytablewriter/python-pytablewriter.hash b/package/python-pytablewriter/python-pytablewriter.hash
index 80a9a02..eefcb3a 100644
--- a/package/python-pytablewriter/python-pytablewriter.hash
+++ b/package/python-pytablewriter/python-pytablewriter.hash
@@ -1,3 +1,3 @@
 # md5 from https://pypi.python.org/pypi/pytablewriter/json, sha256 locally computed
-md5 c63d4d14836ae291e11448219abdf348  pytablewriter-0.17.2.tar.gz
-sha256 629ecb7bfe3fb033427e02e0291270d13ff14bfc4caf2cac66b797ac5aea5fd1  pytablewriter-0.17.2.tar.gz
+md5 fb404abd5a6aab2d8da8c93f24c9c974  pytablewriter-0.19.5.tar.gz
+sha256 0f06a73fc13fea7d6004ec9d96f2aeef920defaee1704268558a45e97455d35a  pytablewriter-0.19.5.tar.gz
diff --git a/package/python-pytablewriter/python-pytablewriter.mk b/package/python-pytablewriter/python-pytablewriter.mk
index 2788c85..50e85c2 100644
--- a/package/python-pytablewriter/python-pytablewriter.mk
+++ b/package/python-pytablewriter/python-pytablewriter.mk
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-PYTHON_PYTABLEWRITER_VERSION = 0.17.2
+PYTHON_PYTABLEWRITER_VERSION = 0.19.5
 PYTHON_PYTABLEWRITER_SOURCE = pytablewriter-$(PYTHON_PYTABLEWRITER_VERSION).tar.gz
-PYTHON_PYTABLEWRITER_SITE = https://pypi.python.org/packages/47/5c/cbfed107164e56a6739d52694c4c584635970d6621b7e531464e89534956
+PYTHON_PYTABLEWRITER_SITE = https://pypi.python.org/packages/db/c6/517cb51aee3c83b7eb60353f818aab0f39d310c925ea103cc54c0e0f8cd2
 PYTHON_PYTABLEWRITER_SETUP_TYPE = setuptools
 PYTHON_PYTABLEWRITER_LICENSE = MIT
 PYTHON_PYTABLEWRITER_LICENSE_FILES = LICENSE
-- 
2.10.2

^ permalink raw reply related

* [Buildroot] Analysis of build results for 2017-05-08
From: Thomas Petazzoni @ 2017-05-09  9:46 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <CAGm1_ktz8-x5g=bHt9-Hi88Vo3eb_VyR2TmaamLcKwNzB5PGWQ@mail.gmail.com>

Hello,

On Tue, 9 May 2017 11:20:19 +0200, Yegor Yefremov wrote:

> > error: Name clash for '<pstage/lib>libboost_system.a'
> >
> > Yegor, you are in the DEVELOPERS file for Boost, could you have a look ?  
> 
> OMG I'm the only one registered as DEVELOPER for boost.

Good luck :-)

Feel free to find other volunteers to maintain this wonderful package!

> This situation seems to occur, when both iconv and icu are selected:
> 
>     - iconv (libc)             : yes
>     - icu                      : yes
> 
> Need to dig further.

Great, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply

* [Buildroot] [PATCH v4 1/2] rhash: new package
From: Baruch Siach @ 2017-05-09  9:58 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <73eae06b-1366-527c-7034-05da7d9e7631@imgtec.com>

Hi Vicente,

On Tue, May 09, 2017 at 10:39:00AM +0100, Vicente Olivert Riera wrote:
> On 09/05/17 10:32, Baruch Siach wrote:
> > On Tue, May 09, 2017 at 10:28:16AM +0100, Vicente Olivert Riera wrote:
> >> +ifeq ($(BR2_PACKAGE_RHASH_BIN),y)
> >> +# We also install the rhash console utility to the staging directory
> >> +# since we want it to be a superset of the target directory.
> > 
> > And why is that?
> 
> http://lists.busybox.net/pipermail/buildroot/2017-April/189827.html
> 
> "And of course it doesn't matter if you install the program in staging
> as well - in fact I prefer it, ideally staging is a superset of target."
> 
> Personally, since we are now doing the installation of the rhash console
> utility manually via post-install-hooks, I wouldn't install it to
> staging. But Arnout said that he prefer it to be installed to staging
> because ideally is a superset of target. Nobody said the opposite so I
> modified the patch following Arnout's advice.

I remember that discussion now. It somehow made sense to me at the time, but 
not anymore. As I understand it, staging is a build time facility. Why would 
we like target only binaries installed there?

> >> +define RHASH_INSTALL_STAGING_RHASH_BIN
> >> +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> >> +		DESTDIR="$(STAGING_DIR)" $(RHASH_MAKE_OPTS) install-shared
> >> +endef
> >> +RHASH_POST_INSTALL_STAGING_HOOKS += RHASH_INSTALL_STAGING_RHASH_BIN
> >> +define RHASH_INSTALL_TARGET_RHASH_BIN
> >> +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> >> +		DESTDIR="$(TARGET_DIR)" $(RHASH_MAKE_OPTS) install-shared
> >> +endef
> >> +RHASH_POST_INSTALL_TARGET_HOOKS += RHASH_INSTALL_TARGET_RHASH_BIN
> >> +endif

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply

* [Buildroot] [PATCH next] imagemagick: bump version to 7.0.5-5
From: Vicente Olivert Riera @ 2017-05-09  9:59 UTC (permalink / raw)
  To: buildroot

0001 patch already included in this release:
  https://github.com/ImageMagick/ImageMagick/commit/b218117cad34d39b9ffb587b45c71c5a49b12bde

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
Note to maintainer:
I haven't marked this patch as a security patch because the sercurity
issue was already fixed by 0001 patch. Because of that, I haven't
considered this patch to be necessary for the master branch.
If you don't agree with those reasons, please feel free to do any
changes you want :-)
---
 ...ub.com-ImageMagick-ImageMagick-issues-415.patch | 52 ----------------------
 package/imagemagick/imagemagick.hash               |  2 +-
 package/imagemagick/imagemagick.mk                 |  2 +-
 3 files changed, 2 insertions(+), 54 deletions(-)
 delete mode 100644 package/imagemagick/0001-https-github.com-ImageMagick-ImageMagick-issues-415.patch

diff --git a/package/imagemagick/0001-https-github.com-ImageMagick-ImageMagick-issues-415.patch b/package/imagemagick/0001-https-github.com-ImageMagick-ImageMagick-issues-415.patch
deleted file mode 100644
index 943679e..0000000
--- a/package/imagemagick/0001-https-github.com-ImageMagick-ImageMagick-issues-415.patch
+++ /dev/null
@@ -1,52 +0,0 @@
-From b218117cad34d39b9ffb587b45c71c5a49b12bde Mon Sep 17 00:00:00 2001
-From: Cristy <urban-warrior@imagemagick.org>
-Date: Fri, 31 Mar 2017 15:24:33 -0400
-Subject: [PATCH] https://github.com/ImageMagick/ImageMagick/issues/415
-
-Fixes CVE-2017-7606
-
-Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
----
- coders/pnm.c | 2 +-
- coders/rle.c | 5 +++--
- 2 files changed, 4 insertions(+), 3 deletions(-)
-
-diff --git a/coders/pnm.c b/coders/pnm.c
-index 9a1221d79..c525ebb8f 100644
---- a/coders/pnm.c
-+++ b/coders/pnm.c
-@@ -1979,7 +1979,7 @@ static MagickBooleanType WritePNMImage(const ImageInfo *image_info,Image *image,
-                           pixel=ScaleQuantumToChar(GetPixelRed(image,p));
-                         else
-                           pixel=ScaleQuantumToAny(GetPixelRed(image,p),
--                          max_value);
-+                            max_value);
-                       }
-                     q=PopCharPixel((unsigned char) pixel,q);
-                     p+=GetPixelChannels(image);
-diff --git a/coders/rle.c b/coders/rle.c
-index 2318901ec..ec071dc7b 100644
---- a/coders/rle.c
-+++ b/coders/rle.c
-@@ -271,7 +271,8 @@ static Image *ReadRLEImage(const ImageInfo *image_info,ExceptionInfo *exception)
-         p=colormap;
-         for (i=0; i < (ssize_t) number_colormaps; i++)
-           for (x=0; x < (ssize_t) map_length; x++)
--            *p++=(unsigned char) ScaleShortToQuantum(ReadBlobLSBShort(image));
-+            *p++=(unsigned char) ScaleQuantumToChar(ScaleShortToQuantum(
-+              ReadBlobLSBShort(image)));
-       }
-     if ((flags & 0x08) != 0)
-       {
-@@ -476,7 +477,7 @@ static Image *ReadRLEImage(const ImageInfo *image_info,ExceptionInfo *exception)
-               for (x=0; x < (ssize_t) number_planes; x++)
-               {
-                 ValidateColormapValue(image,(size_t) (x*map_length+
--                    (*p & mask)),&index,exception);
-+                  (*p & mask)),&index,exception);
-                 *p=colormap[(ssize_t) index];
-                 p++;
-               }
--- 
-2.11.0
-
diff --git a/package/imagemagick/imagemagick.hash b/package/imagemagick/imagemagick.hash
index ff7b24a..06a957a 100644
--- a/package/imagemagick/imagemagick.hash
+++ b/package/imagemagick/imagemagick.hash
@@ -1,2 +1,2 @@
 # From http://www.imagemagick.org/download/releases/digest.rdf
-sha256 4a1dde5bdfec0fc549955a051be25b7ff96dfb192060997699e43c7ce0f06ab2  ImageMagick-7.0.5-4.tar.xz
+sha256 c3644119dce993aa241fa08eced2cb6043fb5345f0eee7a7822a497f1142ebe3  ImageMagick-7.0.5-5.tar.xz
diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk
index 9bef6f7..6b5cd4e 100644
--- a/package/imagemagick/imagemagick.mk
+++ b/package/imagemagick/imagemagick.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-IMAGEMAGICK_VERSION = 7.0.5-4
+IMAGEMAGICK_VERSION = 7.0.5-5
 IMAGEMAGICK_SOURCE = ImageMagick-$(IMAGEMAGICK_VERSION).tar.xz
 IMAGEMAGICK_SITE = http://www.imagemagick.org/download/releases
 IMAGEMAGICK_LICENSE = Apache-2.0
-- 
2.10.2

^ permalink raw reply related

* [Buildroot] [PATCH next] xfsprogs: bump version to 4.11.0
From: Vicente Olivert Riera @ 2017-05-09 10:08 UTC (permalink / raw)
  To: buildroot

0003 patch already included in this release:
  https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/commit?id=0a71e38396304b4d1215ba0b51cd6ce8e33eb40d

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 ...3-xfsprogs-don-t-use-CFLAGS-with-BUILD_CC.patch | 38 ----------------------
 package/xfsprogs/xfsprogs.hash                     |  5 ++-
 package/xfsprogs/xfsprogs.mk                       |  2 +-
 3 files changed, 3 insertions(+), 42 deletions(-)
 delete mode 100644 package/xfsprogs/0003-xfsprogs-don-t-use-CFLAGS-with-BUILD_CC.patch

diff --git a/package/xfsprogs/0003-xfsprogs-don-t-use-CFLAGS-with-BUILD_CC.patch b/package/xfsprogs/0003-xfsprogs-don-t-use-CFLAGS-with-BUILD_CC.patch
deleted file mode 100644
index 36896b5..0000000
--- a/package/xfsprogs/0003-xfsprogs-don-t-use-CFLAGS-with-BUILD_CC.patch
+++ /dev/null
@@ -1,38 +0,0 @@
-From b981adb6769f6b7d80f6c98627391398a007a25b Mon Sep 17 00:00:00 2001
-From: Gustavo Zacarias <gustavo@zacarias.com.ar>
-Date: Tue, 15 Dec 2015 20:51:35 -0300
-Subject: [PATCH] xfsprogs: don't use CFLAGS with BUILD_CC
-
-When cross-compiling CFLAGS might not be suitable for the host
-(BUILD_CC) compiler since it might contain arch-specific options.
-
-Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
----
- libxfs/Makefile | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/libxfs/Makefile b/libxfs/Makefile
-index e021625..ad76a04 100644
---- a/libxfs/Makefile
-+++ b/libxfs/Makefile
-@@ -118,7 +118,7 @@ default: ltdepend $(LTLIBRARY)
- 
- crc32table.h: gen_crc32table.c
- 	@echo "    [CC]     gen_crc32table"
--	$(Q) $(BUILD_CC) $(CFLAGS) -o gen_crc32table $<
-+	$(Q) $(BUILD_CC) -o gen_crc32table $<
- 	@echo "    [GENERATE] $@"
- 	$(Q) ./gen_crc32table > crc32table.h
- 
-@@ -129,7 +129,7 @@ crc32table.h: gen_crc32table.c
- # disk.
- crc32selftest: gen_crc32table.c crc32table.h crc32.c
- 	@echo "    [TEST]    CRC32"
--	$(Q) $(BUILD_CC) $(CFLAGS) -D CRC32_SELFTEST=1 crc32.c -o $@
-+	$(Q) $(BUILD_CC) -D CRC32_SELFTEST=1 crc32.c -o $@
- 	$(Q) ./$@
- 
- # set up include/xfs header directory
--- 
-2.7.4
-
diff --git a/package/xfsprogs/xfsprogs.hash b/package/xfsprogs/xfsprogs.hash
index e990b78..edb2933 100644
--- a/package/xfsprogs/xfsprogs.hash
+++ b/package/xfsprogs/xfsprogs.hash
@@ -1,3 +1,2 @@
-# Locally calculated after checking pgp signature:
-#   https://www.kernel.org/pub/linux/utils/fs/xfs/xfsprogs/xfsprogs-4.8.0.tar.sign
-sha256 82ce9cb3a55f4e208e8fe3471ff0aff0602b8300f3e50bdf05cc7e11549686f9  xfsprogs-4.8.0.tar.xz
+# From https://www.kernel.org/pub/linux/utils/fs/xfs/xfsprogs/sha256sums.asc
+sha256 c3a6d87b564d7738243c507df82276bed982265e345363a95f2c764e8a5f5bb2  xfsprogs-4.11.0.tar.xz
diff --git a/package/xfsprogs/xfsprogs.mk b/package/xfsprogs/xfsprogs.mk
index c110733..ed56d34 100644
--- a/package/xfsprogs/xfsprogs.mk
+++ b/package/xfsprogs/xfsprogs.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-XFSPROGS_VERSION = 4.8.0
+XFSPROGS_VERSION = 4.11.0
 XFSPROGS_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/fs/xfs/xfsprogs
 XFSPROGS_SOURCE = xfsprogs-$(XFSPROGS_VERSION).tar.xz
 
-- 
2.10.2

^ permalink raw reply related

* [Buildroot] [PATCH next 1/2] python-pillow: bump version to 4.1.1
From: Vicente Olivert Riera @ 2017-05-09 11:15 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/python-pillow/python-pillow.hash | 4 ++--
 package/python-pillow/python-pillow.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/python-pillow/python-pillow.hash b/package/python-pillow/python-pillow.hash
index 322e0a9..55b0709 100644
--- a/package/python-pillow/python-pillow.hash
+++ b/package/python-pillow/python-pillow.hash
@@ -1,3 +1,3 @@
 # md5 from https://pypi.python.org/pypi/pillow/json, sha256 locally computed
-md5 d040e1155b4d9d8b011aab67ee0ea86b  Pillow-4.1.0.tar.gz
-sha256 a0fd487fed4a35717401b7566e51a1520b34e7c0f7f2a315a6509f82bc86299f  Pillow-4.1.0.tar.gz
+md5 f2565954955c8d10f3b4f1f72f852bf7  Pillow-4.1.1.tar.gz
+sha256 00b6a5f28d00f720235a937ebc2f50f4292a5c7e2d6ab9a8b26153b625c4f431  Pillow-4.1.1.tar.gz
diff --git a/package/python-pillow/python-pillow.mk b/package/python-pillow/python-pillow.mk
index e1167c8..d6914c3 100644
--- a/package/python-pillow/python-pillow.mk
+++ b/package/python-pillow/python-pillow.mk
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-PYTHON_PILLOW_VERSION = 4.1.0
+PYTHON_PILLOW_VERSION = 4.1.1
 PYTHON_PILLOW_SOURCE = Pillow-$(PYTHON_PILLOW_VERSION).tar.gz
-PYTHON_PILLOW_SITE = https://pypi.python.org/packages/80/38/5cb561c68155834c596018c47caa44da88ed34b09579b921c0e493fb06c7
+PYTHON_PILLOW_SITE = https://pypi.python.org/packages/93/73/66854f63b1941aad9af18a1de59f9cf95ad1a87c801540222e332f6688d7
 PYTHON_PILLOW_LICENSE = PIL Software License
 PYTHON_PILLOW_LICENSE_FILES = LICENSE
 PYTHON_PILLOW_SETUP_TYPE = setuptools
-- 
2.10.2

^ permalink raw reply related

* [Buildroot] [PATCH next 2/2] python-dataproperty: bump version to 0.21.1
From: Vicente Olivert Riera @ 2017-05-09 11:15 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170509111513.64192-1-Vincent.Riera@imgtec.com>

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/python-dataproperty/python-dataproperty.hash | 4 ++--
 package/python-dataproperty/python-dataproperty.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/python-dataproperty/python-dataproperty.hash b/package/python-dataproperty/python-dataproperty.hash
index 1ab0a40..ad88498 100644
--- a/package/python-dataproperty/python-dataproperty.hash
+++ b/package/python-dataproperty/python-dataproperty.hash
@@ -1,3 +1,3 @@
 # md5 from https://pypi.python.org/pypi/dataproperty/json, sha256 locally computed
-md5 70199d3e6e021810d0d3b4a42c37916f  DataProperty-0.18.1.tar.gz
-sha256 950131bd9fb874be606835e5f4a84d99f505d919aed94145932ec010190c7c66  DataProperty-0.18.1.tar.gz
+md5 89e78396b91e6156c522175b3316546f  DataProperty-0.21.1.tar.gz
+sha256 7a5c77004e8f1bca734838966e30e555e323c06bda613ed3985fa9bef2665c71  DataProperty-0.21.1.tar.gz
diff --git a/package/python-dataproperty/python-dataproperty.mk b/package/python-dataproperty/python-dataproperty.mk
index 7e34425..d9d0783 100644
--- a/package/python-dataproperty/python-dataproperty.mk
+++ b/package/python-dataproperty/python-dataproperty.mk
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-PYTHON_DATAPROPERTY_VERSION = 0.18.1
+PYTHON_DATAPROPERTY_VERSION = 0.21.1
 PYTHON_DATAPROPERTY_SOURCE = DataProperty-$(PYTHON_DATAPROPERTY_VERSION).tar.gz
-PYTHON_DATAPROPERTY_SITE = https://pypi.python.org/packages/42/b6/591366869e9fc7b19420ca4c177727f25dcccc07a46cecbda8d6abffa866
+PYTHON_DATAPROPERTY_SITE = https://pypi.python.org/packages/fc/9a/e6cc202b81b02aec39f35f2d13a6efc349cdc62ae3890f84b586468597ad
 PYTHON_DATAPROPERTY_SETUP_TYPE = setuptools
 PYTHON_DATAPROPERTY_LICENSE = MIT
 PYTHON_DATAPROPERTY_LICENSE_FILES = LICENSE
-- 
2.10.2

^ permalink raw reply related

* [Buildroot] [PATCH 1/1] ptp4l: new package
From: Thomas Petazzoni @ 2017-05-09 11:51 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <1494322944-22289-1-git-send-email-brain@jikos.cz>

Hello Petr,

Thanks for this contribution! Looks mostly good, just a few comments,
see below.

On Tue,  9 May 2017 11:42:24 +0200, Petr Kulhavy wrote:

>  package/Config.in           |  1 +
>  package/ptp4l/Config.in     | 13 +++++++++++++
>  package/ptp4l/S65ptp4l      | 29 +++++++++++++++++++++++++++++
>  package/ptp4l/ptp4l.hash    |  2 ++
>  package/ptp4l/ptp4l.mk      | 37 +++++++++++++++++++++++++++++++++++++
>  package/ptp4l/ptp4l.service | 10 ++++++++++

Could you add yourself to the DEVELOPERS file for this package?

> diff --git a/package/ptp4l/Config.in b/package/ptp4l/Config.in
> new file mode 100644
> index 0000000..a070545
> --- /dev/null
> +++ b/package/ptp4l/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_PTP4L
> +	bool "ptp4l / Linux PTP"

Just:

	bool "ptp4l"

> +	help
> +	  The Linux PTP Project is the Precision Time Protocol implementation
> +	  according to IEEE standard 1588 for Linux.
> +
> +	  The dual design goals are to provide a robust implementation of the
> +	  standard and to use the most relevant and modern Application
> +	  Programming Interfaces (API) offered by the Linux kernel. Supporting
> +	  legacy APIs and other platforms is not a goal.
> +
> +	  http://linuxptp.sourceforge.net/
> +

Unneeded empty new line.

> +case "$1" in
> +  start)
> +	printf "Starting ptp4l: "
> +	start-stop-daemon -S -b -q -x /usr/sbin/ptp4l -- -A -i eth0
> +	if [ $? != 0 ]; then
> +		echo "FAILED"
> +		exit 1
> +	else
> +		echo "OK"
> +	fi

Use:

	[ $? = 0 ] && echo "OK" || echo "FAIL"

Also, please specify a PID file using:

	-p /var/run/ptp4l.pid

> +  stop)
> +	printf "Stopping ptp4l: "
> +	start-stop-daemon -K -q -x /usr/sbin/ptp4l

And use the PID file here as well.

> +  restart|reload)
> +	;;

Nothing?

> +PTP4L_VERSION = 1.8
> +PTP4L_SOURCE = linuxptp-$(PTP4L_VERSION).tgz
> +PTP4L_SITE = http://sourceforge.net/projects/linuxptp/files/v$(PTP4L_VERSION)
> +PTP4L_LICENSE = GPLv2

You should use SPDX license code, so instead of GPLv2 it should be
GPL-2.0.

However, after checking the actual tarball, it seems like the license
is GPL-2.0+ (i.e GPLv2 or later).

> +PTP4L_LICENSE_FILES = COPYING
> +PTP4L_CFLAGS = $(TARGET_CFLAGS)

Why is this variable useful?

> +
> +

One too many empty new line.

> +define PTP4L_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) KBUILD_OUTPUT=$(TARGET_DIR) CC=$(TARGET_CC) EXTRA_CFLAGS="$(PTP4L_CFLAGS)" -C $(@D) all

Just use TARGET_CFLAGS instead of PTP4L_CFLAGS.

Also, split this line that is a bit too long.

What is KBUILD_OUTPUT used for ?

> +endef
> +
> +define PTP4L_INSTALL_TARGET_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) prefix=$(TARGET_DIR)/usr $(TARGET_CONFIGURE_OPTS) -C $(@D) install

Please use instead:

	prefix=/usr DESTDIR=$(TARGET_DIR)

Why are you passing TARGET_CONFIGURE_OPTS at install time and not build
time ?

> +endef
> +
> +define PTP4L_INSTALL_INIT_SYSV
> +	$(INSTALL) -m 755 -D $(@D)/package/ptp4l/S65ptp4l \
> +		$(TARGET_DIR)/etc/init.d/S65ptp4l
> +endef
> +
> +define PTP4L_INSTALL_INIT_SYSTEMD
> +	$(INSTALL) -D -m 644 $(PTP4L_PKGDIR)/ptp4l.service \
> +		$(TARGET_DIR)/usr/lib/systemd/system/ptp4l.service
> +	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> +	ln -sf ../../../../usr/lib/systemd/system/ptp4l.service \
> +		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/ptp4l.service
> +endef
> +
> +$(eval $(generic-package))
> +

Useless empty new line.

Final questions/comments:

 - Why is your package named ptp4l and not linuxptp like the upstream
   tarball/project ?

 - Make sure to run support/scripts/check-package (to verify that there
   are no coding style issues in your package) and
   support/scripts/test-pkg (to make sure your package builds fine with
   all toolchains).

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply

* [Buildroot] [PATCH 1/1] ptp4l: new package
From: Petr Kulhavy @ 2017-05-09 12:31 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170509135119.242c028e@free-electrons.com>

Hi Thomas,

thank you for your review, I will do the corrections as per your 
suggestions and submit a new version of the patch.

Regarding the name you are correctly pointing out that the official web 
is called "Linux PTP Package".
However there are several other PTP implementations for Linux (ptpd, 
ptpd2) and in this context I find the name a bit too generic.
So I named the package after the "ptp4l" daemon, which is also the name 
used by few others to refer this package (e.g. Redhat or some 
conferences about PTP).
I'm however a bit undecided which name is better...


On 09/05/17 13:51, Thomas Petazzoni wrote:
> On Tue,  9 May 2017 11:42:24 +0200, Petr Kulhavy wrote:
>
>> +PTP4L_LICENSE_FILES = COPYING
>> +PTP4L_CFLAGS = $(TARGET_CFLAGS)
> Why is this variable useful?
>
> What is KBUILD_OUTPUT used for ?
>
>> +endef
>> +
>> +define PTP4L_INSTALL_TARGET_CMDS
>> +	$(TARGET_MAKE_ENV) $(MAKE) prefix=$(TARGET_DIR)/usr $(TARGET_CONFIGURE_OPTS) -C $(@D) install
> Please use instead:
>
> 	prefix=/usr DESTDIR=$(TARGET_DIR)
>
> Why are you passing TARGET_CONFIGURE_OPTS at install time and not build
> time ?
This is due to the unfortunate way the package's makefile is build:
The makefile calls the script incdefs.sh to detect some features and set 
the corresponding -Dxxxx flags in CFLAGS .
Unless KBUILD_OUTPUT is set the script searches in /usr/include, i.e. on 
host machine.

The makefile constructs its own CFLAGS based on the above and the 
environment CFLAGS are expected to be in EXTRA_CFLAGS.
So if CFLAGS are set on the make's command-line make doesn't call the 
incdefs.sh script and the detection and possibly the compilation fails.

That's why I couldn't use the TARGET_CONFIGURE_OPTS for the build phase.
However I left it as standard for the install phase.

I'm not sure if what I did is 100% clean, but it seems to work :-)

Petr

^ permalink raw reply

* [Buildroot] Upgrading Erlang and ejabberd
From: Frank Hunleth @ 2017-05-09 13:07 UTC (permalink / raw)
  To: buildroot

Hi all,

I'd very much like to update the version of Erlang used in Buildroot.
I had been doing this quite a while ago, but stopped pushing my
changes upstream due to ejabberd breaking. I don't use ejabberd.
Updating it and all of its dependencies to work with more recent
Erlang versions is turning out to be quite a bit of work and I don't
know how to test it to make sure that I didn't break anything.

Erlang 20 will be released soon and it has some really interesting
improvements that would be great to have available by default in
Buildroot. (BR currently has Erlang 18.3; 19.3 is the current
release). Is there anyone out there who would mind helping update
ejabberd? Johan - you're listed as the ejabberd package maintainer,
could you help? Or if not Johan, is anyone else interested?

Thanks,
Frank

^ permalink raw reply

* [Buildroot] Upgrading Erlang and ejabberd
From: Peter Korsgaard @ 2017-05-09 13:44 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <CA+-urNQWNUXKHZdjvkcijZYW0OQJr3DMtgQNZmhThC-TssdnNw@mail.gmail.com>

>>>>> "Frank" == Frank Hunleth <fhunleth@troodon-software.com> writes:

Hi Frank,

 > I'd very much like to update the version of Erlang used in Buildroot.
 > I had been doing this quite a while ago, but stopped pushing my
 > changes upstream due to ejabberd breaking. I don't use ejabberd.
 > Updating it and all of its dependencies to work with more recent
 > Erlang versions is turning out to be quite a bit of work and I don't
 > know how to test it to make sure that I didn't break anything.

 > Erlang 20 will be released soon and it has some really interesting
 > improvements that would be great to have available by default in
 > Buildroot. (BR currently has Erlang 18.3; 19.3 is the current
 > release). Is there anyone out there who would mind helping update
 > ejabberd? Johan - you're listed as the ejabberd package maintainer,
 > could you help? Or if not Johan, is anyone else interested?

Added Johan in To:.

Thanks for bringing it up, it would indeed be good to get our erlang
package updated. In the worst case, if nobody wants to do the work to
keep ejabberd uptodate and compatible with newer erlang versions then I
think the way forward is to drop the ejabberd package.

-- 
Bye, Peter Korsgaard

^ permalink raw reply

* [Buildroot] Buildroot defconfig failures
From: ren_guo @ 2017-05-09 13:49 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <2a49a86b-da86-6e7e-df4d-bf857d3ee66c@mind.be>


>   You can just create a gitlab account, fork the official gitlab buildroot
> repository, modify .gitlab-ci.yml and push it. The you use the real gitlab
> server for you debugging.
>
>   You can do this on a branch that you delete later to "forget" about this
> debugging run.
>
>   Regards,
>   Arnout
>
Thx, nice tips!

-- 
Guo Ren, Software Engineer, C-SKY
3 XiDoumen Rd,BldgA,15F,Hangzhou,China
P.C: 310012
http://www.c-sky.com

^ permalink raw reply

* [Buildroot] [git commit] mpir: fix build on ARM with old binutils versions
From: Peter Korsgaard @ 2017-05-09 15:02 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=4c0fdc6730459a225d5a61e8e699ce9329c99f19
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Old binutils versions are affected by a bug when the assembly code has
whitespace between [ ] signs, causing a build failure of the mpir
package with ARM toolchains using such old binutils versions.

This commit fixes that by adding a patch that removes those whitespaces.

Fixes:

 - http://autobuild.buildroot.net/results/ec67ffdef74b9a61d0491e71f8cb2f8f0b6daa50/
   armv7-ctng-linux-gnueabihf Crosstool-NG toolchain

 - http://autobuild.buildroot.net/results/2e4a27af60065db51aca9e69701bc191d24b2209/
   armv5-ctng-linux-gnueabi Crosstool-NG toolchain

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 ...rm-udiv.asm-workaround-binutils-bug-14887.patch | 40 ++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/package/mpir/0001-mpn-arm-udiv.asm-workaround-binutils-bug-14887.patch b/package/mpir/0001-mpn-arm-udiv.asm-workaround-binutils-bug-14887.patch
new file mode 100644
index 0000000..6a6f467
--- /dev/null
+++ b/package/mpir/0001-mpn-arm-udiv.asm-workaround-binutils-bug-14887.patch
@@ -0,0 +1,40 @@
+From d858ce52d1971cb4e8500b0ebc0472fdae4686ec Mon Sep 17 00:00:00 2001
+From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+Date: Sun, 7 May 2017 23:12:04 +0200
+Subject: [PATCH] mpn/arm/udiv.asm: workaround binutils bug #14887
+
+Old binutils versions are affected by bug #14887,
+https://sourceware.org/bugzilla/show_bug.cgi?id=14887, which causes a
+build failure when a register specification is surrounded by
+whitespaces. Removing those whitespaces works around the issue.
+
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+---
+ mpn/arm/udiv.asm | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/mpn/arm/udiv.asm b/mpn/arm/udiv.asm
+index 25197a6..ed11eb3 100644
+--- a/mpn/arm/udiv.asm
++++ b/mpn/arm/udiv.asm
+@@ -50,7 +50,7 @@ L(oop):	divstep(n1,n0,d)
+ 	teq	r12, #0
+ 	bne	L(oop)
+ 
+-	str	n1, [ rem_ptr ]		C store remainder
++	str	n1, [rem_ptr]		C store remainder
+ 	adc	r0, n0, n0		C quotient: add last carry from divstep
+ 	mov	pc, lr
+ 
+@@ -89,7 +89,7 @@ L(oop2):
+ 	addcs	n0, n0, #1		C adjust quotient
+ 
+ L(_even_divisor):
+-	str	n1, [ rem_ptr ]		C store remainder
++	str	n1, [rem_ptr]		C store remainder
+ 	mov	r0, n0			C quotient
+ 	ldmfd	sp!, { r8, pc }
+ EPILOGUE(mpn_udiv_qrnnd)
+-- 
+2.7.4
+

^ permalink raw reply related

* [Buildroot] [git commit] mpir: fix build on ARM Thumb-only platforms
From: Peter Korsgaard @ 2017-05-09 15:03 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=fa3fbeb1bf4b0d3bed85bbeab4bd0f7b1c13e21a
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The optimized ARM assembly code is not suitable for Thumb-only
platforms, so use the generic code in such situations.

Fixes:

  http://autobuild.buildroot.net/results/4d7f2a1326f75e11693bdd51ad274079b0dd0ce4/
  (ARM Cortex-M4 toolchain)

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/mpir/mpir.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
index b7f3829..cf17502 100644
--- a/package/mpir/mpir.mk
+++ b/package/mpir/mpir.mk
@@ -20,4 +20,10 @@ ifeq ($(BR2_MIPS_NABI64),y)
 MPIR_CONF_OPTS += ABI=64
 endif
 
+# The optimized ARM assembly code uses ARM-only (i.e not Thumb1/2
+# compatible) instructions.
+ifeq ($(BR2_arm)$(BR2_armeb):$(BR2_ARM_CPU_HAS_ARM),y:)
+MPIR_CONF_ENV += MPN_PATH="generic"
+endif
+
 $(eval $(autotools-package))

^ permalink raw reply related

* [Buildroot] [git commit] mpir: fix build on mips32r6/mips64r6
From: Peter Korsgaard @ 2017-05-09 15:03 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=ef9eebf65f554d9aacfd420600c8ba17787151a8
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The optimized mips32 and mips64 assembly code is not compatible with
mips32r6/mips64r6, so use the generic code of MPIR on such platforms.

Fixes:

 - http://autobuild.buildroot.net/results/db2542a2ec3029eda81738a7ae5faeb9ea4aedee/
   mips32r6 toolchain

 - http://autobuild.buildroot.net/results/50b94e6d0dbc33664c6bfe06f83b211083aa07f7/
   mips64r6 toolchain

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/mpir/mpir.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
index cf17502..03f21d8 100644
--- a/package/mpir/mpir.mk
+++ b/package/mpir/mpir.mk
@@ -26,4 +26,9 @@ ifeq ($(BR2_arm)$(BR2_armeb):$(BR2_ARM_CPU_HAS_ARM),y:)
 MPIR_CONF_ENV += MPN_PATH="generic"
 endif
 
+# Optimized mips32/mips64 code not suitable for mips32r6/mips64r6
+ifeq ($(BR2_mips_32r6)$(BR2_mips_64r6),y)
+MPIR_CONF_ENV += MPN_PATH="generic"
+endif
+
 $(eval $(autotools-package))

^ permalink raw reply related

* [Buildroot] [git commit] mpir: fix build on powerpc64le
From: Peter Korsgaard @ 2017-05-09 15:04 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=c1d1879abaa4f5c7c9c8f0d7304ebb683dc9c679
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The optimized powerpc64 code is not compatible with powerpc64le, so use
the generic MPIR code on powerpc64le.

Fixes:

   http://autobuild.buildroot.net/results/17e523be894b60d7a9b2a3303f02c3fb34816828/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/mpir/mpir.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
index 03f21d8..697e838 100644
--- a/package/mpir/mpir.mk
+++ b/package/mpir/mpir.mk
@@ -31,4 +31,9 @@ ifeq ($(BR2_mips_32r6)$(BR2_mips_64r6),y)
 MPIR_CONF_ENV += MPN_PATH="generic"
 endif
 
+# Optimized powerpc64 code is not suitable for powerpc64le
+ifeq ($(BR2_powerpc64le),y)
+MPIR_CONF_ENV += MPN_PATH="generic"
+endif
+
 $(eval $(autotools-package))

^ permalink raw reply related

* [Buildroot] [PATCH 1/1] ptp4l: new package
From: Danomi Manchego @ 2017-05-09 15:10 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <1494322944-22289-1-git-send-email-brain@jikos.cz>

Petr,

On Tue, May 9, 2017 at 5:42 AM, Petr Kulhavy <brain@jikos.cz> wrote:
<snip>
> +PTP4L_CFLAGS = $(TARGET_CFLAGS)
> +
> +
> +define PTP4L_BUILD_CMDS
> +       $(TARGET_MAKE_ENV) $(MAKE) KBUILD_OUTPUT=$(TARGET_DIR) CC=$(TARGET_CC) EXTRA_CFLAGS="$(PTP4L_CFLAGS)" -C $(@D) all
> +endef

Perhaps you should add EXTRA_LDFLAGS="$(TARGET_LDFLAGS)" as well.
(In addition to eliminating PTP4L_CFLAGS and using
EXTRA_CFLAGS="$(TARGET_CFLAGS)" instead,)

FWIW: changing the name to linuxptp: +1

Danomi -


> +
> +define PTP4L_INSTALL_TARGET_CMDS
> +       $(TARGET_MAKE_ENV) $(MAKE) prefix=$(TARGET_DIR)/usr $(TARGET_CONFIGURE_OPTS) -C $(@D) install
> +endef
> +
> +define PTP4L_INSTALL_INIT_SYSV
> +       $(INSTALL) -m 755 -D $(@D)/package/ptp4l/S65ptp4l \
> +               $(TARGET_DIR)/etc/init.d/S65ptp4l
> +endef
> +
> +define PTP4L_INSTALL_INIT_SYSTEMD
> +       $(INSTALL) -D -m 644 $(PTP4L_PKGDIR)/ptp4l.service \
> +               $(TARGET_DIR)/usr/lib/systemd/system/ptp4l.service
> +       mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> +       ln -sf ../../../../usr/lib/systemd/system/ptp4l.service \
> +               $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/ptp4l.service
> +endef
> +
> +$(eval $(generic-package))
> +
> diff --git a/package/ptp4l/ptp4l.service b/package/ptp4l/ptp4l.service
> new file mode 100644
> index 0000000..ec6bbc5
> --- /dev/null
> +++ b/package/ptp4l/ptp4l.service
> @@ -0,0 +1,10 @@
> +[Unit]
> +Description=Precision Time Protocol daemon
> +After=syslog.target network.target
> +
> +[Service]
> +ExecStart=/usr/sbin/ptp4l -A -i eth0
> +Restart=always
> +
> +[Install]
> +WantedBy=multi-user.target
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply

* [Buildroot] [PATCH v2 0/4] mpir build fixes
From: Peter Korsgaard @ 2017-05-09 15:12 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <1494272750-20723-1-git-send-email-thomas.petazzoni@free-electrons.com>

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > This new version of the mpir build fixes series now fixes the build
 > for all 49 toolchain configurations, tested with the test-pkg script.

 > Changes since v1:

 >  - Fix a typo in the mips32r6/mips64r6 that originally made it useless
 >    (BR2_mips32r6 was used, while the option is name BR2_mips_32r6)

 >  - Add a patch to fix the powerpc64le build

 > Best regards,

 > Thomas

 > Thomas Petazzoni (4):
 >   mpir: fix build on ARM with old binutils versions
 >   mpir: fix build on ARM Thumb-only platforms
 >   mpir: fix build on mips32r6/mips64r6
 >   mpir: fix build on powerpc64le

Committed all 4, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply

* [Buildroot] [git commit] daemon: fix parallel build
From: Peter Korsgaard @ 2017-05-09 15:13 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=c23236d387a84a73940b490f363c3d3d364e3c96
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The 'ready' target creates a symlink in the libslack/ subdirectory to make
up the path to header files.  Unfortunately, the target building sources
files that need that symlink, does not depend on the 'ready' target.  This
might break highly parallel builds.  As a workaround make the 'ready' target
before making 'all'.

Should fix:
http://autobuild.buildroot.net/results/ed2/ed21ac166f2151aa69a7790a17ff05f05afa512d/
http://autobuild.buildroot.net/results/333/3338539743c8b0399c6b0fcbbb7c28b58bf3f387/

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/daemon/daemon.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/daemon/daemon.mk b/package/daemon/daemon.mk
index dfa573f..79cf3f7 100644
--- a/package/daemon/daemon.mk
+++ b/package/daemon/daemon.mk
@@ -14,6 +14,7 @@ define DAEMON_CONFIGURE_CMDS
 endef
 
 define DAEMON_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) ready
 	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
 endef
 

^ permalink raw reply related

* [Buildroot] [PATCH] daemon: fix parallel build
From: Peter Korsgaard @ 2017-05-09 15:14 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <b7b648fdc787feae767f23b1a334ce5e7f13072a.1494266507.git.baruch@tkos.co.il>

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > The 'ready' target creates a symlink in the libslack/ subdirectory to make up
 > the path to header files. Unfortunately, the target building sources files
 > that need on that symlink, does not depend on the 'ready' target. This might

Dropped 'on' from 'need on that' and committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox