Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v3 3/3] refpolicy: add ability to set default state.
From: Adam Duskett @ 2017-05-14 17:40 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170514174053.26140-1-Adamduskett@outlook.com>

SELinux requires a config file in /etc/selinux which controls the state
of SELinux on the system.

This config file has two options set in it:
SELINUX which set's the state of selinux on boot.
SELINUXTYPE which should equal the name of the policy.  In this case, the
default name is targeted.

This patch adds:
- A choice menu on Config.in that allows the user to select a default
  SELinux state.

- A basic config file that will be installed to
  target/etc/selinux and will set SELINUX= to the selected state.

Signed-off-by: Adam Duskett <Adamduskett@outlook.com>
---
Changes v2 -> v3:
  - No changes.

Changes v1 -> v2:
  - Added cover letter explaining the new patch set. 

 package/refpolicy/Config.in    | 25 +++++++++++++++++++++++++
 package/refpolicy/config       |  9 +++++++++
 package/refpolicy/refpolicy.mk |  6 ++++++
 3 files changed, 40 insertions(+)
 create mode 100644 package/refpolicy/config

diff --git a/package/refpolicy/Config.in b/package/refpolicy/Config.in
index 9d4e0e6..a51e411 100644
--- a/package/refpolicy/Config.in
+++ b/package/refpolicy/Config.in
@@ -41,5 +41,30 @@ if BR2_PACKAGE_REFPOLICY
 config BR2_PACKAGE_REFPOLICY_VERSION
 	string "Policy version"
 	default "30"
+choice
+	prompt "SELinux default state"
+	default BR2_PACKAGE_REFPOLICY_STATE_PERMISSIVE
+
+config BR2_PACKAGE_REFPOLICY_STATE_ENFORCING
+	bool "Enforcing"
+	help
+	  SELinux security policy is enforced
+
+config BR2_PACKAGE_REFPOLICY_STATE_PERMISSIVE
+	bool "Permissive"
+	help
+	  SELinux prints warnings instead of enforcing
+
+config BR2_PACKAGE_REFPOLICY_STATE_DISABLED
+	bool "Disabled"
+	help
+	  No SELinux policy is loaded
+endchoice
+
+config BR2_PACKAGE_REFPOLICY_STATE
+	string
+	default "permissive" if BR2_PACKAGE_REFPOLICY_STATE_PERMISSIVE
+	default "enforcing" if BR2_PACKAGE_REFPOLICY_STATE_ENFORCING
+	default "disabled" if BR2_PACKAGE_REFPOLICY_STATE_DISABLED
 
 endif
diff --git a/package/refpolicy/config b/package/refpolicy/config
new file mode 100644
index 0000000..a45a349
--- /dev/null
+++ b/package/refpolicy/config
@@ -0,0 +1,9 @@
+# This file controls the state of SELinux on the system.
+# SELINUX= can take one of these three values:
+#     enforcing - SELinux security policy is enforced.
+#     permissive - SELinux prints warnings instead of enforcing.
+#     disabled - No SELinux policy is loaded.
+SELINUX=disabled
+
+SELINUXTYPE=targeted
+
diff --git a/package/refpolicy/refpolicy.mk b/package/refpolicy/refpolicy.mk
index b60c456..4834a46 100644
--- a/package/refpolicy/refpolicy.mk
+++ b/package/refpolicy/refpolicy.mk
@@ -23,6 +23,7 @@ REFPOLICY_DEPENDENCIES += \
 	policycoreutils
 
 REFPOLICY_PYINC = -I$(HOST_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)/site-packages
+REFPOLICY_NAME = "targeted"
 
 # Cannot use multiple threads to build the reference policy
 REFPOLICY_MAKE = PYTHON="$(HOST_DIR)/usr/bin/python2" $(TARGET_MAKE_ENV) $(MAKE1)
@@ -44,6 +45,11 @@ endef
 
 define REFPOLICY_INSTALL_TARGET_CMDS
 	$(REFPOLICY_MAKE) -C $(@D) install DESTDIR=$(TARGET_DIR)
+	$(INSTALL) -m 0755 -D package/refpolicy/config \
+		$(TARGET_DIR)/etc/selinux/config
+
+	$(SED) "/^SELINUX=/c\SELINUX=$(BR2_PACKAGE_REFPOLICY_STATE)" \
+		$(TARGET_DIR)/etc/selinux/config
 endef
 
 $(eval $(generic-package))
-- 
2.9.3

^ permalink raw reply related

* [Buildroot] [autobuild.buildroot.net] Build results for 2017-05-11
From: Eric Le Bihan @ 2017-05-14 17:45 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170512062950.23CF0220A8@mail.free-electrons.com>

Hi!

On 17-05-12 08:29:50, Thomas Petazzoni wrote:

>        sparc |                skalibs-2.4.0.2 | NOK | http://autobuild.buildroot.net/results/85062b5f9dbe74d7d1c6edfeda085268ecaef4c2 |

This one is puzzling. The configure steps ends with the following error:

```
Checking whether system has auto-close after fd-passing...
  ... test crashed, aborting.
  make: ***
  [/accts/mlweber1/instance-2/output/build/skalibs-2.4.0.2/.stamp_configured]
  Error 111
  make: Leaving directory `/accts/mlweber1/instance-2/buildroot'
```

The configure script tries to cross-compile and execute a program
(tryancilautoclose). The cross-compilation succeeds and of course the
execution fails, as it means running a program compiled for the
SPARC architecture on a x86 machine. Normally, the shell which executes
the program should return the code 126, as mentioned in the list of Bash
exit codes with special meaning [1].

Here the exit code is 111. When looking at tryancilautoclose.c, we can
see that 111 may be returned.

So this error means that either the shell managed to execute the
cross-compiled program or the shell does not follow the convention [1].

Which are the architecture of the build machine and the shell used?

[1] http://tldp.org/LDP/abs/html/exitcodes.html

--
ELB

^ permalink raw reply

* [Buildroot] [PATCH] package/opencv3: disable explicitly lapack support
From: Romain Naour @ 2017-05-14 18:26 UTC (permalink / raw)
  To: buildroot

lapack support is enabled by default but the opencv3.mk doesn't handle
this dependency yet.

Fixes:
http://autobuild.buildroot.net/results/c8a/c8a25af38c405594722b44aef34e5e4c549639db

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Samuel Martin <s.martin49@gmail.com>
---
 package/opencv3/opencv3.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/opencv3/opencv3.mk b/package/opencv3/opencv3.mk
index 153fd06..6df5705 100644
--- a/package/opencv3/opencv3.mk
+++ b/package/opencv3/opencv3.mk
@@ -192,6 +192,7 @@ OPENCV3_CONF_OPTS += \
 	-DWITH_EIGEN=OFF \
 	-DWITH_GDAL=OFF \
 	-DWITH_GPHOTO2=OFF \
+	-DWITH_LAPACK=OFF \
 	-DWITH_MATLAB=OFF \
 	-DWITH_OPENCL=OFF \
 	-DWITH_OPENCL_SVM=OFF \
-- 
2.9.3

^ permalink raw reply related

* [Buildroot] [autobuild.buildroot.net] Build results for 2017-05-11
From: Thomas Petazzoni @ 2017-05-14 19:19 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170514174506.GA16283@itchy>

Hello,

On Sun, 14 May 2017 19:45:06 +0200, Eric Le Bihan wrote:

> On 17-05-12 08:29:50, Thomas Petazzoni wrote:
> 
> >        sparc |                skalibs-2.4.0.2 | NOK | http://autobuild.buildroot.net/results/85062b5f9dbe74d7d1c6edfeda085268ecaef4c2 |  
> 
> This one is puzzling. The configure steps ends with the following error:
> 
> ```
> Checking whether system has auto-close after fd-passing...
>   ... test crashed, aborting.
>   make: ***
>   [/accts/mlweber1/instance-2/output/build/skalibs-2.4.0.2/.stamp_configured]
>   Error 111
>   make: Leaving directory `/accts/mlweber1/instance-2/buildroot'
> ```
> 
> The configure script tries to cross-compile and execute a program
> (tryancilautoclose). The cross-compilation succeeds and of course the
> execution fails, as it means running a program compiled for the
> SPARC architecture on a x86 machine. Normally, the shell which executes
> the program should return the code 126, as mentioned in the list of Bash
> exit codes with special meaning [1].
> 
> Here the exit code is 111. When looking at tryancilautoclose.c, we can
> see that 111 may be returned.
> 
> So this error means that either the shell managed to execute the
> cross-compiled program or the shell does not follow the convention [1].
> 
> Which are the architecture of the build machine and the shell used?

Thanks for investigating this issue. This build failure occurred on
Matt Weber's autobuilder instance, so I've added him in Cc. His
instance has already triggered some weird issues recently due to an
unusual setup. Hopefully Matt will be able to shed some light on what's
going on, possibly reproduce by hand the issue and investigate.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply

* [Buildroot] [PATCH] package/bluez_utils: select BR2_PACKAGE_CHECK
From: Romain Naour @ 2017-05-14 19:55 UTC (permalink / raw)
  To: buildroot

Commit [1] added check package to bluez_utils dependencies without
selecting it at Kconfig level.

Fixes:
Makefile:535: *** check is in the dependency chain of bluez_utils that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.

[1] 8554be9f82301282161cf6310bacdb6067fefb16

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/bluez_utils/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/bluez_utils/Config.in b/package/bluez_utils/Config.in
index 3848162..86c9085 100644
--- a/package/bluez_utils/Config.in
+++ b/package/bluez_utils/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_BLUEZ_UTILS
 	depends on BR2_USE_WCHAR # libglib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, alsa-lib, libglib2
 	depends on BR2_USE_MMU # dbus, libglib2
+	select BR2_PACKAGE_CHECK
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_LIBGLIB2
 	help
-- 
2.9.3

^ permalink raw reply related

* [Buildroot] [git commit] package/opencv3: disable explicitly lapack support
From: Thomas Petazzoni @ 2017-05-14 19:57 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=a4aaf6eae0c99d5da0ae16c2db53eec84d549cef
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

lapack support is enabled by default but the opencv3.mk doesn't handle
this dependency yet.

Fixes:
http://autobuild.buildroot.net/results/c8a/c8a25af38c405594722b44aef34e5e4c549639db

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/opencv3/opencv3.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/opencv3/opencv3.mk b/package/opencv3/opencv3.mk
index 153fd06..6df5705 100644
--- a/package/opencv3/opencv3.mk
+++ b/package/opencv3/opencv3.mk
@@ -192,6 +192,7 @@ OPENCV3_CONF_OPTS += \
 	-DWITH_EIGEN=OFF \
 	-DWITH_GDAL=OFF \
 	-DWITH_GPHOTO2=OFF \
+	-DWITH_LAPACK=OFF \
 	-DWITH_MATLAB=OFF \
 	-DWITH_OPENCL=OFF \
 	-DWITH_OPENCL_SVM=OFF \

^ permalink raw reply related

* [Buildroot] [git commit] package/bluez_utils: select BR2_PACKAGE_CHECK
From: Thomas Petazzoni @ 2017-05-14 19:57 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=00f6de5fc77e38ae80c6ef1a0f0a74b57373344b
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Commit [1] added check package to bluez_utils dependencies without
selecting it at Kconfig level.

Fixes:
Makefile:535: *** check is in the dependency chain of bluez_utils that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.

[1] 8554be9f82301282161cf6310bacdb6067fefb16

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/bluez_utils/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/bluez_utils/Config.in b/package/bluez_utils/Config.in
index 3848162..86c9085 100644
--- a/package/bluez_utils/Config.in
+++ b/package/bluez_utils/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_BLUEZ_UTILS
 	depends on BR2_USE_WCHAR # libglib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, alsa-lib, libglib2
 	depends on BR2_USE_MMU # dbus, libglib2
+	select BR2_PACKAGE_CHECK
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_LIBGLIB2
 	help

^ permalink raw reply related

* [Buildroot] [PATCH] package/opencv3: disable explicitly lapack support
From: Thomas Petazzoni @ 2017-05-14 19:57 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170514182655.4945-1-romain.naour@gmail.com>

Hello,

On Sun, 14 May 2017 20:26:55 +0200, Romain Naour wrote:
> lapack support is enabled by default but the opencv3.mk doesn't handle
> this dependency yet.
> 
> Fixes:
> http://autobuild.buildroot.net/results/c8a/c8a25af38c405594722b44aef34e5e4c549639db
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Samuel Martin <s.martin49@gmail.com>
> ---
>  package/opencv3/opencv3.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply

* [Buildroot] [PATCH] package/bluez_utils: select BR2_PACKAGE_CHECK
From: Thomas Petazzoni @ 2017-05-14 20:04 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170514195518.9038-1-romain.naour@gmail.com>

Hello,

On Sun, 14 May 2017 21:55:18 +0200, Romain Naour wrote:
> Commit [1] added check package to bluez_utils dependencies without
> selecting it at Kconfig level.
> 
> Fixes:
> Makefile:535: *** check is in the dependency chain of bluez_utils that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.
> 
> [1] 8554be9f82301282161cf6310bacdb6067fefb16
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  package/bluez_utils/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply

* [Buildroot] [git commit] libv4l: add patch to link qv4l2 tool with librt
From: Thomas Petazzoni @ 2017-05-14 20:18 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=a8bd6c40723897e6a398e0481290460cd40e8b48
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The qv4l2 tool in libv4l uses clock_gettime(), so it should link
against librt to build properly with old versions of glibc. Therefore,
we add a patch to libv4l to fix this issue. Autoreconfiguring libv4l
is now necessary since the patch touches Makefile.am.

Fixes:

  http://autobuild.buildroot.net/results/5dff0ec19205e02f6ee373d34cb79f39ac25b609/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 ...3-utils-qv4l2-Makefile.am-link-with-librt.patch | 29 ++++++++++++++++++++++
 package/libv4l/libv4l.mk                           |  5 ++++
 2 files changed, 34 insertions(+)

diff --git a/package/libv4l/0003-utils-qv4l2-Makefile.am-link-with-librt.patch b/package/libv4l/0003-utils-qv4l2-Makefile.am-link-with-librt.patch
new file mode 100644
index 0000000..4bac577
--- /dev/null
+++ b/package/libv4l/0003-utils-qv4l2-Makefile.am-link-with-librt.patch
@@ -0,0 +1,29 @@
+From 66d1d752976f4b45a5faff2bc68fc2fa9d435c71 Mon Sep 17 00:00:00 2001
+From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+Date: Sun, 14 May 2017 22:04:55 +0200
+Subject: [PATCH] utils/qv4l2/Makefile.am: link with librt
+
+qv4l2 uses clock_gettime(), so it should link with librt to be
+compatible with old versions of glibc.
+
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+---
+ utils/qv4l2/Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/utils/qv4l2/Makefile.am b/utils/qv4l2/Makefile.am
+index fd58486..a991d66 100644
+--- a/utils/qv4l2/Makefile.am
++++ b/utils/qv4l2/Makefile.am
+@@ -7,7 +7,7 @@ qv4l2_SOURCES = qv4l2.cpp general-tab.cpp ctrl-tab.cpp vbi-tab.cpp capture-win.c
+   v4l2-tpg-core.c v4l2-tpg-colors.c
+ nodist_qv4l2_SOURCES = moc_qv4l2.cpp moc_general-tab.cpp moc_capture-win.cpp moc_vbi-tab.cpp qrc_qv4l2.cpp
+ qv4l2_LDADD = ../../lib/libv4l2/libv4l2.la ../../lib/libv4lconvert/libv4lconvert.la \
+-  ../libv4l2util/libv4l2util.la ../libmedia_dev/libmedia_dev.la
++  ../libv4l2util/libv4l2util.la ../libmedia_dev/libmedia_dev.la -lrt
+ qv4l2_CPPFLAGS = -I../common
+ 
+ if WITH_QTGL
+-- 
+2.7.4
+
diff --git a/package/libv4l/libv4l.mk b/package/libv4l/libv4l.mk
index 465f6cc..6bc9d85 100644
--- a/package/libv4l/libv4l.mk
+++ b/package/libv4l/libv4l.mk
@@ -11,6 +11,11 @@ LIBV4L_INSTALL_STAGING = YES
 LIBV4L_DEPENDENCIES = host-pkgconf
 LIBV4L_CONF_OPTS = --disable-doxygen-doc
 
+# 0003-utils-qv4l2-Makefile.am-link-with-librt.patch, host-gettext
+# needed for autoreconf to work
+LIBV4L_AUTORECONF = YES
+LIBV4L_DEPENDENCIES += host-gettext
+
 # fix uclibc-ng configure/compile
 LIBV4L_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
 

^ permalink raw reply related

* [Buildroot] [PATCH] rabbitmq-c: openssl/popt sub-options don't work in stat_ic linking
From: Thomas Petazzoni @ 2017-05-14 21:22 UTC (permalink / raw)
  To: buildroot

rabbitmq-c currently fails to build in a number of static linking
situations, due to two issues:

 - CMake FindOpenSSL module is buggy. Even though it uses pkg-config,
   it doesn't use the information returned by pkg-config, and
   therefore doesn't know about second order libraries that need be
   part of the link for static linking to succeed. Due to this, -lz is
   not passed, and therefore rabbitmq-c fails when linking against
   libssl/libcrypto. This issue has been reported to upstream CMake at
   https://gitlab.kitware.com/cmake/cmake/issues/16885.

 - popt might use libintl, but CMake doesn't know about that. For
   autotools based packages, we typically work around this by passing
   LIBS=, but CMake apparently has no equivalent to LIBS=.

To workaround this, we only use the OpenSSL and Popt optional
dependencies in dynamic linking situations.

Fixes:

  http://autobuild.buildroot.net/results/798dbe5e5fd0463bb2066cb115656795144c327f/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/rabbitmq-c/rabbitmq-c.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/package/rabbitmq-c/rabbitmq-c.mk b/package/rabbitmq-c/rabbitmq-c.mk
index 1ca35ad..eef09ec 100644
--- a/package/rabbitmq-c/rabbitmq-c.mk
+++ b/package/rabbitmq-c/rabbitmq-c.mk
@@ -21,14 +21,20 @@ else ifeq ($(BR2_SHARED_LIBS),y)
 RABBITMQ_C_CONF_OPTS += -DBUILD_SHARED_LIBS=ON -DBUILD_STATIC_LIBS=OFF
 endif
 
-ifeq ($(BR2_PACKAGE_OPENSSL),y)
+# CMake OpenSSL detection is buggy, and doesn't properly use
+# pkg-config, so it fails when statically linking. See
+# https://gitlab.kitware.com/cmake/cmake/issues/16885.
+ifeq ($(BR2_PACKAGE_OPENSSL):$(BR2_STATIC_LIBS),y:)
 RABBITMQ_C_CONF_OPTS += -DENABLE_SSL_SUPPORT=ON
 RABBITMQ_C_DEPENDENCIES += openssl
 else
 RABBITMQ_C_CONF_OPTS += -DENABLE_SSL_SUPPORT=OFF
 endif
 
-ifeq ($(BR2_PACKAGE_POPT), y)
+# Popt is sometimes linked against libintl, but CMake doesn't know
+# about that, and there's no way to tell manually CMake to link
+# against an additional library.
+ifeq ($(BR2_PACKAGE_POPT):$(BR2_STATIC_LIBS),y:)
 RABBITMQ_C_CONF_OPTS += -DBUILD_TOOLS=ON
 RABBITMQ_C_DEPENDENCIES += popt
 else
-- 
2.7.4

^ permalink raw reply related

* [Buildroot] [PATCH] package/faketime: fix build with gcc >= 6
From: Romain Naour @ 2017-05-14 21:26 UTC (permalink / raw)
  To: buildroot

Upstream added -Wno-nonnull-compare to disable this error [1].

Fixes:
libfaketime.c:513:7: error?: nonnull argument ??buf?? compared to NULL [-Werror=nonnull-compare]
    if (buf != NULL)
       ^
[1] https://github.com/wolfcw/libfaketime/commit/47e958b753fc15098a2b7d0e9ef26b83ee255874

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 ...isable-the-non-null-compare-warning-error.patch | 31 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 package/faketime/0001-Disable-the-non-null-compare-warning-error.patch

diff --git a/package/faketime/0001-Disable-the-non-null-compare-warning-error.patch b/package/faketime/0001-Disable-the-non-null-compare-warning-error.patch
new file mode 100644
index 0000000..859592e
--- /dev/null
+++ b/package/faketime/0001-Disable-the-non-null-compare-warning-error.patch
@@ -0,0 +1,31 @@
+From e85a157b51b1276c91c736d8624d9f3e876e9189 Mon Sep 17 00:00:00 2001
+From: Andreas Rammhold <andreas@rammhold.de>
+Date: Tue, 20 Dec 2016 19:25:32 +0100
+Subject: [PATCH] Disable the non-null compare warning/error.
+
+We rely on the provided local library definitions for the hooked
+functions which in some cases (GCC >6) carry a non-null-attribute flag
+which causes compile errors on `!= NULL` checks.
+
+[Romain: rebase on 0.9.6]
+Signed-off-by: Romain Naour <romain.naour@gmail.com>
+---
+ src/Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/Makefile b/src/Makefile
+index 51634b0..bbbd476 100644
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -67,7 +67,7 @@ INSTALL ?= install
+ PREFIX ?= /usr/local
+ LIBDIRNAME ?= /lib/faketime
+ 
+-CFLAGS += -std=gnu99 -Wall -Wextra -Werror -DFAKE_STAT -DFAKE_SLEEP -DFAKE_TIMERS -DFAKE_INTERNAL_CALLS -fPIC -DPREFIX='"'$(PREFIX)'"' -DLIBDIRNAME='"'$(LIBDIRNAME)'"'
++CFLAGS += -std=gnu99 -Wall -Wextra -Werror -Wno-nonnull-compare -DFAKE_STAT -DFAKE_SLEEP -DFAKE_TIMERS -DFAKE_INTERNAL_CALLS -fPIC -DPREFIX='"'$(PREFIX)'"' -DLIBDIRNAME='"'$(LIBDIRNAME)'"'
+ LIB_LDFLAGS += -shared
+ LDFLAGS += -Wl,--version-script=libfaketime.map -lpthread
+ LDADD += -ldl -lm -lrt
+-- 
+2.9.3
+
-- 
2.9.3

^ permalink raw reply related

* [Buildroot] [PATCH] package/boost: disable boost-locale for static only build
From: Romain Naour @ 2017-05-14 21:45 UTC (permalink / raw)
  To: buildroot

boost-locale build system try to link dynamically with icu
see <link>shared and <runtime-link>shared in locale/build/Jamfile.v2
Related to https://svn.boost.org/trac/boost/ticket/9685

Enabling boost-locale for static only build trigger an incompatible
properties combination.

error: Tried to build the target twice, with property sets having
error: these incompatible properties:
error:
error:     -  <runtime-link>static <warnings>all
error:     -  <runtime-link>shared <warnings>on

Fixes:
http://autobuild.buildroot.net/results/c8f/c8f7aa85f5791d8ae8cf4b9085788adc5152286f

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/boost/Config.in | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/boost/Config.in b/package/boost/Config.in
index 9825c09..6ffa8f0 100644
--- a/package/boost/Config.in
+++ b/package/boost/Config.in
@@ -98,8 +98,15 @@ config BR2_PACKAGE_BOOST_IOSTREAMS
 
 config BR2_PACKAGE_BOOST_LOCALE
 	bool "boost-locale"
+	# boost-locale build system try to link dynamically with icu
+	# see <link>shared and <runtime-link>shared in locale/build/Jamfile.v2
+	# Related to https://svn.boost.org/trac/boost/ticket/9685
+	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 
+comment "boost-locale needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
+
 config BR2_PACKAGE_BOOST_LOG
 	bool "boost-log"
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
-- 
2.9.3

^ permalink raw reply related

* [Buildroot] [autobuild.buildroot.net] Build results for 2017-05-11
From: Matthew Weber @ 2017-05-15  1:09 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170514211956.662430db@free-electrons.com>

Thomas/Eric,

On Sun, May 14, 2017 at 2:19 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Sun, 14 May 2017 19:45:06 +0200, Eric Le Bihan wrote:
>
>> On 17-05-12 08:29:50, Thomas Petazzoni wrote:
>>
>> >        sparc |                skalibs-2.4.0.2 | NOK | http://autobuild.buildroot.net/results/85062b5f9dbe74d7d1c6edfeda085268ecaef4c2 |
>>
>> This one is puzzling. The configure steps ends with the following error:
>>
>> ```
>> Checking whether system has auto-close after fd-passing...
>>   ... test crashed, aborting.
>>   make: ***
>>   [/accts/mlweber1/instance-2/output/build/skalibs-2.4.0.2/.stamp_configured]
>>   Error 111
>>   make: Leaving directory `/accts/mlweber1/instance-2/buildroot'
>> ```
>>
>> The configure script tries to cross-compile and execute a program
>> (tryancilautoclose). The cross-compilation succeeds and of course the
>> execution fails, as it means running a program compiled for the
>> SPARC architecture on a x86 machine. Normally, the shell which executes
>> the program should return the code 126, as mentioned in the list of Bash
>> exit codes with special meaning [1].
>>
>> Here the exit code is 111. When looking at tryancilautoclose.c, we can
>> see that 111 may be returned.
>>
>> So this error means that either the shell managed to execute the
>> cross-compiled program or the shell does not follow the convention [1].
>>
>> Which are the architecture of the build machine and the shell used?
>
> Thanks for investigating this issue. This build failure occurred on
> Matt Weber's autobuilder instance, so I've added him in Cc. His
> instance has already triggered some weird issues recently due to an
> unusual setup. Hopefully Matt will be able to shed some light on what's
> going on, possibly reproduce by hand the issue and investigate.
>

Here's the machine info
# uname -a
Linux largo 3.13.0-43-generic #72-Ubuntu SMP Mon Dec 8 19:35:06 UTC
2014 x86_64 x86_64 x86_64 GNU/Linux
# ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Nov 18  2014 /bin/sh -> bash
# bash --version
GNU bash, version 4.3.11(1)-release (x86_64-pc-linux-gnu)

I'll kick off a manual recreation now and see how it ends up.

Matt

^ permalink raw reply

* [Buildroot] [PATCH 1/1] libqmi: move canonicalize_file_name()
From: Matt Weber @ 2017-05-15  2:26 UTC (permalink / raw)
  To: buildroot

Previously was defined in qmi-util.h to fix musl
compatibility.  It was missed that this is a shared
header which causes other dependent package builds
to fail, so the static definition was moved into the
implementation where it was used.

Upstream bug report has been updated and this resolves
the following autobuilder related failures.

 http://autobuild.buildroot.net/results/fe9b6b1b1399a4e8aafc6a326c81ec97c2480025
 http://autobuild.buildroot.net/results/40eef797b4d8d53fc6e10f2048316d63549caf6d

test-pkg testing was performed against 10 random toolchains

++ Config snippet ++
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
BR2_PACKAGE_MODEM_MANAGER_LIBQMI=y
BR2_PACKAGE_MODEM_MANAGER=y
BR2_PACKAGE_LIBQMI=y

++ Tested Toolchains ++ (Verified I hit all libc varients)
br-arm-cortex-a9-musl
br-arm-full-static
br-m68k-68040-full    (uclibc)
br-mips32r6-el-hf-glibc
br-mips64-n64-full
br-mips64r6-el-hf-glibc
br-mipsel-o32-full
br-sparc64-glibc
linaro-arm
sourcery-arm

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
 .../0001-musl-compat-canonicalize_file_name.patch  | 37 +++++++++++-----------
 1 file changed, 18 insertions(+), 19 deletions(-)

diff --git a/package/libqmi/0001-musl-compat-canonicalize_file_name.patch b/package/libqmi/0001-musl-compat-canonicalize_file_name.patch
index fd606d8..3ae1c2e 100644
--- a/package/libqmi/0001-musl-compat-canonicalize_file_name.patch
+++ b/package/libqmi/0001-musl-compat-canonicalize_file_name.patch
@@ -1,22 +1,24 @@
-From 85863c9e051fe59add4e47dbfcb37072234f0110 Mon Sep 17 00:00:00 2001
+From 8f6181b6f8dd82aa1ab1288cc7f2fd05d4a2519f Mon Sep 17 00:00:00 2001
 From: Matt Weber <matthew.weber@rockwellcollins.com>
 Date: Mon, 1 May 2017 19:55:07 -0500
 Subject: [PATCH] musl compat canonicalize_file_name()
 
-Adds an inline equivalent of canonicalize_file_name
+Adds an equivalent of canonicalize_file_name
 using realpath().
 
 Bug report (origin of this patch):
 https://bugs.freedesktop.org/show_bug.cgi?id=99944
 
+Bug report has been updated with suggestion to not use inline.
+
 Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
 ---
  configure.ac                |  2 ++
- src/libqmi-glib/qmi-utils.h | 18 ++++++++++++++++++
- 2 files changed, 20 insertions(+)
+ src/libqmi-glib/qmi-utils.c | 15 +++++++++++++++
+ 2 files changed, 17 insertions(+)
 
 diff --git a/configure.ac b/configure.ac
-index 162d5ae..9cb82fd 100644
+index c56fa3e..d835db4 100644
 --- a/configure.ac
 +++ b/configure.ac
 @@ -80,6 +80,8 @@ AC_SUBST(GLIB_LIBS)
@@ -28,19 +30,16 @@ index 162d5ae..9cb82fd 100644
  dnl qmi-firmware-update is optional, enabled by default
  AC_ARG_ENABLE([firmware-update],
                AS_HELP_STRING([--enable-firmware-update],
-diff --git a/src/libqmi-glib/qmi-utils.h b/src/libqmi-glib/qmi-utils.h
-index 4fd5199..4869da5 100644
---- a/src/libqmi-glib/qmi-utils.h
-+++ b/src/libqmi-glib/qmi-utils.h
-@@ -29,6 +29,24 @@
- #error "Only <libqmi-glib.h> can be included directly."
- #endif
+diff --git a/src/libqmi-glib/qmi-utils.c b/src/libqmi-glib/qmi-utils.c
+index 29e5f22..26aff9e 100644
+--- a/src/libqmi-glib/qmi-utils.c
++++ b/src/libqmi-glib/qmi-utils.c
+@@ -34,6 +34,21 @@
+ #include "qmi-utils.h"
+ #include "qmi-error-types.h"
  
 +#ifndef HAVE_CANONICALIZE_FILE_NAME
 +#include <limits.h>
-+#include <string.h>
-+#include <stdlib.h>
-+#include <stdio.h>
 +static char * canonicalize_file_name(const char *path)
 +{
 +       char buf[PATH_MAX] = { };
@@ -54,9 +53,9 @@ index 4fd5199..4869da5 100644
 +}
 +#endif
 +
- #include <glib.h>
- 
- G_BEGIN_DECLS
+ /**
+  * SECTION:qmi-utils
+  * @title: Common utilities
 -- 
-2.7.4
+1.9.1
 
-- 
1.9.1

^ permalink raw reply related

* [Buildroot] [autobuild.buildroot.net] Build results for 2017-05-10
From: Matthew Weber @ 2017-05-15  2:27 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <CANQCQpaDCSqu9iKLeuTyB4+py5L2JDjPSYDWgxoFUuS2vF1mCg@mail.gmail.com>

Yegor.

On Thu, May 11, 2017 at 7:22 AM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
> Yegor,
>
>
> On Thursday, May 11, 2017, Yegor Yefremov <yegorslists@googlemail.com>
> wrote:
>>
>> On Thu, May 11, 2017 at 8:28 AM, Thomas Petazzoni
>> <thomas.petazzoni@free-electrons.com> wrote:
>> > Hello,
>> >
>> > Build statistics for 2017-05-10
>> > ================================
>> >
>> >       successes : 253
>> >        failures : 24
>> >        timeouts : 0
>> >           TOTAL : 277
>> >
>> > Classification of failures by reason
>> > ====================================
>> >
>> >                     radvd-2.12 | 4
>> >            modem-manager-1.6.4 | 3
>> >                  efibootmgr-14 | 2
>> >                   libcdio-0.94 | 2
>> >         ltp-testsuite-20170116 | 2
>> > openblas-f04af36ad0e85b64f1... | 2
>> >                pulseview-0.3.0 | 2
>> >              rabbitmq-c-v0.8.0 | 2
>> >           mediastreamer-2.14.0 | 1
>> >                 protobuf-3.2.0 | 1
>> >           qt5declarative-5.8.0 | 1
>> >                      qwt-6.1.3 | 1
>> >               strongswan-5.4.0 | 1
>> >
>> >
>> > Detail of failures
>> > ===================
>> >
>> >          arm |                  efibootmgr-14 | NOK |
>> > http://autobuild.buildroot.net/results/87c3ff2427331eb9ab31c9eb685fe80954a0a98f
>> > |
>> >          arm |                  efibootmgr-14 | NOK |
>> > http://autobuild.buildroot.net/results/368656c338f6ea732f564291d660bc1721b34af7
>> > |
>> >          arc |                   libcdio-0.94 | NOK |
>> > http://autobuild.buildroot.net/results/c909e8c397ab972b6aa4d370572cad4fae284d00
>> > |
>> >          arc |                   libcdio-0.94 | NOK |
>> > http://autobuild.buildroot.net/results/d681917034730d374092881e90875d3149e31774
>> > |
>> >          arm |         ltp-testsuite-20170116 | NOK |
>> > http://autobuild.buildroot.net/results/cb94f4859c7cf60c76dd978ed941883ff732ba11
>> > |
>> >        sparc |         ltp-testsuite-20170116 | NOK |
>> > http://autobuild.buildroot.net/results/e68191d1ae42100119ab2f872eeff8ba4b1b7c8d
>> > |
>> >         m68k |           mediastreamer-2.14.0 | NOK |
>> > http://autobuild.buildroot.net/results/775c81b5d0064cb196bbb367368dd76eb46ecf93
>> > | ORPH
>> >          arm |            modem-manager-1.6.4 | NOK |
>> > http://autobuild.buildroot.net/results/fe9b6b1b1399a4e8aafc6a326c81ec97c2480025
>> > |
>> >         i686 |            modem-manager-1.6.4 | NOK |
>> > http://autobuild.buildroot.net/results/40eef797b4d8d53fc6e10f2048316d63549caf6d
>> > |
>> >          arm |            modem-manager-1.6.4 | NOK |
>> > http://autobuild.buildroot.net/results/e3e3b61fb1162648f45c73b2a07509e0ab95b3d4
>> > |
>>
>> Hi Matthew,
>>
>> this issues looks like the one you've fixed for libqmi. Could you take a
>> look?
>>
>>

The following patch resolves this build issue.
https://patchwork.ozlabs.org/patch/762195/

^ permalink raw reply

* [Buildroot] libqmi and modem-manager
From: Matthew Weber @ 2017-05-15  2:29 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <CANQCQpYiw=mN-9TfQrkWDCo1GyGEvN6x5HqSiG-PMNUKWM=ENw@mail.gmail.com>

Vicente,

On Fri, May 12, 2017 at 10:13 PM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
> Vicente,
>
> On Thu, May 11, 2017 at 8:03 AM, Matthew Weber
> <matthew.weber@rockwellcollins.com> wrote:
>>
>> Vicente,
>>
>> On Thu, May 11, 2017 at 8:01 AM, Vicente Olivert Riera
>> <Vincent.Riera@imgtec.com> wrote:
>> > Hello Thomas and Matthew,
>> >
>> > this commit from Matthew broke libqmi compilation:
>> >
>> > https://git.busybox.net/buildroot/commit/?id=c78b65c4f161ec101ff02880788ef22eb7c87d76
>> >
>> > Then this commit from Thomas fixed the former bogus commit and libqmi
>> > started to compile file again:
>> >
>> > https://git.busybox.net/buildroot/commit/?id=4d11848a21d4424a04e8428c4cd3bd5e972aacdf
>> >
>> > The problem is that now modem-manager with qmi support fails to compile
>> > with an error like this one:
>> >
>> >   CC       mm-modem-helpers-qmi.lo
>> > In file included from
>> > /br/output/host/usr/mips64el-buildroot-linux-gnu/sysroot/usr/include/libqmi-glib/qmi-message.h:39:0,
>> >                  from
>> > /br/output/host/usr/mips64el-buildroot-linux-gnu/sysroot/usr/include/libqmi-glib/qmi-device.h:34,
>> >                  from
>> > /br/output/host/usr/mips64el-buildroot-linux-gnu/sysroot/usr/include/libqmi-glib/libqmi-glib.h:32,
>> >                  from mm-modem-helpers-qmi.h:22,
>> >                  from mm-modem-helpers-qmi.c:16:
>> > /br/output/host/usr/mips64el-buildroot-linux-gnu/sysroot/usr/include/libqmi-glib/qmi-utils.h:37:15:
>> > error: static declaration of ?canonicalize_file_name? follows non-static
>> > declaration
>> >  static char * canonicalize_file_name(const char *path)
>> >
>> > If I revert both commits modem-manager with qmi support compiles just fine.
>> >
>> > Could you please have a look to that issue?
>> >
>> > This is the defconfig I'm using:
>> >
>> > BR2_mipsel=y
>> > BR2_mips_32r2=y
>> > # BR2_MIPS_SOFT_FLOAT is not set
>> > BR2_TOOLCHAIN_EXTERNAL=y
>> > BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
>> > BR2_PACKAGE_MODEM_MANAGER=y
>> > BR2_PACKAGE_MODEM_MANAGER_LIBQMI=y
>> > # BR2_TARGET_ROOTFS_TAR is not set
>> >
>>
>>
>
> So the fix I'm currently testing removes the static inline from the
> libqmi header and instead puts the function in the file where it's
> used.  I didn't realize the header was a shared file for other
> packages to use.  So far no build failures across both musl and glibc
> test builds.
>


I've created the following patch and so far it tests out to accomplish
the original musl fix in libqmi and the modem-manager issue above.

https://patchwork.ozlabs.org/patch/762195/

^ permalink raw reply

* [Buildroot] [autobuild.buildroot.net] Build results for 2017-05-11
From: Matthew Weber @ 2017-05-15  2:53 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <CANQCQpaFEJtVONm4=0nNvKCU0CYqNo+M87QEvXda3PLzHB6TLA@mail.gmail.com>

Eric,

On Sun, May 14, 2017 at 8:09 PM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
> Thomas/Eric,
>
> On Sun, May 14, 2017 at 2:19 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>> Hello,
>>
>> On Sun, 14 May 2017 19:45:06 +0200, Eric Le Bihan wrote:
>>
>>> On 17-05-12 08:29:50, Thomas Petazzoni wrote:
>>>
>>> >        sparc |                skalibs-2.4.0.2 | NOK | http://autobuild.buildroot.net/results/85062b5f9dbe74d7d1c6edfeda085268ecaef4c2 |
>>>
>>> This one is puzzling. The configure steps ends with the following error:
>>>
>>> ```
>>> Checking whether system has auto-close after fd-passing...
>>>   ... test crashed, aborting.
>>>   make: ***
>>>   [/accts/mlweber1/instance-2/output/build/skalibs-2.4.0.2/.stamp_configured]
>>>   Error 111
>>>   make: Leaving directory `/accts/mlweber1/instance-2/buildroot'
>>> ```
>>>
>>> The configure script tries to cross-compile and execute a program
>>> (tryancilautoclose). The cross-compilation succeeds and of course the
>>> execution fails, as it means running a program compiled for the
>>> SPARC architecture on a x86 machine. Normally, the shell which executes
>>> the program should return the code 126, as mentioned in the list of Bash
>>> exit codes with special meaning [1].
>>>
>>> Here the exit code is 111. When looking at tryancilautoclose.c, we can
>>> see that 111 may be returned.
>>>
>>> So this error means that either the shell managed to execute the
>>> cross-compiled program or the shell does not follow the convention [1].
>>>
>>> Which are the architecture of the build machine and the shell used?
>>
>> Thanks for investigating this issue. This build failure occurred on
>> Matt Weber's autobuilder instance, so I've added him in Cc. His
>> instance has already triggered some weird issues recently due to an
>> unusual setup. Hopefully Matt will be able to shed some light on what's
>> going on, possibly reproduce by hand the issue and investigate.
>>
>
> Here's the machine info
> # uname -a
> Linux largo 3.13.0-43-generic #72-Ubuntu SMP Mon Dec 8 19:35:06 UTC
> 2014 x86_64 x86_64 x86_64 GNU/Linux
> # ls -l /bin/sh
> lrwxrwxrwx 1 root root 4 Nov 18  2014 /bin/sh -> bash
> # bash --version
> GNU bash, version 4.3.11(1)-release (x86_64-pc-linux-gnu)
>
> I'll kick off a manual recreation now and see how it ends up.
>

Well this is interesting and I'll have to dig around some more but
here's what I've found after doing a build.  It looks like I have
SPARC ELF ABI compatibility on my x86_64 Ubuntu 14.04.1 machine.  I
can execute the test app since it's statically linked.

# ./tryancilautoclose
Unsupported ancillary data: 65535/1
# echo $?
111
# file tryancilautoclose
tryancilautoclose: ELF 32-bit MSB  executable, SPARC version 1 (SYSV),
statically linked, with unknown capability 0x41000000 = 0xf676e75,
with unknown capability 0x10000 = 0x70403, not stripped

Matt

^ permalink raw reply

* [Buildroot] [autobuild.buildroot.net] Build results for 2017-05-11
From: Matthew Weber @ 2017-05-15  3:03 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <CANQCQpZWfvYShTNGVQ_X+f=8EKMj19B5nBqBYHGujTnpSap1gw@mail.gmail.com>

All,

On Sun, May 14, 2017 at 9:53 PM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
> Eric,
>
> On Sun, May 14, 2017 at 8:09 PM, Matthew Weber
> <matthew.weber@rockwellcollins.com> wrote:
>> Thomas/Eric,
>>
>> On Sun, May 14, 2017 at 2:19 PM, Thomas Petazzoni
>> <thomas.petazzoni@free-electrons.com> wrote:
>>> Hello,
>>>
>>> On Sun, 14 May 2017 19:45:06 +0200, Eric Le Bihan wrote:
>>>
>>>> On 17-05-12 08:29:50, Thomas Petazzoni wrote:
>>>>
>>>> >        sparc |                skalibs-2.4.0.2 | NOK | http://autobuild.buildroot.net/results/85062b5f9dbe74d7d1c6edfeda085268ecaef4c2 |
>>>>
>>>> This one is puzzling. The configure steps ends with the following error:
>>>>
>>>> ```
>>>> Checking whether system has auto-close after fd-passing...
>>>>   ... test crashed, aborting.
>>>>   make: ***
>>>>   [/accts/mlweber1/instance-2/output/build/skalibs-2.4.0.2/.stamp_configured]
>>>>   Error 111
>>>>   make: Leaving directory `/accts/mlweber1/instance-2/buildroot'
>>>> ```
>>>>
>>>> The configure script tries to cross-compile and execute a program
>>>> (tryancilautoclose). The cross-compilation succeeds and of course the
>>>> execution fails, as it means running a program compiled for the
>>>> SPARC architecture on a x86 machine. Normally, the shell which executes
>>>> the program should return the code 126, as mentioned in the list of Bash
>>>> exit codes with special meaning [1].
>>>>
>>>> Here the exit code is 111. When looking at tryancilautoclose.c, we can
>>>> see that 111 may be returned.
>>>>
>>>> So this error means that either the shell managed to execute the
>>>> cross-compiled program or the shell does not follow the convention [1].
>>>>
>>>> Which are the architecture of the build machine and the shell used?
>>>
>>> Thanks for investigating this issue. This build failure occurred on
>>> Matt Weber's autobuilder instance, so I've added him in Cc. His
>>> instance has already triggered some weird issues recently due to an
>>> unusual setup. Hopefully Matt will be able to shed some light on what's
>>> going on, possibly reproduce by hand the issue and investigate.
>>>
>>
>> Here's the machine info
>> # uname -a
>> Linux largo 3.13.0-43-generic #72-Ubuntu SMP Mon Dec 8 19:35:06 UTC
>> 2014 x86_64 x86_64 x86_64 GNU/Linux
>> # ls -l /bin/sh
>> lrwxrwxrwx 1 root root 4 Nov 18  2014 /bin/sh -> bash
>> # bash --version
>> GNU bash, version 4.3.11(1)-release (x86_64-pc-linux-gnu)
>>
>> I'll kick off a manual recreation now and see how it ends up.
>>
>
> Well this is interesting and I'll have to dig around some more but
> here's what I've found after doing a build.  It looks like I have
> SPARC ELF ABI compatibility on my x86_64 Ubuntu 14.04.1 machine.  I
> can execute the test app since it's statically linked.
>
> # ./tryancilautoclose
> Unsupported ancillary data: 65535/1
> # echo $?
> 111
> # file tryancilautoclose
> tryancilautoclose: ELF 32-bit MSB  executable, SPARC version 1 (SYSV),
> statically linked, with unknown capability 0x41000000 = 0xf676e75,
> with unknown capability 0x10000 = 0x70403, not stripped
>

Ok, didn't realize the qemu-user-static will automatically hook-up
support for executing the arch it supports seamlessly.  When I straced
I noticed the call into qemu-sparc-static.  Since removing that
package, I now observe what would be expected.

# ./tryancilautoclose
bash: ./tryancilautoclose: cannot execute binary file: Exec format error
# echo $?
 11126

Sorry about that one Eric, it's fixed now on that machine and shouldn't reoccur.

Thomas, should there be a check or warning added as part of
buildroot's package/host checking which would catch a case where
qemu-user-static is installed and may adversely affect the build?

Matt

^ permalink raw reply

* [Buildroot] [PATCH] x11r7: xf86-input-tslib: upgrade to 1.0.0
From: Martin Kepplinger @ 2017-05-15  6:28 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170514143733.5fa069e9@free-electrons.com>

Am 2017-05-14 um 14:37 schrieb Thomas Petazzoni:
> Hello,
> 
> On Sun, 14 May 2017 09:50:26 +0200, Martin Kepplinger wrote:
>> As the update from 0.0.X to 1.0.0 suggests, this is a major update. The driver
>> uses X11's touch API now, instead of motion with button emulation. Furthermore
>> it supports multitouch when a recent version of tslib is installed.
>>
>> It is not backwards compatible for very old versions of the X server. See
>> https://github.com/merge/xf86-input-tslib/releases for some details.
> 
> What do you call "very old versions of the X server" ?
> 
> Buildroot still supports the X server in version 1.14.7. Does this
> qualify as a "very old version" ?
>

While, to be honest I'm still digging for the definitive answer here,
I'm pretty sure 1.12 is the minimum X.org xserver version supported for
1.0.0 here.

1.14 and up is supported.

                            martin

^ permalink raw reply

* [Buildroot] [autobuild.buildroot.net] Build results for 2017-05-14
From: Thomas Petazzoni @ 2017-05-15  6:30 UTC (permalink / raw)
  To: buildroot

Hello,

Build statistics for 2017-05-14
================================

      successes : 242
       failures : 12 
       timeouts : 0  
          TOTAL : 254

Classification of failures by reason
====================================

      binutils-arc-2017.03-rc1 | 2 
                  boost-1.63.0 | 2 
                 mplayer-1.3.0 | 2 
             fxload-2008_10_13 | 1 
                 opencv3-3.2.0 | 1 
                protobuf-3.2.0 | 1 
             qt5location-5.8.0 | 1 
               upmpdcli-1.2.12 | 1 
                   zmqpp-4.1.2 | 1 


Detail of failures
===================

         arc |       binutils-arc-2017.03-rc1 | NOK | http://autobuild.buildroot.net/results/bb77100608f8bbed7ec1e3d48957a1f947be112e | ORPH
         arc |       binutils-arc-2017.03-rc1 | NOK | http://autobuild.buildroot.net/results/f9c40610209fc22ac8c0db6bd57bd3b11bbe6d9c | ORPH
      x86_64 |                   boost-1.63.0 | NOK | http://autobuild.buildroot.net/results/c8f7aa85f5791d8ae8cf4b9085788adc5152286f |     
         arm |                   boost-1.63.0 | NOK | http://autobuild.buildroot.net/results/34b35853c8d63cd81ec62c5c92e8b6cc5c804731 |     
microblazeel |              fxload-2008_10_13 | NOK | http://autobuild.buildroot.net/results/24640a042d84f45339246c0a18e10905494b2199 |     
        i686 |                  mplayer-1.3.0 | NOK | http://autobuild.buildroot.net/results/81664ac57f04fad69f806a37929105fbdb0ee16a |     
 powerpc64le |                  mplayer-1.3.0 | NOK | http://autobuild.buildroot.net/results/6190d72d70d9061970002359fb9df5d3b5daf9ef |     
      x86_64 |                  opencv3-3.2.0 | NOK | http://autobuild.buildroot.net/results/c8a25af38c405594722b44aef34e5e4c549639db |     
       sparc |                 protobuf-3.2.0 | NOK | http://autobuild.buildroot.net/results/f3d76eaebd529a61bce849e355182c60f233ed06 | ORPH
     powerpc |              qt5location-5.8.0 | NOK | http://autobuild.buildroot.net/results/e65383b321fe806cf42da9cf3848a2d4ed5290ee |     
      x86_64 |                upmpdcli-1.2.12 | NOK | http://autobuild.buildroot.net/results/1186bfd787ae5f5762481ec89465b0ae3a3d33df |     
       sparc |                    zmqpp-4.1.2 | NOK | http://autobuild.buildroot.net/results/62d8756bb08bfe41c249d985f0ed6c2615b7d624 |     

-- 
http://autobuild.buildroot.net

^ permalink raw reply

* [Buildroot] [PATCH] package/boost: disable boost-locale for static only build
From: Thomas Petazzoni @ 2017-05-15  7:15 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <20170514214556.17980-1-romain.naour@gmail.com>

Hello,

On Sun, 14 May 2017 23:45:56 +0200, Romain Naour wrote:

> diff --git a/package/boost/Config.in b/package/boost/Config.in
> index 9825c09..6ffa8f0 100644
> --- a/package/boost/Config.in
> +++ b/package/boost/Config.in
> @@ -98,8 +98,15 @@ config BR2_PACKAGE_BOOST_IOSTREAMS
>  
>  config BR2_PACKAGE_BOOST_LOCALE
>  	bool "boost-locale"
> +	# boost-locale build system try to link dynamically with icu
> +	# see <link>shared and <runtime-link>shared in locale/build/Jamfile.v2
> +	# Related to https://svn.boost.org/trac/boost/ticket/9685
> +	depends on !BR2_STATIC_LIBS
>  	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE

OK, but doesn't the problem occurs only when icu is enabled? Do we want
to prevent from using boost-locale in static linking situations in all
cases, or only when combined with icu?

Perhaps we should keep it simple and do like you suggest, i.e make it
unavailable for all static linking configurations, regardless of icu
availability. I'm just trying to figure out the best/right approach
between yours and the one proposed by Yegor.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply

* [Buildroot] [autobuild.buildroot.net] Build results for 2017-05-11
From: Thomas Petazzoni @ 2017-05-15  7:23 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <CANQCQpa=9ATKZvQtdunYZ35pPm8tc4GvJ3qeRqeYDhEJDWK1bg@mail.gmail.com>

Hello,

On Sun, 14 May 2017 22:03:27 -0500, Matthew Weber wrote:

> > Well this is interesting and I'll have to dig around some more but
> > here's what I've found after doing a build.  It looks like I have
> > SPARC ELF ABI compatibility on my x86_64 Ubuntu 14.04.1 machine.  I
> > can execute the test app since it's statically linked.
> >
> > # ./tryancilautoclose
> > Unsupported ancillary data: 65535/1
> > # echo $?
> > 111
> > # file tryancilautoclose
> > tryancilautoclose: ELF 32-bit MSB  executable, SPARC version 1 (SYSV),
> > statically linked, with unknown capability 0x41000000 = 0xf676e75,
> > with unknown capability 0x10000 = 0x70403, not stripped
> 
> Ok, didn't realize the qemu-user-static will automatically hook-up
> support for executing the arch it supports seamlessly.  When I straced
> I noticed the call into qemu-sparc-static.  Since removing that
> package, I now observe what would be expected.

Wow, ok. Thanks a lot for investigating this issue.

> # ./tryancilautoclose
> bash: ./tryancilautoclose: cannot execute binary file: Exec format error
> # echo $?
>  11126
> 
> Sorry about that one Eric, it's fixed now on that machine and shouldn't reoccur.
> 
> Thomas, should there be a check or warning added as part of
> buildroot's package/host checking which would catch a case where
> qemu-user-static is installed and may adversely affect the build?

Yes, we should definitely do something about that. Ideally, Buildroot
should do something to prevent binfmt_misc from kicking off the
execution of foreign binaries. I have no idea if this is possible. If
not, at the very least, we should warn/error out, but I really hate
when a build system/tool asks me to change my system-wide configuration
to operate correctly.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply

* [Buildroot] [PATCH] tslib: update to 1.10
From: Martin Kepplinger @ 2017-05-15  7:51 UTC (permalink / raw)
  To: buildroot
In-Reply-To: <1494577068-13998-1-git-send-email-martink@posteo.de>

On 2017-05-12 10:17, Martin Kepplinger wrote:
> If you're overly interested, check out the release notes at
> https://github.com/kergoth/tslib/releases
> 
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---

bump. Could have been lost on the weekend :)

thanks
                                martin

^ permalink raw reply

* [Buildroot] [PATCH v3 1/1] linuxptp: new package
From: Petr Kulhavy @ 2017-05-15  8:26 UTC (permalink / raw)
  To: buildroot

Add the Linux PTP Project package.
http://linuxptp.sourceforge.net/

The sysV and systemd init scripts start the daemon in automatic mode on eth0.

Signed-off-by: Petr Kulhavy <brain@jikos.cz>
--
Changes v2 -> v3:
	- add patches to fix build issues and enable compilation on all targets

Changes v1 -> v2:
	- rename package from ptp4l to linuxptp
	- add EXTRA_LDFLAGS to the build cmd (suggested by Danomi Manchego)
	- sysV startup script: add restart/reload code, use PID file
	- clean-up empty lines and formatting issues
	- license uses SPDX license code
	- update DEVELOPERS file
---
 DEVELOPERS                                      |  3 +
 package/Config.in                               |  1 +
 package/linuxptp/0001-adjtime-fix.patch         | 12 ++++
 package/linuxptp/0002-ethhdr-fix.patch          | 10 ++++
 package/linuxptp/0003-time_t-fix.patch          | 10 ++++
 package/linuxptp/0004-clock_nanosleep-fix.patch | 74 +++++++++++++++++++++++++
 package/linuxptp/Config.in                      | 13 +++++
 package/linuxptp/S65ptp4l                       | 36 ++++++++++++
 package/linuxptp/linuxptp.hash                  |  2 +
 package/linuxptp/linuxptp.mk                    | 38 +++++++++++++
 package/linuxptp/ptp4l.service                  | 10 ++++
 11 files changed, 209 insertions(+)
 create mode 100644 package/linuxptp/0001-adjtime-fix.patch
 create mode 100644 package/linuxptp/0002-ethhdr-fix.patch
 create mode 100644 package/linuxptp/0003-time_t-fix.patch
 create mode 100644 package/linuxptp/0004-clock_nanosleep-fix.patch
 create mode 100644 package/linuxptp/Config.in
 create mode 100755 package/linuxptp/S65ptp4l
 create mode 100644 package/linuxptp/linuxptp.hash
 create mode 100644 package/linuxptp/linuxptp.mk
 create mode 100644 package/linuxptp/ptp4l.service

diff --git a/DEVELOPERS b/DEVELOPERS
index 8fbb69a..524a655 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1267,6 +1267,9 @@ F:	package/sdl2_gfx/
 F:	package/sdl2_image/
 F:	package/sdl2_ttf/
 
+N:	Petr Kulhavy <brain@jikos.cz>
+F:	package/linuxptp/
+
 N:	Petr Vorel <petr.vorel@gmail.com>
 F:	package/linux-backports/
 F:	package/ltp-testsuite/
diff --git a/package/Config.in b/package/Config.in
index d57813c..200ae00 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1597,6 +1597,7 @@ menu "Networking applications"
 	source "package/links/Config.in"
 	source "package/linphone/Config.in"
 	source "package/linux-zigbee/Config.in"
+	source "package/linuxptp/Config.in"
 	source "package/lldpd/Config.in"
 	source "package/lrzsz/Config.in"
 	source "package/macchanger/Config.in"
diff --git a/package/linuxptp/0001-adjtime-fix.patch b/package/linuxptp/0001-adjtime-fix.patch
new file mode 100644
index 0000000..a892220
--- /dev/null
+++ b/package/linuxptp/0001-adjtime-fix.patch
@@ -0,0 +1,12 @@
+diff -u linuxptp-1.8.old/incdefs.sh linuxptp-1.8/incdefs.sh
+--- linuxptp-1.8.old/incdefs.sh	2017-05-14 22:19:25.526966749 +0200
++++ linuxptp-1.8/incdefs.sh	2017-05-14 22:22:19.185971919 +0200
+@@ -31,7 +31,7 @@
+ 
+ 	# Look for clock_adjtime().
+ 	for d in $dirs; do
+-		files=$(find $d -type f -name time.h)
++		files=$(find $d -type f -name time.h -o -name timex.h)
+ 		for f in $files; do
+ 			if grep -q clock_adjtime $f; then
+ 				printf " -DHAVE_CLOCK_ADJTIME"
diff --git a/package/linuxptp/0002-ethhdr-fix.patch b/package/linuxptp/0002-ethhdr-fix.patch
new file mode 100644
index 0000000..127384e
--- /dev/null
+++ b/package/linuxptp/0002-ethhdr-fix.patch
@@ -0,0 +1,10 @@
+--- linuxptp-1.8/raw.c.old	2016-11-04 19:38:56.000000000 +0100
++++ linuxptp-1.8/raw.c	2017-05-14 17:55:20.653736273 +0200
+@@ -20,7 +20,6 @@
+ #include <fcntl.h>
+ #include <linux/filter.h>
+ #include <linux/if_ether.h>
+-#include <net/ethernet.h>
+ #include <net/if.h>
+ #include <netinet/in.h>
+ #include <netpacket/packet.h>
diff --git a/package/linuxptp/0003-time_t-fix.patch b/package/linuxptp/0003-time_t-fix.patch
new file mode 100644
index 0000000..3fbc99b
--- /dev/null
+++ b/package/linuxptp/0003-time_t-fix.patch
@@ -0,0 +1,10 @@
+--- linuxptp-1.8/util.h.old	2017-05-14 17:22:52.228898091 +0200
++++ linuxptp-1.8/util.h	2017-05-14 17:23:15.988761979 +0200
+@@ -22,6 +22,7 @@
+ 
+ #include "ddt.h"
+ #include "ether.h"
++#include <time.h>
+ 
+ /**
+  * Table of human readable strings, one for each port state.
diff --git a/package/linuxptp/0004-clock_nanosleep-fix.patch b/package/linuxptp/0004-clock_nanosleep-fix.patch
new file mode 100644
index 0000000..c463293
--- /dev/null
+++ b/package/linuxptp/0004-clock_nanosleep-fix.patch
@@ -0,0 +1,74 @@
+diff -u -r linuxptp-1.8.old/incdefs.sh linuxptp-1.8/incdefs.sh
+--- linuxptp-1.8.old/incdefs.sh	2017-05-14 20:17:19.724933608 +0200
++++ linuxptp-1.8/incdefs.sh	2017-05-14 20:18:15.440614433 +0200
+@@ -40,6 +40,20 @@
+ 		done
+ 	done
+ 
++	# Look for clock_nanosleep().
++	echo '
++#include <time.h>
++
++void test(void)
++{
++        clock_nanosleep(CLOCK_REALTIME, 0, NULL, NULL);
++}
++	' > .incdefs-test.c
++	if ${CC} -c -Werror .incdefs-test.c 2> /dev/null ; then
++		printf " -DHAVE_CLOCK_NANOSLEEP"
++	fi
++	rm -f .incdefs-test.c .incdefs-test.o
++
+ 	# Look for posix_spawn().
+ 	for d in $dirs; do
+ 		files=$(find $d -type f -name spawn.h)
+--- linuxptp-1.8/missing.h.old	2017-05-14 22:58:55.000000000 +0200
++++ linuxptp-1.8/missing.h	2017-05-14 23:01:09.964619736 +0200
+@@ -69,18 +69,21 @@
+ }
+ #endif
+ 
+-#ifndef __uClinux__
+-
+-#include <sys/timerfd.h>
+-
+-#else
+-
++#if !defined ( HAVE_CLOCK_NANOSLEEP ) || defined ( __uClinux__ )
+ static inline int clock_nanosleep(clockid_t clock_id, int flags,
+ 				  const struct timespec *request,
+ 				  struct timespec *remain)
+ {
+ 	return syscall(__NR_clock_nanosleep, clock_id, flags, request, remain);
+ }
++#endif
++
++
++#ifndef __uClinux__
++
++#include <sys/timerfd.h>
++
++#else
+ 
+ static inline int timerfd_create(int clockid, int flags)
+ {
+--- linuxptp-1.8/makefile.old	2017-05-15 00:41:33.370113834 +0200
++++ linuxptp-1.8/makefile	2017-05-15 00:41:03.710283744 +0200
+@@ -20,7 +20,7 @@
+ DEBUG	=
+ CC	= $(CROSS_COMPILE)gcc
+ VER     = -DVER=$(version)
+-CFLAGS	= -Wall $(VER) $(incdefs) $(DEBUG) $(EXTRA_CFLAGS)
++CFLAGS	+= -Wall $(VER) $(incdefs) $(DEBUG) $(EXTRA_CFLAGS)
+ LDLIBS	= -lm -lrt $(EXTRA_LDFLAGS)
+ PRG	= ptp4l pmc phc2sys hwstamp_ctl phc_ctl timemaster
+ OBJ     = bmc.o clock.o clockadj.o clockcheck.o config.o fault.o \
+@@ -33,7 +33,7 @@
+ SRC	= $(OBJECTS:.o=.c)
+ DEPEND	= $(OBJECTS:.o=.d)
+ srcdir	:= $(dir $(lastword $(MAKEFILE_LIST)))
+-incdefs := $(shell $(srcdir)/incdefs.sh)
++incdefs := $(shell CC="$(CC)" $(srcdir)/incdefs.sh)
+ version := $(shell $(srcdir)/version.sh $(srcdir))
+ VPATH	= $(srcdir)
+ 
diff --git a/package/linuxptp/Config.in b/package/linuxptp/Config.in
new file mode 100644
index 0000000..7e4a77b
--- /dev/null
+++ b/package/linuxptp/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LINUXPTP
+	bool "Linux PTP"
+	help
+	  The Linux PTP Project is the Precision Time Protocol
+	  implementation according to IEEE standard 1588 for Linux.
+
+	  The dual design goals are to provide a robust implementation
+	  of the standard and to use the most relevant and modern
+	  Application Programming Interfaces (API) offered by the Linux
+	  kernel. Supporting legacy APIs and other platforms is not a
+	  goal.
+
+	  http://linuxptp.sourceforge.net/
diff --git a/package/linuxptp/S65ptp4l b/package/linuxptp/S65ptp4l
new file mode 100755
index 0000000..50b9e96
--- /dev/null
+++ b/package/linuxptp/S65ptp4l
@@ -0,0 +1,36 @@
+#!/bin/sh
+#
+# Start ptp4l
+#
+
+start() {
+	printf "Starting ptp4l: "
+	start-stop-daemon -S -b -q -p /var/run/ptp4l.pid \
+		-x /usr/sbin/ptp4l -- -A -i eth0
+	[ $? = 0 ] && echo "OK" || echo "FAIL"
+}
+
+stop() {
+	printf "Stopping ptp4l: "
+	start-stop-daemon -K -q -p /var/run/ptp4l.pid \
+		-x /usr/sbin/ptp4l
+	echo "OK"
+}
+
+case "$1" in
+  start)
+	start
+	;;
+  stop)
+	stop
+	;;
+  restart|reload)
+	stop
+	start
+	;;
+  *)
+	echo "Usage: $0 {start|stop|restart}"
+	exit 1
+esac
+
+exit $?
diff --git a/package/linuxptp/linuxptp.hash b/package/linuxptp/linuxptp.hash
new file mode 100644
index 0000000..1ac9443
--- /dev/null
+++ b/package/linuxptp/linuxptp.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256	fa8e00f6ec73cefa7bb313dce7f60dfe5eb9e2bde3353594e9ac18edc93e5165  linuxptp-1.8.tgz
diff --git a/package/linuxptp/linuxptp.mk b/package/linuxptp/linuxptp.mk
new file mode 100644
index 0000000..6f8094a
--- /dev/null
+++ b/package/linuxptp/linuxptp.mk
@@ -0,0 +1,38 @@
+################################################################################
+#
+# Linux PTP
+#
+################################################################################
+
+LINUXPTP_VERSION = 1.8
+LINUXPTP_SOURCE = linuxptp-$(LINUXPTP_VERSION).tgz
+LINUXPTP_SITE = http://sourceforge.net/projects/linuxptp/files/v$(LINUXPTP_VERSION)
+LINUXPTP_LICENSE = GPL-2.0+
+LINUXPTP_LICENSE_FILES = COPYING
+
+define LINUXPTP_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) KBUILD_OUTPUT=$(TARGET_DIR) \
+		EXTRA_CFLAGS="$(TARGET_CFLAGS)" EXTRA_LDFLAGS="$(TARGET_LDFLAGS)" \
+		CC="$(TARGET_CC)" \
+		-C $(@D) all
+endef
+
+define LINUXPTP_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) prefix=/usr DESTDIR=$(TARGET_DIR) \
+		$(TARGET_CONFIGURE_OPTS) -C $(@D) install
+endef
+
+define LINUXPTP_INSTALL_INIT_SYSV
+	$(INSTALL) -m 755 -D $(@D)/package/linuxptp/S65ptp4l \
+		$(TARGET_DIR)/etc/init.d/S65ptp4l
+endef
+
+define LINUXPTP_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -D -m 644 $(LINUXPTP_PKGDIR)/ptp4l.service \
+		$(TARGET_DIR)/usr/lib/systemd/system/ptp4l.service
+	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
+	ln -sf ../../../../usr/lib/systemd/system/ptp4l.service \
+		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/ptp4l.service
+endef
+
+$(eval $(generic-package))
diff --git a/package/linuxptp/ptp4l.service b/package/linuxptp/ptp4l.service
new file mode 100644
index 0000000..ec6bbc5
--- /dev/null
+++ b/package/linuxptp/ptp4l.service
@@ -0,0 +1,10 @@
+[Unit]
+Description=Precision Time Protocol daemon
+After=syslog.target network.target
+
+[Service]
+ExecStart=/usr/sbin/ptp4l -A -i eth0
+Restart=always
+
+[Install]
+WantedBy=multi-user.target
-- 
2.7.4

^ permalink raw reply related


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox