Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Edwards <grant.b.edwards@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] Odd comment in openntpd/Config.in
Date: Mon, 6 Feb 2017 18:19:16 +0000 (UTC)	[thread overview]
Message-ID: <o7aen3$mj0$1@blaine.gmane.org> (raw)
In-Reply-To: 20170206181317.i3gc4336rm7u2lkd@tarshish

On 2017-02-06, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Grant,
>
> On Mon, Feb 06, 2017 at 05:10:56PM +0000, Grant Edwards wrote:
>> In https://git.busybox.net/buildroot/tree/package/openntpd/Config.in:
>> 
>> config BR2_PACKAGE_OPENNTPD
>>        bool "openntpd"
>>        depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>>        [...]
>> 
>> comment "openntpd needs a toolchain w/ NPTL"
>>         [...]
>>         depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
>> 
>> Is the "!" in the comment is a typo?
>
> We want to show the comment only when the toolchain has no NPTL support. So 
> the "!" makes perfect sense to me.

Ah.  That's because you didn't misread it and think that the "depends
on" line was part of the comment itself and not the option that
controls when the comment is displayed.

-- 
Grant Edwards               grant.b.edwards        Yow! Psychoanalysis??
                                  at               I thought this was a nude
                              gmail.com            rap session!!!

  reply	other threads:[~2017-02-06 18:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 17:10 [Buildroot] Odd comment in openntpd/Config.in Grant Edwards
2017-02-06 18:13 ` Baruch Siach
2017-02-06 18:19   ` Grant Edwards [this message]
2017-02-06 18:20 ` Thomas Petazzoni
2017-02-06 18:21 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='o7aen3$mj0$1@blaine.gmane.org' \
    --to=grant.b.edwards@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox