Re: [Buildroot] BR2_DEFCONFIG not being saved by "make savedefconfig"

[Grant Edwards <grant.b.edwards@gmail.com>]

On 2024-09-14, Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:
> On Fri, 13 Sep 2024 14:06:32 -0000 (UTC)
> Grant Edwards <grant.b.edwards@gmail.com> wrote:
>> [...]
>> In my external default config file, I have BR2_DEFCONFIG set to point
>> to the location in my external buildroot tree where the default
>> configuration file is located. When I do "make savedefconfig", the
>> current working configuration is saved to that location has expected.
>> 
>> However, the BR2_DEFCONFIG setting has vanished from that saved
>> configuration.
>> 
>> Is that expected behavior?
>
> It is, see the main Makefile:
> [...]
> it explicitly removes BR2_DEFCONFIG.
>
> The reasoning is:
>
> commit f71a621d91ec27f175fc84012962f88b1107305f
> Author: Herve Codina <Herve.CODINA@celad.com>
> Date:   Thu Jun 4 10:16:33 2015 +0200
>
>     savedefconfig: Remove BR2_DEFCONFIG from saved defconfig file
>     
>     BR2_DEFCONFIG should not be present in saved defconfig file.
>     
>     The use case is:
>     make qemu_arm_versatile
>     make savedefconfig BR2_DEFCONFIG=my_custom_defconfig
>     
>     BR2_DEFCONFIG is set in my_custom_defconfig with an absolute path
>     to qemu_arm_versatile (value present in .config) and set in
>     my_custom_defconfig as it is different from default mentioned in
>     config.in (default is BR2_DEFCONFIG from environment).
>     
>     On savedefconfig recipe, simply remove BR2_DEFCONFIG from generated file
>
> Not sure I fully grasp the reasoning from back then.

I certainly don't. I can work around it by running the buildroot
"make" from a parent make where I export the value of BR2_DEFCONFIG.




_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot