[Buildroot] [PATCH 1/1] package/bluez5_utils: needs readline

[Bernd Kuhls <bernd.kuhls@t-online.de>]

Am Sun, 14 Jan 2018 07:32:04 +0200 schrieb Baruch Siach:

> Hi Bernd,
> 
> On Sat, Jan 13, 2018 at 11:45:32PM +0100, Bernd Kuhls wrote:
[...]
>> +	select BR2_PACKAGE_READLINE
> 
> I don't think that this is the correct fix. The bluez README file says:
> 
>         --disable-client
> 
>                 Disable support for the command line client
> 
>                 By default the command line client is enabled and uses
>                 the readline library. For specific systems where BlueZ
>                 is configured by other means, the command line client
>                 can be disabled and the dependency on readline is
>                 removed.
> 
> So this does not look like a decision to make readline a mandatory
> dependency,
> but a bug that needs to be fixed upstream.

Hi Baruch,

this commit https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?
id=70b8b754f8e6f9abe9211c686b279dbef16bf666

"client: Make use of bt_shell.
Use bt_shell instead of readline directly."

removed readline code from client code and replaced it with calls to 
bt_shell, bt_shell itself is not used exclusively by client code anymore, 
see the commit I mentioned in my patch ( https://git.kernel.org/pub/scm/
bluetooth/bluez.git/commit/?id=bee3796113196da1b3f56da42fcae4d9bae6695e )
and the many source code files which include "src/shared/shell.h".

Afaics this does look like an outdated README file and not a bug in the 
source code, what do you think? Before writing to the bluez devs I would 
like to reach a consensus about what to ask them ;)

Regards, Bernd