Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vadym Kochan <vadym.kochan@plvision.eu>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/keepalived: make suport for Linux headers >= 3.2
Date: Sun, 25 Oct 2020 20:01:57 +0200	[thread overview]
Message-ID: <vrcxh24kmikwve.fsf@plvision.eu> (raw)
In-Reply-To: <20201025102518.410aa9f3@windsurf.home>


Hi Thomas,

Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

> Hello Vadym,
>
> On Fri, 16 Oct 2020 20:07:53 +0200
> Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>
>> On Fri, 16 Oct 2020 16:51:20 +0300
>> Vadym Kochan <vadym.kochan@plvision.eu> wrote:
>> 
>> > > Was the kernel headers check in keepalived mentioned in the commit log
>> > > fixed later on ?
>> > >     
>> > 
>> > Looks like the original issue was related to ipset.  
>> 
>> Right, and ? Why has the issue disappeared ?
>
> Since I got no reply on this question, I've marked the patch as Changes
> Requested. Do not hesitate to send an updated version of the patch,
> with a more detailed commit log that provides additional explanations.
>
> Thanks!
>
> Thomas

Yes, thats OK as I plan to do more deep investigation by testing of
several builds with and without ipset tools, just still had no time.
It seems to me that Config.in needs some additional condition by
considering if ipset is enabled or not.

Regards,
Vadym

      reply	other threads:[~2020-10-25 18:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 12:22 [Buildroot] [PATCH] package/keepalived: make suport for Linux headers >= 3.2 Vadym Kochan
2020-10-16 12:27 ` Thomas Petazzoni
     [not found]   ` <20201016135120.GA4852@plvision.eu>
2020-10-16 18:07     ` Thomas Petazzoni
2020-10-25  9:25       ` Thomas Petazzoni
2020-10-25 18:01         ` Vadym Kochan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vrcxh24kmikwve.fsf@plvision.eu \
    --to=vadym.kochan@plvision.eu \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox