From: Vadym Kochan <vadym.kochan@plvision.eu>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: buildroot@busybox.net, Francois Perrad <fperrad@gmail.com>,
Vadim Kochan <vadim4j@gmail.com>,
Serhiy Boiko <serhiy.boiko@plvision.eu>
Subject: Re: [Buildroot] [PATCH] package/mstpd: new package
Date: Mon, 27 Sep 2021 11:02:26 +0300 [thread overview]
Message-ID: <vrcxh2wnn2a1kd.fsf@plvision.eu> (raw)
In-Reply-To: <fba75762-e27c-7530-b133-b11735c24c7b@mind.be>
Hi All,
Arnout Vandecappelle <arnout@mind.be> writes:
> Hi Francois,
>
> On 20/09/2021 21:24, Francois Perrad wrote:
> [snip]
>> diff --git a/package/mstpd/mstpd.mk b/package/mstpd/mstpd.mk
>> new file mode 100644
>> index 000000000..0e5c9714c
>> --- /dev/null
>> +++ b/package/mstpd/mstpd.mk
>> @@ -0,0 +1,13 @@
>> +################################################################################
>> +#
>> +# mstpd
>> +#
>> +################################################################################
>> +
>> +MSTPD_VERSION = 0.0.9
>> +MSTPD_SITE = $(call github,mstpd,mstpd,$(MSTPD_VERSION))
>> +MSTPD_AUTORECONF = YES
>> +MSTPD_LICENSE = GPL-2.0
>
> There is actually hmac_md5.c that has a different license. So I added that
> one, and I added it to LICENSE_FILES as well and to the hash file.
>
>> +MSTPD_LICENSE_FILES = LICENSE
>> +
>
>
> Vadim (in Cc) posted the same package a year ago. He had
>
> +# mstpd requires that it is installed into /sbin, not /usr/sbin
> +MSTPD_CONF_OPTS = \
> + --sbindir=/sbin
>
> which he later explained with "it should point to /sbin because
> Linux's bridge implementation calls /sbin/bridge-stp in case the STP
> handling is delegated to user space." - which sounds pretty feasible to me...
>
This is can be checked at least by this:
https://elixir.bootlin.com/linux/v5.15-rc3/source/net/bridge/br_private.h#L51
So may be just create /sbin/bridge-stp link.
> Did you test this with STP and with a non-unified /usr?
>
> I've anyway alreayd applied as-is to master (with the license fix), but please
> check if the --sbindir is needed.
>
> Regards,
> Arnout
>
>> +$(eval $(autotools-package))
>>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-09-27 8:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 19:24 [Buildroot] [PATCH] package/mstpd: new package Francois Perrad
2021-09-26 21:42 ` Arnout Vandecappelle
2021-09-27 8:02 ` Vadym Kochan [this message]
2021-09-28 8:08 ` Arnout Vandecappelle
-- strict thread matches above, loose matches on Subject: below --
2020-09-19 20:19 Vadym Kochan
2020-09-22 19:58 ` Thomas Petazzoni
2020-09-22 20:16 ` vadim4j at gmail.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vrcxh2wnn2a1kd.fsf@plvision.eu \
--to=vadym.kochan@plvision.eu \
--cc=arnout@mind.be \
--cc=buildroot@busybox.net \
--cc=fperrad@gmail.com \
--cc=serhiy.boiko@plvision.eu \
--cc=vadim4j@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox