From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C80FBA32 for ; Fri, 12 May 2023 09:33:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F3BB122801; Fri, 12 May 2023 09:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1683883981; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vmBo+NGFqmIXdbm1O96zbrz4OKnrzIKDjUZUdLDEnms=; b=AS0annHWGnrHROC5JJ4wjAwrajGhzf/R6JH4ZoSLo6QDFMVt/Wa9mfbXeWGH23mjk9VI76 IYXcipPWrCkicI6+DhpcY5V9v06JWVjynlsJ3YkBzI6MCka4aH48ttpdKZKC4/b1yikEyf NH1bej7H+8Pz/CXkioSFdHF4YaSY5zc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1683883982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vmBo+NGFqmIXdbm1O96zbrz4OKnrzIKDjUZUdLDEnms=; b=chDJA3pMdDPFmoCx21tvCn5J2pPFlUQ57xQt0COxnqB2nvjLJ1lpmpaOIsz2s7nH5SaSiR +0Zr5axSVSKd6RBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E922B13499; Fri, 12 May 2023 09:33:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tiDcOM0HXmSdRAAAMHmgww (envelope-from ); Fri, 12 May 2023 09:33:01 +0000 From: Martin Jambor To: Florian Weimer , gcc@gcc.gnu.org Cc: c-std-porting@lists.linux.dev Subject: Re: More C type errors by default for GCC 14 In-Reply-To: <877cth66qb.fsf@oldenburg.str.redhat.com> References: <877cth66qb.fsf@oldenburg.str.redhat.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/28.2 (x86_64-suse-linux-gnu) Date: Fri, 12 May 2023 11:33:01 +0200 Message-ID: Precedence: bulk X-Mailing-List: c-std-porting@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, On Tue, May 09 2023, Florian Weimer via Gcc wrote: > TL;DR: This message is about turning implicit-int, > implicit-function-declaration, and possibly int-conversion into errors > for GCC 14. > FWIW, I personally support the proposal. Regarding the huge discussion that ensued, I would just like to point out that the proposal is put forward by people from organizations which are huge users of GCC and know perfectly well the transition will be painful and yet are prepared face it, for reasons that were nicely explained by Florian. AFAIK, we at SUSE share the sentiment. [...] > Regarding mechanics of the necessary opt out facility, Clang used > -Werror=3D=E2=80=A6 by default, but that seems a bit hackish to me. Pres= ently, we > cannot use -std=3Dgnu89 etc. to opt out because there are packages which > require both C89-only language features and C99-style inlining, which is > currently not a combination supported by GCC (but maybe that could be > changed). Some build systems do not treat CFLAGS and CXXFLAGS as fully > separate, and a flag approach that works for C and C++ without > introducing any new warnings would be most convenient. So maybe we > could use -fpermissive for C as well. I like -fpermissive, but the -Wno-error-... options are actually quite intuitive, perhaps we could do both? But I do not have a strong preference. > One fairly big GCC-internal task is to clear up the C test suite so that > it passes with the new compiler defaults. I already have an offer of > help for that, so I think we can complete this work in a reasonable time > frame. > So, a note to all users of cvise, creduce, delta etc.: Add appropriate -Werror flags to your checking scripts so that we don't add more of this :-) Thanks for putting effort into this. Martin