From: David Gibson <david@gibson.dropbear.id.au>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: ccan <ccan@lists.ozlabs.org>
Subject: Re: [PATCH] ccanlint: enhance and streamline "output" testing lines.
Date: Tue, 29 Sep 2015 00:58:32 +1000 [thread overview]
Message-ID: <20150928145832.GO11620@voom.redhat.com> (raw)
In-Reply-To: <20150928143236.GN11620@voom.redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 706 bytes --]
On Tue, Sep 29, 2015 at 12:32:36AM +1000, David Gibson wrote:
> On Mon, Sep 28, 2015 at 12:48:03PM +0930, Paul 'Rusty' Russell wrote:
> > 1) Require "" around input
> > 2) Make them optional around output: if not there, loose match whitespace
> > 3) Handle \n in output.
> > 4) Document that "Given xxx" is optional.
>
> Patch looks fine to me.
I take that back. With a bit more playing, noticed that if you
*don't* put" around the input, it will silently skip the example
expected output test.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
next prev parent reply other threads:[~2015-09-28 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 3:18 [PATCH] ccanlint: enhance and streamline "output" testing lines Rusty Russell
2015-09-28 14:32 ` David Gibson
2015-09-28 14:58 ` David Gibson [this message]
2015-09-28 21:48 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928145832.GO11620@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=ccan@lists.ozlabs.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox