From: David Gibson <david@gibson.dropbear.id.au>
To: Dan Good <dan@dancancode.com>
Cc: ccan@lists.ozlabs.org
Subject: Re: deque: New module
Date: Mon, 28 Dec 2015 14:44:36 +1100 [thread overview]
Message-ID: <20151228034436.GB15174@voom> (raw)
In-Reply-To: <20151228034337.GA15174@voom>
[-- Attachment #1.1: Type: text/plain, Size: 836 bytes --]
On Mon, Dec 28, 2015 at 02:43:37PM +1100, David Gibson wrote:
> On Wed, Dec 23, 2015 at 12:11:44PM +0000, Dan Good wrote:
> > deque - type-preserving resizing circular deque
>
> Concept looks good. There are some fairly minor nits in the
> implementation that I've noted below. However, none are serious
> enough to hold up merging, so I've applied this. I did modify
> trivially to remove some trailing whitespace.
>
> It would be nice to address some of the comments in follow up
> commits, particularly some of the portability issues.
Forgot to say:
I've also added this module to your key so you have push access.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
next prev parent reply other threads:[~2015-12-28 3:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 12:11 deque: New module Dan Good
2015-12-28 3:43 ` David Gibson
2015-12-28 3:44 ` David Gibson [this message]
2015-12-29 6:00 ` Dan Good
2015-12-31 12:38 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151228034436.GB15174@voom \
--to=david@gibson.dropbear.id.au \
--cc=ccan@lists.ozlabs.org \
--cc=dan@dancancode.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox