From: David Gibson <david@gibson.dropbear.id.au>
To: Dan Good <dan@gooddan.com>
Cc: ccan@lists.ozlabs.org
Subject: Re: Test failure in rszshm
Date: Wed, 3 Feb 2016 00:36:32 +1100 [thread overview]
Message-ID: <20160202133632.GE15080@voom.fritz.box> (raw)
In-Reply-To: <CACNkOJNJS=8MOqHQA-kGwJV6odXzYY3Tz2HjmWuaj_0tPg_yYQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1253 bytes --]
On Mon, Feb 01, 2016 at 04:15:06PM +0000, Dan Good wrote:
> That particular test is asking mmap to create a mapping of size UINT64_MAX
> and expecting it to fail with ENOMEM. Are you getting a different
> errno?
Yes, it seems I'm getting EINVAL. But the EINVAL is coming from the
mmap() call, *not* the initial tests in rszshm_mk() which explicitly
set EINVAL.
But what's *really* weird, is I get it when I run ccanlint directly,
but not when it then re-runs the tests under gdb. And as far as I can
tell mmap() is getting exactly the same arguments :/.
>
> On Mon, Feb 1, 2016 at 6:07 AM David Gibson <david@gibson.dropbear.id.au>
> wrote:
>
> > So, for me at least, ccanlint is failing on the rszshm module (and
> > therefore make check is failing as well). I only see one commit for
> > that module, so I think it must have always been broken.
> >
> > not ok 13 - rszshm_mk(&t, 4096, NULL, scan) == NULL && errno == ENOMEM
> > # Failed test (/home/dwg/src/ccan/ccan/rszshm/test/run.c:main() at
> > line 96)
> >
> >
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
next prev parent reply other threads:[~2016-02-02 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 11:08 Test failure in rszshm David Gibson
[not found] ` <CACNkOJNJS=8MOqHQA-kGwJV6odXzYY3Tz2HjmWuaj_0tPg_yYQ@mail.gmail.com>
2016-02-02 13:36 ` David Gibson [this message]
2016-02-03 5:52 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202133632.GE15080@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=ccan@lists.ozlabs.org \
--cc=dan@gooddan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox