From: David Gibson <david@gibson.dropbear.id.au>
To: Kevin Locke <kevin@kevinlocke.name>
Cc: ccan@lists.ozlabs.org
Subject: Re: [PATCH 0/9] configurator: Support for Windows and MSVC
Date: Tue, 20 Sep 2016 14:48:22 +1000 [thread overview]
Message-ID: <20160920044822.GJ20488@umbus> (raw)
In-Reply-To: <cover.1474239353.git.kevin@kevinlocke.name>
[-- Attachment #1.1: Type: text/plain, Size: 2960 bytes --]
On Sun, Sep 18, 2016 at 06:51:57PM -0600, Kevin Locke wrote:
> Hi all,
>
> This patch series adds support for building configurator with Microsoft
> Visual C++ and running it on Windows. The motivation is to add
> sufficient support for Windows to allow using header-only modules
> with minimal hassle. For me, this patch series is sufficient, so I
> don't have any further plans for changes to other files or the build
> system at the moment.
First, thanks for this. ccan isn't supposed to be platform specific,
but it kind of is at the moment, simply because most of the
contributions have been from Linux developers. I'm really happy to
see some work to make it useful on different platforms.
Second, because I'm not and have never been a Windows dev, my ability
to review these is limited - so I'm inclined to apply anything that
doesn't break builds on Linux / POSIX.
Third, because most of the main ccan contributors are not Windows
devs, I'm a bit worried about bitrot. If you can think of any way of
making some kind of automated smoke test form builds on Windows, that
would be terrific. Otherwise, I guess we'll just hope for the best.
> The two patches that are particularly likely to raise objections are
> patch 3 and 8:
>
> Patch 3 adds a copy of the err.h functions used by configurator to work
> around the lack of err.h on Windows. If this is too much code to lump
> into configurator.c, I can split it out (and copy err.{c,h} verbatim
> from musl) or call fprintf+exit directly.
>
> Patch 8 adds the output cflag (-o) to DEFAULT_CFLAGS and the expected
> configurator cflags argument. This changes both the configurator API
> and the config.h API and will break existing code which depend on these.
> If that is unacceptable, I'd be open to implementing a
> backwards-compatible alternative. One idea would be to add an
> --output-cflag option to configurator, although it will require quite a
> bit of argument parsing code. I'm open to other alternatives as well.
>
> Thanks for considering,
> Kevin
>
> Kevin Locke (9):
> configurator: Replace unlink with remove
> configurator: Reimplement run using popen
> configurator: Inline err.h functions from musl libc
> configurator: Use native directory separator
> configurator: Mark non-Windows tests MAY_NOT_COMPILE
> configurator: Print test source without cat
> configurator: Fix compiler warning with compare
> configurator: Pass output cflag to configurator
> configurator: DEFAULT_{COMPILER,FLAGS} for MSVC
>
> Makefile | 2 +-
> tools/configurator/configurator.c | 197 +++++++++++++++++++++++++-------------
> 2 files changed, 131 insertions(+), 68 deletions(-)
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
next prev parent reply other threads:[~2016-09-20 5:37 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 0:51 [PATCH 0/9] configurator: Support for Windows and MSVC Kevin Locke
2016-09-19 0:51 ` [PATCH 1/9] configurator: Replace unlink with remove Kevin Locke
2016-09-20 4:50 ` David Gibson
2016-09-19 0:51 ` [PATCH 2/9] configurator: Reimplement run using popen Kevin Locke
2016-09-20 5:00 ` David Gibson
2016-09-20 6:22 ` Kevin Locke
2016-09-20 13:28 ` David Gibson
2016-09-19 0:52 ` [PATCH 3/9] configurator: Inline err.h functions from musl libc Kevin Locke
2016-09-20 5:03 ` David Gibson
2016-09-27 6:11 ` Rusty Russell
2016-09-19 0:52 ` [PATCH 4/9] configurator: Use native directory separator Kevin Locke
2016-09-20 5:04 ` David Gibson
2016-09-19 0:52 ` [PATCH 5/9] configurator: Mark non-Windows tests MAY_NOT_COMPILE Kevin Locke
2016-09-20 5:06 ` David Gibson
2016-09-19 0:52 ` [PATCH 6/9] configurator: Print test source without cat Kevin Locke
2016-09-20 5:09 ` David Gibson
2016-09-19 0:52 ` [PATCH 7/9] configurator: Fix compiler warning with compare Kevin Locke
2016-09-20 5:09 ` David Gibson
2016-09-19 0:52 ` [PATCH 8/9] configurator: Pass output cflag to configurator Kevin Locke
2016-09-20 5:23 ` David Gibson
2016-09-20 6:22 ` Kevin Locke
2016-09-20 13:32 ` David Gibson
2016-09-19 0:52 ` [PATCH 9/9] configurator: DEFAULT_{COMPILER, FLAGS} for MSVC Kevin Locke
2016-09-20 4:48 ` David Gibson [this message]
2016-09-20 6:21 ` [PATCH 0/9] configurator: Support for Windows and MSVC Kevin Locke
2016-09-20 12:25 ` David Gibson
2016-09-20 14:16 ` Daniel Burke
2016-09-22 2:00 ` David Gibson
2016-09-23 3:33 ` [PATCH v2 00/13] " Kevin Locke
2016-09-23 3:33 ` [PATCH v2 01/13] configurator: Replace unlink with remove Kevin Locke
2016-09-27 4:50 ` David Gibson
2016-09-23 3:33 ` [PATCH v2 02/13] configurator: Reimplement run using popen Kevin Locke
2016-09-27 4:52 ` David Gibson
2016-09-28 5:29 ` [PATCH v3 2/13] " Kevin Locke
2016-09-23 3:33 ` [PATCH v2 03/13] configurator: Inline err.h functions from musl libc Kevin Locke
2016-09-27 5:01 ` David Gibson
2016-09-28 5:35 ` [PATCH v3 3/13] configurator: Inline err.h functions Kevin Locke
2016-09-23 3:33 ` [PATCH v2 04/13] configurator: Use native directory separator Kevin Locke
2016-09-27 5:05 ` David Gibson
2016-09-23 3:33 ` [PATCH v2 05/13] configurator: Mark non-Windows tests MAY_NOT_COMPILE Kevin Locke
2016-09-27 5:05 ` David Gibson
2016-09-23 3:33 ` [PATCH v2 06/13] configurator: Print test source without cat Kevin Locke
2016-09-27 5:06 ` David Gibson
2016-09-28 5:38 ` Kevin Locke
2016-09-23 3:33 ` [PATCH v2 07/13] configurator: Fix compiler warning with compare Kevin Locke
2016-09-27 5:09 ` David Gibson
2016-09-23 3:33 ` [PATCH v2 08/13] configurator: Add output cflag option and macro Kevin Locke
2016-09-27 5:17 ` David Gibson
2016-09-23 3:33 ` [PATCH v2 09/13] configurator: DEFAULT_{COMPILER, FLAGS} for MSVC Kevin Locke
2016-09-27 5:17 ` David Gibson
2016-09-23 3:33 ` [PATCH v2 10/13] configurator: Fix warning in HAVE_FOR_LOOP_DECLARATION Kevin Locke
2016-09-27 5:10 ` David Gibson
2016-09-23 3:33 ` [PATCH v2 11/13] configurator: Return pointer difference as ptrdiff_t Kevin Locke
2016-09-27 5:10 ` David Gibson
2016-09-23 3:33 ` [PATCH v2 12/13] Makefile: Define CFLAGS_FORCE_C_SOURCE macro Kevin Locke
2016-09-27 5:18 ` David Gibson
2016-09-27 6:18 ` Rusty Russell
2016-09-28 2:01 ` David Gibson
2016-10-26 2:49 ` Rusty Russell
2016-09-23 3:33 ` [PATCH v2 13/13] Add appveyor.yml Kevin Locke
2016-09-27 5:20 ` David Gibson
2016-09-28 6:01 ` [PATCH v3 " Kevin Locke
2016-09-27 5:23 ` [PATCH v2 00/13] configurator: Support for Windows and MSVC David Gibson
2016-09-27 6:20 ` Rusty Russell
2016-09-28 6:32 ` Kevin Locke
2016-09-28 6:28 ` Kevin Locke
2016-09-29 0:21 ` David Gibson
2016-09-29 0:44 ` [PATCH v3 0/7] " Kevin Locke
2016-09-29 0:44 ` [PATCH v3 1/7] configurator: Reimplement run using popen Kevin Locke
2016-09-29 0:44 ` [PATCH v3 2/7] configurator: Inline err.h functions Kevin Locke
2016-09-29 0:44 ` [PATCH v3 3/7] configurator: Print test source without cat Kevin Locke
2016-09-29 0:44 ` [PATCH v3 4/7] configurator: Add output cflag option and macro Kevin Locke
2016-09-29 0:44 ` [PATCH v3 5/7] configurator: DEFAULT_{COMPILER, FLAGS} for MSVC Kevin Locke
2016-09-29 0:44 ` [PATCH v3 6/7] Makefile: Define CFLAGS_FORCE_C_SOURCE macro Kevin Locke
2016-09-29 0:44 ` [PATCH v3 7/7] Add appveyor.yml Kevin Locke
2016-09-30 15:08 ` [PATCH v3 0/7] configurator: Support for Windows and MSVC David Gibson
2016-10-03 3:14 ` Kevin Locke
2016-12-02 20:23 ` AppVeyor custom Git URL support (was Re: [PATCH v3 0/7] configurator: Support for Windows and MSVC) Kevin Locke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920044822.GJ20488@umbus \
--to=david@gibson.dropbear.id.au \
--cc=ccan@lists.ozlabs.org \
--cc=kevin@kevinlocke.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox