[PATCH] fix misuse of typesafe_cb_cast() in example

[PATCH] fix misuse of typesafe_cb_cast() in example

[Yubin Ruan]

From 32f86c701ab0e0ad0ad6981314a9bff2dc5ebb74 Mon Sep 17 00:00:00 2001
From: Yubin Ruan <ablacktshirt@gmail.com>
Date: Wed, 14 Mar 2018 11:14:54 +0800
Subject: [PATCH] fix misuse of typesafe_cb_cast() in example

Signed-off-by: Yubin Ruan <ablacktshirt@gmail.com>
---
 ccan/typesafe_cb/typesafe_cb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ccan/typesafe_cb/typesafe_cb.h b/ccan/typesafe_cb/typesafe_cb.h
index 942d5c2..126d325 100644
--- a/ccan/typesafe_cb/typesafe_cb.h
+++ b/ccan/typesafe_cb/typesafe_cb.h
@@ -27,7 +27,7 @@
  *	// We can take either an unsigned long or a void *.
  *	void _set_some_value(void *val);
  *	#define set_some_value(e)			\
- *		_set_some_value(typesafe_cb_cast(void *, (e), unsigned long))
+ *		_set_some_value(typesafe_cb_cast(void *, unsigned long, (e)))
  */
 #define typesafe_cb_cast(desttype, oktype, expr)			\
 	__builtin_choose_expr(						\
-- 
2.7.4

_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan

Re: [PATCH] fix misuse of typesafe_cb_cast() in example

[David Gibson]

[-- Attachment #1.1: Type: text/plain, Size: 1254 bytes --]

On Wed, Mar 14, 2018 at 11:16:42AM +0800, Yubin Ruan wrote:
> From 32f86c701ab0e0ad0ad6981314a9bff2dc5ebb74 Mon Sep 17 00:00:00 2001
> From: Yubin Ruan <ablacktshirt@gmail.com>
> Date: Wed, 14 Mar 2018 11:14:54 +0800
> Subject: [PATCH] fix misuse of typesafe_cb_cast() in example
> 
> Signed-off-by: Yubin Ruan <ablacktshirt@gmail.com>

Applied, thanks.

> ---
>  ccan/typesafe_cb/typesafe_cb.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ccan/typesafe_cb/typesafe_cb.h b/ccan/typesafe_cb/typesafe_cb.h
> index 942d5c2..126d325 100644
> --- a/ccan/typesafe_cb/typesafe_cb.h
> +++ b/ccan/typesafe_cb/typesafe_cb.h
> @@ -27,7 +27,7 @@
>   *	// We can take either an unsigned long or a void *.
>   *	void _set_some_value(void *val);
>   *	#define set_some_value(e)			\
> - *		_set_some_value(typesafe_cb_cast(void *, (e), unsigned long))
> + *		_set_some_value(typesafe_cb_cast(void *, unsigned long, (e)))
>   */
>  #define typesafe_cb_cast(desttype, oktype, expr)			\
>  	__builtin_choose_expr(						\

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan