From: David Gibson <david@gibson.dropbear.id.au>
To: Yubin Ruan <ablacktshirt@gmail.com>
Cc: ccan@lists.ozlabs.org
Subject: Re: [PATCH] fix misuse of typesafe_cb_cast() in example
Date: Wed, 14 Mar 2018 15:54:28 +1100 [thread overview]
Message-ID: <20180314045428.GG4182@umbus.fritz.box> (raw)
In-Reply-To: <20180314031641.GB6951@HP>
[-- Attachment #1.1: Type: text/plain, Size: 1254 bytes --]
On Wed, Mar 14, 2018 at 11:16:42AM +0800, Yubin Ruan wrote:
> From 32f86c701ab0e0ad0ad6981314a9bff2dc5ebb74 Mon Sep 17 00:00:00 2001
> From: Yubin Ruan <ablacktshirt@gmail.com>
> Date: Wed, 14 Mar 2018 11:14:54 +0800
> Subject: [PATCH] fix misuse of typesafe_cb_cast() in example
>
> Signed-off-by: Yubin Ruan <ablacktshirt@gmail.com>
Applied, thanks.
> ---
> ccan/typesafe_cb/typesafe_cb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ccan/typesafe_cb/typesafe_cb.h b/ccan/typesafe_cb/typesafe_cb.h
> index 942d5c2..126d325 100644
> --- a/ccan/typesafe_cb/typesafe_cb.h
> +++ b/ccan/typesafe_cb/typesafe_cb.h
> @@ -27,7 +27,7 @@
> * // We can take either an unsigned long or a void *.
> * void _set_some_value(void *val);
> * #define set_some_value(e) \
> - * _set_some_value(typesafe_cb_cast(void *, (e), unsigned long))
> + * _set_some_value(typesafe_cb_cast(void *, unsigned long, (e)))
> */
> #define typesafe_cb_cast(desttype, oktype, expr) \
> __builtin_choose_expr( \
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
prev parent reply other threads:[~2018-03-14 5:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 3:16 [PATCH] fix misuse of typesafe_cb_cast() in example Yubin Ruan
2018-03-14 4:54 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314045428.GG4182@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=ablacktshirt@gmail.com \
--cc=ccan@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox