public inbox for ccan@ozlabs.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Dan Good <dan@gooddan.com>, ccan@lists.ozlabs.org
Subject: Re: [PATCH] altstack: New module
Date: Fri, 29 Jan 2016 06:23:00 +1030	[thread overview]
Message-ID: <87wpqtscpv.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CACNkOJMaqTRm9wrbdV8svCzFvosi2a6QXUGJ6jJepQ5-_R-oSA@mail.gmail.com>

Dan Good <dan@gooddan.com> writes:
> I built an ubuntu-15.10-server to see if I could replicate the issue, but
> the tests all pass.  I've also run it on CentOS 7 and a current Amazon
> Linux AMI.  Are you running a stock Ubuntu?  Any security hardening?

No, out-of-box defaults pretty much.

Of course, it's valgrind.  The following patch "fixes" it.

diff --git a/ccan/altstack/_info b/ccan/altstack/_info
index 1b03770..b411c29 100644
--- a/ccan/altstack/_info
+++ b/ccan/altstack/_info
@@ -109,6 +109,7 @@
  *	// (altstack@103) SIGSEGV caught
  *	// altstack return: -1, fn return: (nil)
  *
+ * Ccanlint: tests_pass_valgrind FAIL
  * License: APACHE-2
  * Author: Dan Good <dan@dancancode.com>
  */

Cheers,
Rusty.
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan

      parent reply	other threads:[~2016-01-29  0:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26 22:18 [PATCH] altstack: New module Dan Good
2016-01-27  4:51 ` Rusty Russell
     [not found]   ` <CACNkOJMaqTRm9wrbdV8svCzFvosi2a6QXUGJ6jJepQ5-_R-oSA@mail.gmail.com>
2016-01-28 19:53     ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpqtscpv.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=ccan@lists.ozlabs.org \
    --cc=dan@gooddan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox