From: David Gibson <david@gibson.dropbear.id.au>
To: Ashok Raj <ashok.raj@intel.com>
Cc: ccan@lists.ozlabs.org
Subject: Re: [ccan] New to ccan
Date: Sat, 1 Jun 2024 19:23:07 +1000 [thread overview]
Message-ID: <Zlroeyxsa_d80DuA@zatzit> (raw)
In-Reply-To: <ZjwL8iUYUeJQZl8m@a4bf019067fa.jf.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 2049 bytes --]
On Wed, May 08, 2024 at 04:34:10PM -0700, Ashok Raj wrote:
> On Tue, May 07, 2024 at 12:54:07PM -0700, Ashok Raj wrote:
> > Hi
> >
> > I'm new to ccan. I'm trying to use just part of the project (just one
> > module) in another tool.
> >
> > I didn't catch the exact method to replicate a single module.
As I recall, we talked about this a bit, but never did come up with a
great method.
> So I went past this step and able to include it in my project.
>
> But I see the following warning
>
> [16/247] Compiling C object libccan.a.p/ccan_bitmap_bitmap.c.o
> In file included from ../ccan/bitmap/bitmap.c:5:
> ../ccan/bitmap/bitmap.h: In function bitmap_set_bit:
> ../ccan/bitmap/bitmap.h:61:43: warning: declaration of bitmap shadows a global declaration [-Wshadow]
> 61 | static inline void bitmap_set_bit(bitmap *bitmap, unsigned long n)
> | ~~~~~~~~^~~~~~
> ../ccan/bitmap/bitmap.h:26:3: note: shadowed declaration is here
> 26 | } bitmap;
> | ^~~~~~
>
>
> If I were to change the parameter name to _bitmap and in all usages the
> warning disappears. Weird the definition its pointing to is this
> typedewf
Huh. Looks like the code is relying on types and variables/parameters
being in different namespaces, but that warning doesn't like that. I
guess we must not have had the relevant warning enabled before.
I made a fix, but it's been so long since I pushed things to the ccan
repo, I've forgotten how and will have to figure it out again.
Speaking of which... ccan is largely moribund at this point. Neither
Rusty nor I has any real time to devote to it. And in my case,
collecting C examples - even very nice ones - has become a lot
compelling with the emergence of viable alternative systems
programming languages (Rust, Go, Zig).
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
next prev parent reply other threads:[~2024-06-01 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 19:54 [ccan] New to ccan Ashok Raj
2024-05-08 23:34 ` Ashok Raj
2024-06-01 9:23 ` David Gibson [this message]
2024-06-01 12:12 ` Mark Naughton
2024-06-03 3:56 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zlroeyxsa_d80DuA@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=ashok.raj@intel.com \
--cc=ccan@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox