From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88670C433ED for ; Tue, 18 May 2021 01:00:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6515661090 for ; Tue, 18 May 2021 01:00:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345303AbhERBBv (ORCPT ); Mon, 17 May 2021 21:01:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33291 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239539AbhERBBt (ORCPT ); Mon, 17 May 2021 21:01:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621299631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r0t6deYIVcRXZIRfZnnq1BbzLoqrt/WuYir452iK3dc=; b=ha2+4OYPSSO0f46gKOQ+axwnQt32qnTyyuGWg8nEWh34/QTliHE0TmYSOswySUTE53OFwo mtjJZScv7LtYIX9hJWcENhSNDSYD/0y9anz/LX5GAmrYuNGlHj+3SsXvwkjlAZG/gdYJ67 a167iBHZzTyBm6x6Z/3EyiNkv1wIaSk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-UyLcSgmvMZuKYV7T8KsdaQ-1; Mon, 17 May 2021 21:00:28 -0400 X-MC-Unique: UyLcSgmvMZuKYV7T8KsdaQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AC20B107ACE3; Tue, 18 May 2021 01:00:27 +0000 (UTC) Received: from [10.72.12.181] (ovpn-12-181.pek2.redhat.com [10.72.12.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 34BC45C232; Tue, 18 May 2021 01:00:24 +0000 (UTC) Subject: Re: [PATCH v2 0/2] ceph: send io size metrics to mds daemon To: Jeff Layton , Ilya Dryomov Cc: Patrick Donnelly , "Yan, Zheng" , Ceph Development References: <20210513014053.81346-1-xiubli@redhat.com> <89def1a8e65e443ba7aca7c4ff138e6c6041a5df.camel@kernel.org> <70554cca-9985-338c-de04-4053a4a04872@redhat.com> <7a9d7350f30ee91138876b7330324db582713ee8.camel@kernel.org> From: Xiubo Li Message-ID: <04b4b11c-0411-cacd-9504-36be3437169c@redhat.com> Date: Tue, 18 May 2021 09:00:21 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <7a9d7350f30ee91138876b7330324db582713ee8.camel@kernel.org> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On 5/17/21 11:46 PM, Jeff Layton wrote: > On Fri, 2021-05-14 at 17:14 +0800, Xiubo Li wrote: >> On 5/14/21 4:57 PM, Ilya Dryomov wrote: >>> On Fri, May 14, 2021 at 2:47 AM Xiubo Li wrote: >>>> On 5/13/21 7:30 PM, Jeff Layton wrote: >>>>> On Thu, 2021-05-13 at 09:40 +0800, xiubli@redhat.com wrote: >>>>>> From: Xiubo Li >>>>>> >>>>>> V2: >>>>>> - change the patch order >>>>>> - replace the fixed 10 with sizeof(struct ceph_metric_header) >>>>>> >>>>>> Xiubo Li (2): >>>>>> ceph: simplify the metrics struct >>>>>> ceph: send the read/write io size metrics to mds >>>>>> >>>>>> fs/ceph/metric.c | 90 ++++++++++++++++++++++++++++++------------------ >>>>>> fs/ceph/metric.h | 79 +++++++++++++++++------------------------- >>>>>> 2 files changed, 89 insertions(+), 80 deletions(-) >>>>>> >>>>> Thanks Xiubo, >>>>> >>>>> These look good. I'll do some testing with them and plan to merge these >>>>> into the testing branch later today. >>>> Sure, take your time. >>> FYI I squashed "ceph: send the read/write io size metrics to mds" into >>> "ceph: add IO size metrics support". > I've dropped this combined patch for now, as it was triggering an MDS > assertion that was hampering testing [1]. I'll plan to add it back once > that problem is resolved in the MDS. > > [1]: https://github.com/ceph/ceph/pull/41357 > > Cheers, Ack. Thanks.