From: Alex Elder <elder@dreamhost.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Sage Weil <sage@newdream.net>, ceph-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] ceph: take a reference to the dentry in d_find_any_alias()
Date: Thu, 29 Dec 2011 08:34:38 -0600 [thread overview]
Message-ID: <1325169278.1131.65.camel@doink> (raw)
In-Reply-To: <20111229091108.GB5257@infradead.org>
On Thu, 2011-12-29 at 04:11 -0500, Christoph Hellwig wrote:
> On Wed, Dec 28, 2011 at 06:05:14PM -0800, Sage Weil wrote:
> > From: Alex Elder <elder@dreamhost.com>
> >
> > The ceph code duplicates __d_find_any_alias(), but it currently
> > does not take a reference to the returned dentry as it should.
> > Replace the ceph implementation with an exact copy of what's
> > found in "fs/dcache.c", and update the callers so they drop
> > their reference when they're done with it.
> >
> > Unfortunately this requires the wholesale copy of the functions
> > that implement __dget(). It would be much nicer to just export
> > d_find_any_alias() from "fs/dcache.c" instead.
>
> Just exporting it would indeed be much better.
Yes, that's the plan. We were originally hoping to get
this into 3.2 and I figured it was too late in the cycle
to be suggesting a (albeit pretty harmless) change to
the dcache code.
I will respin the patches. I'll wait an hour or two
to see what Sage plans to do with these.
-Alex
next prev parent reply other threads:[~2011-12-29 14:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 2:05 [PATCH 0/3] Ceph fixes for 3.2 final Sage Weil
2011-12-29 2:05 ` [PATCH 1/3] ceph: take inode lock when finding an inode alias Sage Weil
2011-12-29 9:10 ` Christoph Hellwig
2011-12-29 2:05 ` [PATCH 2/3] ceph: take a reference to the dentry in d_find_any_alias() Sage Weil
2011-12-29 9:11 ` Christoph Hellwig
2011-12-29 14:34 ` Alex Elder [this message]
2011-12-29 14:54 ` Christoph Hellwig
2011-12-29 2:05 ` [PATCH 3/3] ceph: enable/disable dentry complete flags via mount option Sage Weil
2011-12-29 9:11 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2011-12-22 20:13 [PATCH 1/3] ceph: take inode lock when finding an inode alias Sage Weil
2011-12-22 20:13 ` [PATCH 2/3] ceph: take a reference to the dentry in d_find_any_alias() Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325169278.1131.65.camel@doink \
--to=elder@dreamhost.com \
--cc=ceph-devel@vger.kernel.org \
--cc=hch@infradead.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox