From: Jeff Layton <jlayton@redhat.com>
To: Sage Weil <sweil@redhat.com>
Cc: "Yan, Zheng" <zyan@redhat.com>, Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org
Subject: Re: [PATCH 0/4] ceph: endianness fixes and sparse warning fixes
Date: Fri, 13 Jan 2017 07:36:05 -0500 [thread overview]
Message-ID: <1484310965.2616.7.camel@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1701121623290.5745@piezo.novalocal>
On Thu, 2017-01-12 at 16:23 +0000, Sage Weil wrote:
> On Thu, 12 Jan 2017, Jeff Layton wrote:
> > Just a small set of patches to fix some stuff that sparse was
> > complaining about. Some of these look like real bugs however for
> > anyone trying to use ceph on a big endian arch.
> >
> > Jeff Layton (4):
> > ceph: fix endianness of getattr mask in ceph_d_revalidate
> > ceph: fix endianness bug in frag_tree_split_cmp
> > ceph: fix bogus endianness change in ceph_ioctl_set_layout
> > ceph: fix bad endianness handling in parse_reply_info_extra
> >
> > fs/ceph/dir.c | 5 +++--
> > fs/ceph/inode.c | 3 ++-
> > fs/ceph/ioctl.c | 4 ++--
> > fs/ceph/mds_client.c | 9 +++++----
> > 4 files changed, 12 insertions(+), 9 deletions(-)
>
> Reviewed-by: Sage Weil <sage@redhat.com>
Thanks. Should we send this series to stable? I'm not sure how common
kcephfs mounts are on BE arches, but these bugs would likely prevent it
from working.
Thanks,
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2017-01-13 12:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 16:12 [PATCH 0/4] ceph: endianness fixes and sparse warning fixes Jeff Layton
2017-01-12 16:12 ` [PATCH 1/4] ceph: fix endianness of getattr mask in ceph_d_revalidate Jeff Layton
2017-01-12 16:43 ` Ilya Dryomov
2017-01-12 17:16 ` Jeff Layton
2017-01-12 16:12 ` [PATCH 2/4] ceph: fix endianness bug in frag_tree_split_cmp Jeff Layton
2017-01-12 16:12 ` [PATCH 3/4] ceph: fix bogus endianness change in ceph_ioctl_set_layout Jeff Layton
2017-01-12 16:12 ` [PATCH 4/4] ceph: fix bad endianness handling in parse_reply_info_extra Jeff Layton
2017-01-12 16:23 ` [PATCH 0/4] ceph: endianness fixes and sparse warning fixes Sage Weil
2017-01-13 12:36 ` Jeff Layton [this message]
2017-01-17 18:26 ` David Disseldorp
2017-01-17 18:28 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484310965.2616.7.camel@redhat.com \
--to=jlayton@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=sweil@redhat.com \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox