CEPH filesystem development
 help / color / mirror / Atom feed
From: "Marc Roos" <M.Roos@f1-outsourcing.eu>
To: jlayton <jlayton@kernel.org>, lhenriques <lhenriques@suse.com>
Cc: ceph-devel <ceph-devel@vger.kernel.org>, ceph-users <ceph-users@ceph.io>
Subject: RE: [ceph-users] cephfs snap mkdir strange timestamp
Date: Wed, 11 Mar 2020 11:36:56 +0100	[thread overview]
Message-ID: <17511.6749874846$1583925277@news.gmane.org> (raw)
In-Reply-To: <20200311103142.GA6863@suse.com>


Sorry I am not really developer nor now details about POSIX/fs's. But if 
I may ask, why are you getting this time from the parent?



-----Original Message-----
Sent: 11 March 2020 11:32
To: Jeff Layton
Cc: Marc Roos; ceph-users; ceph-devel@vger.kernel.org
Subject: Re: [ceph-users] cephfs snap mkdir strange timestamp

On Tue, Mar 10, 2020 at 01:39:29PM -0400, Jeff Layton wrote:
...
> > Signed-off-by: Luis Henriques <lhenriques@suse.com>
> > ---
> >  fs/ceph/inode.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index 
> > d01710a16a4a..f4e78ade0871 100644
> > --- a/fs/ceph/inode.c
> > +++ b/fs/ceph/inode.c
> > @@ -82,6 +82,8 @@ struct inode *ceph_get_snapdir(struct inode 
*parent)
> >  	inode->i_mode = parent->i_mode;
> >  	inode->i_uid = parent->i_uid;
> >  	inode->i_gid = parent->i_gid;
> > +	inode->i_mtime = parent->i_mtime;
> > +	inode->i_ctime = parent->i_ctime;
> >  	inode->i_op = &ceph_snapdir_iops;
> >  	inode->i_fop = &ceph_snapdir_fops;
> >  	ci->i_snap_caps = CEPH_CAP_PIN; /* so we can open */
> 
> What about the atime, and the ci->i_btime ?

Yeah, probably makes sense too, although the fuse client doesn't seem to 
touch atime (it does change btime, I missed that).  I'll send v2 in a 
bit.

Cheers,
--
Luis

  reply	other threads:[~2020-03-11 11:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <"H000007100163fdf.1583792359.sx.f1-outsourcing.eu*"@MHS>
     [not found] ` <"H000007100164304.1583836879.sx.f1-outsourcing.eu*"@MHS>
2020-03-10 13:46   ` [ceph-users] cephfs snap mkdir strange timestamp Luis Henriques
2020-03-10 17:39     ` Jeff Layton
2020-03-11 10:31       ` Luis Henriques
2020-03-11 10:36         ` Marc Roos [this message]
     [not found]         ` <"H00000710016454f.1583923016.sx.f1-outsourcing.eu*"@MHS>
2020-03-11 11:04           ` Luis Henriques
2020-03-11 11:25       ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='17511.6749874846$1583925277@news.gmane.org' \
    --to=m.roos@f1-outsourcing.eu \
    --cc=ceph-devel@vger.kernel.org \
    --cc=ceph-users@ceph.io \
    --cc=jlayton@kernel.org \
    --cc=lhenriques@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox