From: "Matt W. Benjamin" <matt@cohortfs.com>
To: Sage Weil <sage@newdream.net>
Cc: ceph-devel <ceph-devel@vger.kernel.org>
Subject: wip-claim-3: Re: wip-claim-2
Date: Tue, 9 Dec 2014 11:49:13 -0500 (EST) [thread overview]
Message-ID: <1838912097.137.1418143753679.JavaMail.root@thunderbeast.private.linuxbox.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1412081357370.10613@cobra.newdream.net>
Pushed wip-claim-3, which makes the changes you requested in IRC, plus adds a unittest block.
Matt
----- "Sage Weil" <sage@newdream.net> wrote:
> On Mon, 8 Dec 2014, Matt W. Benjamin wrote:
> > Hi devs,
> >
> > We've created a new branch wip-claim-2, and new pull request
> https://github.com/linuxbox2/linuxbox-ceph/pull/3
> > based on review feedback.
> >
> > The big change is to replace "volatile" with "sharable", and replace
> "strong_claim()" with "clone_nonsharable()."
> > This may not be perfect, feedback appreciated. It does remove the
> overloading of "claim()", which people found
> > confusing.
>
> I made a few comments, but overall it looks okay to me. Can you make
> the
> next pull request against the github.com/ceph/ceph repo instead of
> your
> clone?
>
> https://github.com/ceph/ceph/compare
>
> Thanks!
> sage
--
Matt Benjamin
CohortFS, LLC.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103
http://cohortfs.com
tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309
prev parent reply other threads:[~2014-12-09 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1582070360.233.1418075135946.JavaMail.root@thunderbeast.private.linuxbox.com>
2014-12-08 21:48 ` wip-claim-2 Matt W. Benjamin
2014-12-08 21:59 ` wip-claim-2 Sage Weil
2014-12-09 16:49 ` Matt W. Benjamin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1838912097.137.1418143753679.JavaMail.root@thunderbeast.private.linuxbox.com \
--to=matt@cohortfs.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox